From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC22FE7716C for ; Thu, 5 Dec 2024 06:06:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1457C6B007B; Thu, 5 Dec 2024 01:06:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0CE506B0082; Thu, 5 Dec 2024 01:06:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EBA6C6B0083; Thu, 5 Dec 2024 01:06:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id C114A6B007B for ; Thu, 5 Dec 2024 01:06:49 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 37AB3A13DC for ; Thu, 5 Dec 2024 06:06:49 +0000 (UTC) X-FDA: 82859871024.27.488D860 Received: from out30-112.freemail.mail.aliyun.com (out30-112.freemail.mail.aliyun.com [115.124.30.112]) by imf29.hostedemail.com (Postfix) with ESMTP id AC2C9120007 for ; Thu, 5 Dec 2024 06:06:23 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=nwfVBXT9; spf=pass (imf29.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.112 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733378796; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kD4rn40nhpvirtRKZO/QK7bvfQH5Z7bhcn9RVOygKrw=; b=YKU6X3vDblrYMSbZiGnDFik0Gzez13hvgMgw7iAGGD7S3ilq/kVY6jl/Qp29iyFpfX6rC3 jk+61zZvVFDRbhRZirOCxn8eLiTER3V3UluKljeBLD/Rob96scKxgtR1+yCWEumqCqgPR5 11322wwyKVHCuWDOk6tnp/dpwJwbmgw= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=nwfVBXT9; spf=pass (imf29.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.112 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733378796; a=rsa-sha256; cv=none; b=raKS+BaZ/mt7Uu31HAvO/deN97Gm5nsnJmI7nYvCnRX8Pk6FDfidRnIMIajD1pKHaGH9/9 7w7fP/zT92fqB1WyBnrYMaYTWxDzcbtaMqU5BkZ7hUKFHOh3ZlTCFkAtr4tEBb3RcYgHzZ 00rvemxM7nYgzzx4sohdvkiNdFoJfI8= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1733378802; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=kD4rn40nhpvirtRKZO/QK7bvfQH5Z7bhcn9RVOygKrw=; b=nwfVBXT9K4i92s4gOqP5Vi/Ba+KpA40p60s+5u7Uxx+9Ib/xfyVXUrGmZq5CbqWsHKQPhSNwgsIYtMjOhTl8xrZUCap8V0SzGxeaTyXQVYkQtjr8+hSB5SaNlSN7trkvMGNO+vkxl89M2HePu7GMD1OkDjtgF6Q5XHUCZx7m+DE= Received: from 30.74.144.118(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0WKsJ0CH_1733378800 cluster:ay36) by smtp.aliyun-inc.com; Thu, 05 Dec 2024 14:06:41 +0800 Message-ID: <48fe508d-ecb9-4607-aab6-cc18b4bc78e9@linux.alibaba.com> Date: Thu, 5 Dec 2024 14:06:40 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: migrate: drop redundant anonymous statistics for file folios migration To: Barry Song <21cnbao@gmail.com> Cc: akpm@linux-foundation.org, david@redhat.com, ying.huang@linux.alibaba.com, ziy@nvidia.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: From: Baolin Wang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam05 X-Stat-Signature: 4e6oereopxj58e7wh8xugnamec4jk4rc X-Rspamd-Queue-Id: AC2C9120007 X-Rspam-User: X-HE-Tag: 1733378783-344899 X-HE-Meta: U2FsdGVkX1+6aTy/EgIA6+AGsyWvoDw1huzJplL38fdPZK+UlKNIqHq98eIRHSQp//kVRScAuWZ//MSXjD1gFLLCPv5/CVEFnEusuJxjj7tbgw0UXozYIy+l3fV5sr9HrukLFs8epRS3TGtQs+gsuTmIXEld7XDyD17wR25rGHB3blIW4hwkWN7eH9SU+vBTERqugLCGGPzTuISrUlMGpRkzx6YGLYjz5lYhYFw+jhUROiDJpclYmUmHs9yNGaJlykymcL3z3wpRK0L/lnNbBgjoxj8g5mho9Fx8KMI3VOfDCpuWhtWW7NB+C+wLmylY2zNZ/SIA2xujRCedzGG8FY1jEbH/72OrKptGkEmW98MnAMwUd+P+kw3v9vB+87L3av1xopoozGnI7QkMAzm0LDQ31oshrRT5BoQOpoq/GwpcoddiRc4PLOtytYgj6W3lCBXmDHEY4TGRtB7PcbPpmkDvtQlr/nAUFCQ7GT65CiUkACYf3b/Gmi7yqHDnK26DhBnvKmvmymXVwwLutav7Up1CJxxqY9udIHzrfIJLocLZS5NLrjl2twCE6/UVg2n2i9vO4GqG0B7r7qblQORjGamqT7/hkZYGZoyK6FeWM0sxuqrtTaufcVyPa7e1/UooCk5g5vLu4rkC4pOlqNfiOTCP7FU3I6oMitkQrKnTrpmLK2zS2BInK1Mu9VQuRtTjNrN3M74roY7MJZNEJgSPs30YZwy9ilBTgjXPUPW+Y/HRDS/t4I6zUuhnBU11mkcRaceDFp9i8Ivtjw+E/lzF0x5tuO0WbEZ0M+mAvcc3XA7L3rS1M7ykJiInfBiedaKTl0TKzOF2Ab1xJalVDAJoNs6Vg1FAEhS0xcdy0suSHjr3w75HcWp2/NWWjuNkgs0YOWPGsqooIJfSr8S8Qj6wedpQrZnpHPN5jYGreCL7CnvvZNhg4e3q8dTDtmVU27T2aTAF7erswCqUM3xWdAr OgO3xkLM RFLMht9CzOOa64aP3kFQI05X402G1YKE7hsMPFbIlLh16aNrEPqdBYV6Q4HKKZYeejUadGRf4DfFB9xuha6kqcqe9o+jplyX9pr/BtiO1bjuTUr7vWyM1E4FylnAnDdDXo4Bmvr95+nvZZGY7rZGa+vNgwPyyuaQ9s0phAbPSiKOqmyW3wVU+m1jp1gMg74R/y+DdBaVlOZ9eHqyq751sdafM9YAjXq5ljFttqYzAO9JtZZlwAfc4g64rb61HalemMlSKaQrmi4tlzMp9RDism5CZ0EZuJu4Afp7nrG/X6xsmPCw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/12/5 13:00, Barry Song wrote: > On Thu, Dec 5, 2024 at 4:54 PM Baolin Wang > wrote: >> >> Commit 5d65c8d758f2 ("mm: count the number of anonymous THPs per size") adds >> a new anonymous counter per THP size, however, when folio_mapping() is not NULL >> during folio migration, it means this is not an anonymous folio, so remove the >> redundant anonymous statistics in this case. > > why? Are you sure anon folios won't call __folio_migrate_mapping()? > folio->mapping is PAGE_MAPPING_ANON for anon folios. > > static __always_inline bool folio_test_anon(const struct folio *folio) > { > return ((unsigned long)folio->mapping & PAGE_MAPPING_ANON) != 0; > } Ah, sorry for noise. This just caught my eyes when reading the code, and I did not think about it deeply before sending a quick patch. Thanks to Barry and Ying for the reminder. Andrew, please drop this quick patch. Sorry for the trouble.