From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFFC2C54798 for ; Sat, 2 Mar 2024 05:08:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 271A694000D; Sat, 2 Mar 2024 00:08:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 221DE940007; Sat, 2 Mar 2024 00:08:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 137BD94000D; Sat, 2 Mar 2024 00:08:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 058F7940007 for ; Sat, 2 Mar 2024 00:08:38 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id CAF001C05C1 for ; Sat, 2 Mar 2024 05:08:37 +0000 (UTC) X-FDA: 81850918674.03.5D5D5AB Received: from out-186.mta0.migadu.com (out-186.mta0.migadu.com [91.218.175.186]) by imf08.hostedemail.com (Postfix) with ESMTP id E60BB160007 for ; Sat, 2 Mar 2024 05:08:35 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=qaXk89WD; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf08.hostedemail.com: domain of chengming.zhou@linux.dev designates 91.218.175.186 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709356116; a=rsa-sha256; cv=none; b=D3qcitJnw1OclTKE1T7fhd58XAnYvDj1ftDXK/bOH/Sb0G/v6O+GC4CUb4mRKnbhVh5i/J 91JHdy2JWJxT2rrljLBBsYy3l1a5arisXDo9aNiVRuw5KRAVkkc+Df4jMGKOB86E/2hUCQ HoE1fPwPUaqECCBS6GgDXq74krMIVwU= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=qaXk89WD; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf08.hostedemail.com: domain of chengming.zhou@linux.dev designates 91.218.175.186 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709356116; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ptlX9mLEl8NLAyVQeAIbNoXD7C1qrUhH1ICdJ+7Ikiw=; b=jwd88qAd6GZywkssh7P7ywQKkmmXl0OUJRPgIAVR4FvKEC3y2FbcUb/hXcYFQE+RnPPpHL C2idnF9+ZGlZakibqpGEh/qZIE0/nFw7GLb1Frz/Pad4ZdE4r/pYw24+BduYPk9WgbdRQv N6hEeUMSGMQP0jSu6mIHJ5Ri6+rUd8w= Message-ID: <48f18693-8598-4f30-a699-3c27545b9b9d@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1709356113; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ptlX9mLEl8NLAyVQeAIbNoXD7C1qrUhH1ICdJ+7Ikiw=; b=qaXk89WDfBp4XoG4G20HIEWCLO2cSFVAgwUSwRGOeBDZ8OXo8pbqbttUE0kq7ujoj+vzwt BFwQCu0miXp9T+T1ASTqnrMghf8R/uVEOCtypJafqK2Z8PMqqm4otIIMFOSFxxToGNHw5h 5Rep4wkwzu9/tOO44MAaSDn/cIxmIhM= Date: Sat, 2 Mar 2024 13:07:47 +0800 MIME-Version: 1.0 Subject: Re: [PATCH] mm, slab: remove memcg_from_slab_obj() To: Vlastimil Babka , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim Cc: Andrew Morton , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org References: <20240301160808.10623-2-vbabka@suse.cz> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Chengming Zhou In-Reply-To: <20240301160808.10623-2-vbabka@suse.cz> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: E60BB160007 X-Stat-Signature: 16x5zwbn9ttyffem9ouz6hfef5p1p6oc X-HE-Tag: 1709356115-648930 X-HE-Meta: U2FsdGVkX1/tmlKWgZgPLoFipAbQqxk8uyqw2UISmxRJbFiBuaj/Wa2Emn665ef5Z94b/0CjqliqGXwj5gzYciObVuMyFhLygsM05n0TclrR1KJS34+Pt7zBQmkSNOpxmIr7QKNn8opVNfCjV/xFTAno2O9e7411Le/Ktk1opklPZZW4LMv3CfhUh+RNV4BrVfFp6+POP8SYUYgsNZCFRJKtEAJsZUFUObIRtilFBUEtoOvmaeTWmeNfhLcwnSVNHz/Sdjjke90GClHm1Dj9fO8tlccaT5wMM54TSvaAYA6FCCGkmMRE+wDrErDkH6YxyWD5z5cafv84GwkQhhOvG5aEUtre5jCA8hCZ1VyFEAF8Io40Ie+YK4XqGfhivqGkmqaHQFwrCYT1Gmix64iwAOekoaDZr82hMZ1vBltvN1ddGTB7hDgilD06rbegliGaMxvga2LAkSVCMZKpnjKapRyFQ8p1rkNFpRAw3K29jZgwGm4yJV/bcmdMS96QNitq2R7KUOlzcWE3wMQ4BLtf8J7mzXRCTbDUKxolKvlTOOEiJ7EtZBIfThTOHu/T6hsjBOoYrM+oL0nHej9xfosqAFxJS5uYGOncywkAGBw8jtj7auedxZ1WAK1qJRJQ0rvKw/VbjiFR2whm7/dfYoXrOV9hKo06fqGwLPB7l58x9yNNreODgJKmz+yHT/1BG8RfRCHuaeIY8ziUEVw5wYnFvHa0akBa8fLFdf/ECrh/Hcn+eqohK3lfoSZFRfQ3V0NPn1h1BPG7zCcicU7Ff+rgQkf5d41rBeEQZgHWgXZhSKryCaFDMCwUBPOdWABblsftVYHmClDBRVaD+KVpE4PWxyU569K9+OXcgUfQCuJApN2um4MLivxOqXhH11Wom/n2Ero3gs+SuLGEzi77RLsSjIIIc7xQYzpRgl+ISn3KCZ0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/3/2 00:08, Vlastimil Babka wrote: > This empty wrapped exists only for !CONFIG_MEMCG_KMEM and seems it was > never used. Probably a leftover from development of a series. > > Signed-off-by: Vlastimil Babka LGTM, thanks! Reviewed-by: Chengming Zhou > --- > mm/slub.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/mm/slub.c b/mm/slub.c > index 12066e69688d..186a8ec28228 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -2028,11 +2028,6 @@ void memcg_slab_alloc_error_hook(struct kmem_cache *s, int objects, > obj_cgroup_uncharge(objcg, objects * obj_full_size(s)); > } > #else /* CONFIG_MEMCG_KMEM */ > -static inline struct mem_cgroup *memcg_from_slab_obj(void *ptr) > -{ > - return NULL; > -} > - > static inline void memcg_free_slab_cgroups(struct slab *slab) > { > }