Re: [PATCH] mm, slab: remove memcg_from_slab_obj()

[Chengming Zhou <chengming.zhou@linux.dev>]

On 2024/3/2 00:08, Vlastimil Babka wrote:
> This empty wrapped exists only for !CONFIG_MEMCG_KMEM and seems it was
> never used. Probably a leftover from development of a series.
> 
> Signed-off-by: Vlastimil Babka <vbabka@suse.cz>

LGTM, thanks!

Reviewed-by: Chengming Zhou <chengming.zhou@linux.dev>

> ---
>  mm/slub.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/mm/slub.c b/mm/slub.c
> index 12066e69688d..186a8ec28228 100644
> --- a/mm/slub.c
> +++ b/mm/slub.c
> @@ -2028,11 +2028,6 @@ void memcg_slab_alloc_error_hook(struct kmem_cache *s, int objects,
>  		obj_cgroup_uncharge(objcg, objects * obj_full_size(s));
>  }
>  #else /* CONFIG_MEMCG_KMEM */
> -static inline struct mem_cgroup *memcg_from_slab_obj(void *ptr)
> -{
> -	return NULL;
> -}
> -
>  static inline void memcg_free_slab_cgroups(struct slab *slab)
>  {
>  }