From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F46AC83038 for ; Tue, 1 Jul 2025 19:32:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C1FC56B009C; Tue, 1 Jul 2025 15:32:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BCFF06B009D; Tue, 1 Jul 2025 15:32:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A70B56B00B7; Tue, 1 Jul 2025 15:32:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 9520B6B009C for ; Tue, 1 Jul 2025 15:32:07 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 3947D107279 for ; Tue, 1 Jul 2025 19:32:07 +0000 (UTC) X-FDA: 83616691494.29.E8A0617 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf05.hostedemail.com (Postfix) with ESMTP id E68C910000F for ; Tue, 1 Jul 2025 19:32:04 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QThG5kYp; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751398325; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pan++p2TzQShdGmkALz5U+1UZhqUiE8i0SNRToHfyJg=; b=ZDTInlIopa3oBr8rF7dX0NxIdehrzjK4D8mKQ1zbYSY6mF9sZXfBVoEW4Rh1V7tXU2aPyH CTzsYJHv7E10nGPnJMB7IUGoEl/nFYsRNTr+WURPE9J71U2Jq9FGZIUrI0U0yqhYLRc7S7 lfpWY7R6KIY2gMUQgWarQpueUGNJ3Ik= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751398325; a=rsa-sha256; cv=none; b=pD2XVB3frz0hPSRn/cO3djJ1ukQA4FEG5zmgy/4ZCdB0aptr7OL4f+D3Zt3iGJYwxfh3UC nt61KgAbFO9qU1JldGcYrndnasgkvxyn/K1ctVWHcf58PfaHcerMDSfTZei+8RagHYX+0q 9d2ozI+NSi3x6q03D6Q1eS5RiliPDO4= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QThG5kYp; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751398324; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=pan++p2TzQShdGmkALz5U+1UZhqUiE8i0SNRToHfyJg=; b=QThG5kYpaphI23a0IFUWVKaoZYGWGF0TiIbErtyy++6WXYQDWhE73L7doEo/ACk4+llLT6 VgAb7CxTBlDTF/Rt4sll02o2pKUvoF4lgZG5YmYUYb5H1tLmAcJ05Ky5TB4UcYkQ1MZdTb Z+j65CyTxvA7nWSJ86wmU0R6BhB2qjI= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-130-8vemEUWkOM6BP6OAshpeDg-1; Tue, 01 Jul 2025 15:32:03 -0400 X-MC-Unique: 8vemEUWkOM6BP6OAshpeDg-1 X-Mimecast-MFC-AGG-ID: 8vemEUWkOM6BP6OAshpeDg_1751398320 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-451deff247cso33309055e9.1 for ; Tue, 01 Jul 2025 12:32:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751398320; x=1752003120; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=pan++p2TzQShdGmkALz5U+1UZhqUiE8i0SNRToHfyJg=; b=I5qyieDJvVqbzOiySr/JMIraLw7fJi64LTQAE1dvYpQaU+zvXJ1d2A1anLvgDEUTbh 8Xsoo7YF2V0zzfh6BAJSMGlVvzlE1RZ9GqTNPRRpoLmwLIAOVuF6sZnw/oHGfarf1C+X voorkvrESqAPyZeQG/ieETke5RtmRi+dhjIktRumKiQuUeONGQIcmaTrmEV01e8z7Z4J /hulQLDXp1SfF6iWbkIUb0b+VvcTXajGvH6jvDJN/4wjeUzUvpbTzN3qZ3rhTX1JQy5W g6GE6bADLC3cTrbmUHT3ILiWcWnWaPLCFKAYUI96Q7ndkjYrDPtwj6pCrbpcxUXYerSh InjA== X-Forwarded-Encrypted: i=1; AJvYcCW1D+Fqq4A/CeOQceRvR3FlV9O23flubvpPVSnnFFEWrhDormdLjfhckeVRB82bP1a3PIwUtLSSFA==@kvack.org X-Gm-Message-State: AOJu0YyCbgr5kV6dT8VnmuAcJywdKuz8kS0vNJahLiuKwyZwscWwETsk KsxolctSWnrU1vtO6QVmQMv+ixRFa8o6BxjF48TIkD5j4Q2j0egvf8FlRgiVfjCwQceIeuEEvuV FMT2ExTr2UqQv+8nZlrHT+PJyf/PMe/yMcb03mJQPFtG9U94/S6pO X-Gm-Gg: ASbGnctP1SsDOOTq9av7HQ6My5Qrk7YwZ14JDfKIvB1YKslEz5z6uBULVpQRutm2/S8 b4xfLnTwCRy7a1Gh8dfMoqrDk3fDFs01gRspuKu7CbSZLSAqJDJZzlIK7RDgZNRSZVpVWuZhvWk 3PmDRxlWNWK1AY2p9Wrz3ZLPs9Hk6BqJFRGjueoarZZrgmmdak6nLblB94kO544NDYmFabNaqcr 4Cfoyb39tK5s2fbf1EfYKhQ8tH8VP8Bsu3v+VdLHEssd+ToHhUFXzRfH2nNIB5krP5ZFhMfzWn9 yUH7rOiQ18eXkR7GYztnD0SD9N6VXfJL4VozdqOkAHZiMlxabfTty+2vT/Y2oWdjw6G1iks/l5f rdZ+D0FA34pqXmFZhLGNEYJ9DJOiM8/xuXbbzaRxXBW33P2sO5Q== X-Received: by 2002:a05:600c:8211:b0:43b:c857:e9d7 with SMTP id 5b1f17b1804b1-454a36e495amr3357365e9.5.1751398320073; Tue, 01 Jul 2025 12:32:00 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG5TyN7r+4oBk64JocA+5QoglGL345dK2Fcu0b1IazgnSHOIgn7V2SOlRTU0EkUwtcUGQo9tg== X-Received: by 2002:a05:600c:8211:b0:43b:c857:e9d7 with SMTP id 5b1f17b1804b1-454a36e495amr3356625e9.5.1751398319493; Tue, 01 Jul 2025 12:31:59 -0700 (PDT) Received: from ?IPV6:2003:d8:2f18:7500:202e:b0f1:76d6:f9af? (p200300d82f187500202eb0f176d6f9af.dip0.t-ipconnect.de. [2003:d8:2f18:7500:202e:b0f1:76d6:f9af]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-453823ad01csm206159325e9.22.2025.07.01.12.31.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Jul 2025 12:31:59 -0700 (PDT) Message-ID: <48e9a5de-3131-4e36-8a21-5f77669116a9@redhat.com> Date: Tue, 1 Jul 2025 21:31:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 22/29] mm/page-flags: rename PAGE_MAPPING_MOVABLE to PAGE_MAPPING_ANON_KSM To: Lorenzo Stoakes Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, virtualization@lists.linux.dev, linux-fsdevel@vger.kernel.org, Andrew Morton , Jonathan Corbet , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Jerrin Shaji George , Arnd Bergmann , Greg Kroah-Hartman , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?UTF-8?Q?Eugenio_P=C3=A9rez?= , Alexander Viro , Christian Brauner , Jan Kara , Zi Yan , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , "Matthew Wilcox (Oracle)" , Minchan Kim , Sergey Senozhatsky , Brendan Jackman , Johannes Weiner , Jason Gunthorpe , John Hubbard , Peter Xu , Xu Xin , Chengming Zhou , Miaohe Lin , Naoya Horiguchi , Oscar Salvador , Rik van Riel , Harry Yoo , Qi Zheng , Shakeel Butt References: <20250630130011.330477-1-david@redhat.com> <20250630130011.330477-23-david@redhat.com> <5357d4d9-d817-4351-9927-bcd03794964c@lucifer.local> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <5357d4d9-d817-4351-9927-bcd03794964c@lucifer.local> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: JsDhfBn0qYx4sMGTVrOPE7qdw5dZjJRmfPWe-J3WnGg_1751398320 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: ae1cjg59ufdktzjxdcni64sg1sp8fon3 X-Rspamd-Queue-Id: E68C910000F X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1751398324-1585 X-HE-Meta: U2FsdGVkX180MPWC75pW9LqgEygH4rfg64FypKDiDmGaxCqCHLGdXIbQvd7IylcqK38cx7UKUErw8aom7svFc8Lspe8hXd2Er6Yf2IiBPEr3x0dIxTq9YphuXSNH+XfZu6OE7aqIBNYJzsCnC8zPq/0rGECz3dG1ihvkocXxncRrRyn90Hmes8UGGVfqAE4L3IEGBHVhwyXqmqY6X+QNSatH6o+R2p16mkqEgbBp818tvLv2JshDKlYWtFWckZl7HBvtiPDmXNM+QXOfi9yQYm43mcVwRXOFUq9Fd4eezDxNzvKdsv6Qiv7jOb11xzUZX5z/bucvApKJjaKkfWGALxtry+tp0pDqv1HlDCKT1fzhFGnai0ZN7sR8p0m0O5DSYf9Mf5+8UYqBQ4fHa5c461FsINKvEGgWJhvPMb/L0tax4VjGomJcvnTgWfHTmRRmdV404moJVxVIDsJ3BVuGW7oP9ijMimWFONFHVHuWL5HS3xdGVcL+6Mczv50L7aRVAKXtEdCFICXMR5jE78i1rhncPaFAsHlpIruq6pyZRaP0koh0PMy/bgzpXLgvcKVCHbJZG15NovzDeXtNUPzFWnv4nuG87tTQzobcNEW6KlNTYlfz2zpequvLcLkBvlmpOR8rJL5c7+Y/1/FY0tI3b1crBNfla8/Y+raJJSgAXTgzLA0SdCIKbKjk4wzDHuOTmxGctF4QVRsydnSgy+HGVgIpfhOZi5Vh3erjL22KHqJ+NP9GIbTjWW7pytWiZ5Asy8m2x0O/g/rta3qiBkpgJQZZ5xYb3cPA7xFz7eio4jAQgiwpVGTr7ddqH1pGvdgIq9IMXByZlq7GEJBgrI2wucURJml7rqMOD1M/ocxaa1RzLdG3+mXk7pvrRfXz04Ug+RFD0Pl0vud3BPHOoopQPIMhg1ZT5H2CAyJ+1CCkxcSgEIBaEWc1YVnBskHSpnugZSAAaK3Q/P1dzV3LaeE DH3N2oBJ iwD9qfCNBsrwQTd8mRXic2I80rlHEpZQw4dohniwLWpXjDp+wUhPIi9tHor06A5Ih3G0J9XBy8ZfyCcdJpS0xKK6wATIB/4qo7P7Oo1MeogU7LRhMzH1VSZSAQDBaGFrCfmrc/gPtU88Hgr1NJg13Vnw8LcOVi6d0wcsZEe3XYL6lJ2BOxqjEjWCv9SWzGQKddFJe X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 01.07.25 14:54, Lorenzo Stoakes wrote: > On Mon, Jun 30, 2025 at 03:00:03PM +0200, David Hildenbrand wrote: >> KSM is the only remaining user, let's rename the flag. While at it, >> adjust to remaining page -> folio in the doc. > > Hm I wonder if we could just ideally have this be a separate flag rather than a > bitwise combination, however I bet there's code that does somehow rely on this. Well, KSM folios are anon folios, so that must hold. Of course, now you could make folio_test_anon() test both bits, and have KSM folios only set a PAGE_MAPPING_KSM bit. That should be possible on top of this change, but not sure if that's really what we want. After all, KSM folios are special ANON folios. > > I know for sure there's code that has to do a folio_test_ksm() on something > folio_test_anon()'d because the latter isn't sufficient. > > But this is one for the future I guess :) Yes :) > > Nice: re change to folio, that is a nice cleanup based on fact you've now made > the per-page mapping op stuff not be part of this. > >> >> Reviewed-by: Zi Yan >> Signed-off-by: David Hildenbrand > > LGTM, so: > > Reviewed-by: Lorenzo Stoakes Thanks! -- Cheers, David / dhildenb