From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99017EB64DA for ; Sat, 8 Jul 2023 05:31:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 038678D0001; Sat, 8 Jul 2023 01:31:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F2AE96B0072; Sat, 8 Jul 2023 01:31:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DF2EE8D0001; Sat, 8 Jul 2023 01:31:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D07CB6B0071 for ; Sat, 8 Jul 2023 01:31:13 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 73BBF8010D for ; Sat, 8 Jul 2023 05:31:13 +0000 (UTC) X-FDA: 80987321226.19.847EC9C Received: from mout.web.de (mout.web.de [212.227.15.4]) by imf29.hostedemail.com (Postfix) with ESMTP id 4F1F912000E for ; Sat, 8 Jul 2023 05:31:11 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=web.de header.s=s29768273 header.b="kcp3J/Ia"; spf=pass (imf29.hostedemail.com: domain of Markus.Elfring@web.de designates 212.227.15.4 as permitted sender) smtp.mailfrom=Markus.Elfring@web.de; dmarc=pass (policy=none) header.from=web.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688794271; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IHSRFxzxDlbsOpoPW3gC/om8Z8uBk5J1S+y+Vi6k0E0=; b=h72igescg42y/jC+01yTS1fleALKJpCcNAsG7jqTFBxDs7DN+6mkdtev3Gb46rsSz/aUSd DsRLYIPuJ5GzLxY6VRmV0AqkYAmk8MYTWe+43I/7lOHk5PHjP/tGQZic27upqwEl254ULG WJeN6pTNYyvb85Aqvo1aSlxDrNT191o= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688794271; a=rsa-sha256; cv=none; b=68xsk/y/H6b9wuwbUlAnDNNZIqHC9fzqF+x/i6xfxsqQ4DPBQo9otZb1zU2VM2L2NPVVVJ h9/+Jw3pa0NATovVV/LN/KAfqCODvGyg8N7ZXkFGdl+n2owQwPC2sQ5sXqIAskbcoqquJq etlxiQbhnvBpnsCHlxpIsE02NoNFBXk= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=web.de header.s=s29768273 header.b="kcp3J/Ia"; spf=pass (imf29.hostedemail.com: domain of Markus.Elfring@web.de designates 212.227.15.4 as permitted sender) smtp.mailfrom=Markus.Elfring@web.de; dmarc=pass (policy=none) header.from=web.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1688794244; x=1689399044; i=markus.elfring@web.de; bh=m2c+sXm/XWlUgWza6AdBS5kg3EFSI/Bu/fYO5lB9sQ8=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=kcp3J/Iaz35zGaTlYTqP+urdjR03Irba5tRYB1c42IUtUawGM6cfmpBTXfLfhXlmn2EFjbL skzuqzJzZM6cVOCRkE5ROdydMKgbp4z0gp8lMV0YBv28fCYpLnsHaXPCMR0ZnMvvmZCsDU0iG zJCQ+iy0Sigp8Y9EcBA6Qu9vJFwmrHTPzfkLbGEr85daI5WCj/WEKV3Y7L0F9x0vs+AaJ7bJf iS8x3lbJtqIEmUndLwvI9K5fZbgla30hztOQoAbL6i8dvTMs481pJr9z2KidlswTgksk/xWws ISIoP6dPinCu6Nth8/ZSLR5P2twDgLGjDwr1ttFw7ts6KX+l121w== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from [192.168.178.21] ([94.31.90.83]) by smtp.web.de (mrweb005 [213.165.67.108]) with ESMTPSA (Nemesis) id 1MQ8Wa-1qdv8O1vIO-00MKuj; Sat, 08 Jul 2023 07:30:44 +0200 Message-ID: <48be2446-6f6b-4f32-8a4c-7eabd8485b7f@web.de> Date: Sat, 8 Jul 2023 07:30:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: mm: lock a vma before stack expansion To: Matthew Wilcox , Suren Baghdasaryan Cc: linux-mm@kvack.org, kernel-janitors@vger.kernel.org, kernel-team@android.com, Andrew Morton , LKML , Axel Rasmussen , David Hildenbrand , David Rientjes , Davidlohr Bueso , Greg Thelen , Hugh Dickins , Jann Horn , Jerome Glisse , Johannes Weiner , Laurent Dufour , "Liam R. Howlett" , Lorenzo Stoakes , Michal Hocko , Michel Lespinasse , Pasha Tatashin , Peter Xu , Punit Agrawal , Shakeel Butt , Vlastimil Babka References: <20230707043211.3682710-1-surenb@google.com> Content-Language: en-GB From: Markus Elfring In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:cJIsNwuBmxOXl/QMu0DMYCTxHhzml3+j271t9t+U1Abrlyps+6C guthVf4wvcQKygx5mfLilH5lUtX3umOaiEDV3uwuKIkD+LIGZQeX71Gr2vbPYp1R4Hs4ytQ 0q7Ir6bJu8x1QtZc5D7xmnYW8Fk2y94ZX19/BrRWj5CMFEiMLgOUR97XS4QWXb7DQ+MQxto pETqWwrWDONgpZsBUi0Kg== UI-OutboundReport: notjunk:1;M01:P0:47oCbJt2p08=;/8KBkdTu0hRNpcmLL9UMR3RwJoN Y+rV7RfsVeYYLV9yYzYyYAnUITdsJt4AINkXS7iuiKrLyhsZPdIyoJeHbEq4TuheRYoUEUeON aGhgdRc899XGOV7++47Qk6hFTxcD3GPldh87Vnx9nz9CPVyxbzEFd7ZOnAVKc2uMKloJugwDa XKxHarZUTHHdN7SrhCxCoxlKSvlcafbzSK3Wd7qlXDOYkIMwXU8sSbyv/ybmR5YQvCzhoPICh wiMWsIslm8+Dt+s9QKv9LtH1cbQTVxerhK+lDH21Td68FGALdAnagsl0fXwrVN5qZr8/3vSCm T3wYiTX4FWoWjI8+eIjvTmp/023qLUu/ydybdKabQEOcB9iG1IWXYF6pupcjR7BvVQNOuR2WM nq1dtNBbGBunRsyWX6ZR/JlXLljtikSLZ6F++14mdeMYU5OHIsz1eUr07Nck7IpsgfD2SuQS9 p3GuGEj15oRAJ0CzoGv5LYNrx7dsLfIZZ8yoo8mU5e5aboW0UNYcN3e/+Yy85NVOqgb1aOxDs AFp+B1EonIjl2ys4dUb9W4W79n3TLcYMF033AUJlNWQe/NM+OmusUGg7mKJeeEnFG1n9TAiTI QHCyJPgugsH//EL+OTM2dcykl+2PaJu/L+ogtrtqKSuaXnilGQc36Ynd0z+kDJ9F3aR7Ir8mK jIFuaZIxnInz7oD5v8Lj/RC1uFmZNgSFcw8JjxZcO6OSkooI10yMW1qF1IVWXA9VaDYBrTWV2 M0rjOyR3BD3srQcra1DbAZd9Un1d1ARfPURI2tt8eSxzfh8eLbmSg81eSrTP9TadhJBoTcbjE B4blT98UKk8hqkGwqzYts3QdNYhMcYDabUuS75O8+3ULu38N9bjkdz9RnzLOZL7bAeXiQZKGW LwGauUivHXFOaaSkz7HqYy/HZ3dg1ClKyzL8pH2mOHpSdVsojO8mZ4igOmulLj5iuy67suEqk qrwmtg== X-Rspamd-Queue-Id: 4F1F912000E X-Rspam-User: X-Stat-Signature: 7kxwxgx7zs5d1q8jw6ccmnsm5wrgtnnd X-Rspamd-Server: rspam03 X-HE-Tag: 1688794271-472927 X-HE-Meta: U2FsdGVkX1/518evuRk5uiV8VnBnKqt6gcX4tmotC1L1wQXrAayQRejY2DIaLe0FhS+eypXtcni2h7bxG1pgVruacesXWMlSHN1Ct4NTZ5IcjErMKKEkpGwhxUTF5xTX6nXDan2HTldGoOhfJ+Zrmm2HDhRQuyRqMDXlRPl/BkhsreSKoTcakLpvXlf6Vx6pU1ryPZHkGWRqlcreoDbp8VDljurEIE8EvV6l651KgdnEWkumdwnIMszjE21Hq4v4ya1kIbijtJXMuXKEHjdVCrYVIBHEbi9QKfbPflg29DKlWkzbtSKx1Y7DRjklZj4Hh5OxWWR7BhmiszUC19L/hTa8th/PlpkREIfDzpLnyBR39opxCnxjn9AAjR93UQVtwKNExuSBGnIZ5ZSAWoIzOSZtCf56EcfbIm0WACnwkiXASymSUFlWCOKljOBTr23or8em9mPK/PliIQ0nXFC3l7Sb5bpHwlOHm88sP8SUJyHg7gZl/esErKwhr6YKqPkncycL+Ro5FzlWqIBknN9gyJLQdLPY/5js2jNa80SlaSTIK9fwtzYEufs92iIbbrn0vkjxk+cZD9nS+tRkOMNI6vN1Nwzm5PaNoqkF4ZAioDYFiDLevnHFeLuBmzmuFxTL4gvdKZ/2IAzCTiYpSMuxCP1FuH5PbioJpK+SvMfsj9FbGptBfVF3yoTD03C/0U5ImQ2fAXvp5bqS/T1HGv3K+3Bjw9sdnv9j0nX19QT60gerbKw6ho/IEKcNITHdWUSkf/KuE/MInskCFny9mOFDoUFcAHMBpAwF/RPW+ugvI+o5zOAUqDn9EOQ7ItxTLCfsf3SKI8Nu+40Ounj8JHBL9CUpZXXcFZoq6/v2ZWeoie6E8bpvnQTsPN3yUU1aWCfCcuCzcCRW3LhbY3g4vOkdfEY1p0RL9KS71W1FYskZZoG7tGLRZ7y9qHiqXZuuTgv2ZOgK5SouziVPWTrjn5O JVkMn9v3 o7DJIn0P8f0P7m7dvwvZERQVzv2UwgVgFlLOdGMDl/e+KKXK+vn3gk1qyh+gI47eiNZQ8ZSDoaKQnl2NdZUWICwaqYCByDvQPKo9uq4LjNc2QZZLZQeVisGlSj92g0MvhcT+iFUrOJwdEHzmIqz4f0UJYgi2i4huhYYdYj0Se4ehM+YbqOD1zR3qNB7PaA4mFXF3pV0YOIhLQUaNo+tzt6LlW5okNjhnWo+h+iiFcKCSmDJZWt1zTNN3YG0UR42A7ABQg3DIex2JnqTI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: >> =E2=80=A6 >>> write-locked to prevent page faults into the VMA being expanded. Add >>> the necessary locking. >> >> 1. Would it a bit nicer to put the second sentence on a separate line >> in such a change description? >> >> 2. I noticed that you put the address =E2=80=9Cstable@vger.kernel.org= =E2=80=9D >> into the message field =E2=80=9CCc=E2=80=9D. >> Would you like to specify such a hint as a tag? >> >> See also: >> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/t= ree/Documentation/process/submitting-patches.rst?h=3Dv6.4#n264 >> >> 3. How do you think about to add the tag =E2=80=9CFixes=E2=80=9D? >> >> 4. Will a cover letter become helpful also for the presented small patc= h series? > > Markus, your nitpicking is not useful. =E2=80=A6 Do you like patch reviews more by other contributors? Regards, Markus