From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7883C3ABB0 for ; Mon, 5 May 2025 09:51:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1A1176B0088; Mon, 5 May 2025 05:51:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 152B66B0089; Mon, 5 May 2025 05:51:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F0BD66B008A; Mon, 5 May 2025 05:51:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id D06036B0088 for ; Mon, 5 May 2025 05:51:51 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 7C127160169 for ; Mon, 5 May 2025 09:51:52 +0000 (UTC) X-FDA: 83408387664.21.D8A476C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf21.hostedemail.com (Postfix) with ESMTP id 8690B1C0005 for ; Mon, 5 May 2025 09:51:48 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=LSOPijaO; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746438708; a=rsa-sha256; cv=none; b=0QhLwhWyyKV69oCDyL1XxqFd/dDiaWghGY/znbGITtZ7k3FI5vxxKJpO6S4je741nvOqVT A+xvZCku8owB3vrJfSki/R7oiCMVwVNm9X3hucFvGv1K8SXtzciQnRY6biCDRyn8q40IIJ mPHTrlghsR28oKVWT6lbMpkgMIoWS+8= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=LSOPijaO; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746438708; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ewS6Vik8l5cRJ8KrBPd45Zc0hKMID54cVJfZTT1QyCc=; b=c7jbyLDVH0J4dWP1IzsCvyJJEPBPNLr1RlvjLuPlufxCs2ceUUPLCV+vKAehEV8+YURAen CKwDd6MMZczsy20+Hi/udLcd0nh4CAcbSUUzaYQfPB4AaV+mr+376msumA6dGhzGfvpm7t c/wfO9hqlcbfKskeUrJuNxzp7IHOTvk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1746438707; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ewS6Vik8l5cRJ8KrBPd45Zc0hKMID54cVJfZTT1QyCc=; b=LSOPijaOmrfz5oAX7g3ph9dE24EE3JB4okdzAk5pUNfIYfYfEnFBTpKvX+Z+OK0VXIDAsc wL800kbjqR+/8m/HcPnnN45LdHSCzhIBbYVJkLvb6YsbntCIRL06cbk11xWDo9v8f8NxSd 4nhb9JWDH4ulq4guJKuIh5drJI8Ww2U= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-625-K-uSMrBMN2uD3pK50vRXbg-1; Mon, 05 May 2025 05:51:46 -0400 X-MC-Unique: K-uSMrBMN2uD3pK50vRXbg-1 X-Mimecast-MFC-AGG-ID: K-uSMrBMN2uD3pK50vRXbg_1746438705 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-39135d31ca4so1648013f8f.1 for ; Mon, 05 May 2025 02:51:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746438705; x=1747043505; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=ewS6Vik8l5cRJ8KrBPd45Zc0hKMID54cVJfZTT1QyCc=; b=bOMbunP2h9cAb8v4Npzge04O98SfZBNkiyh5nwsVmgZ2C6Jy9s+ukc+kdtrIWVBKOl DshdnKR26itmUkvVZA8B6Eak0QWVgyMAksjXUtX/8dgxGJ9wAazVd9NBR+Go9xSmQGDE 4SKriMlGdv4CWLsfBIRBt6p79/YxnRevpLjXRv9yRPcz9/Taj3XkAzFCX0371XRdUvK1 FTk0GJTU46Iu89PUCeoL1yqvDqbx6l2XWYSRZKEcZNZxoS6L6G8SGDdhjhgy354HE/Dc jKQ+ITPMTjYS70MCq3zIVjoshTDDYr7tyS8nl78GkG0iuinUgaD0relXtwuBwqStXqX5 HZgw== X-Forwarded-Encrypted: i=1; AJvYcCUlYSArjXhwQIjxnYwoWLAQpyCGA3VUppX/O91u0nZ5ZrcCQVxs8/NK+ioJQW9ke5k06N7aXRsO1w==@kvack.org X-Gm-Message-State: AOJu0YzyNChhn0cmB6XfqOhbKbKAORiAv+l2AtD7JJ7wpbPE1f+r8eBz OhOm6W1ixyZOWI7+lNCU1k3fRCqDmG/8cQTluS2vOQwyZ8RqdMpsQF1LyX6Plvnli4e84T7EsmI +/+ZWGuvEtVNbjkOCbGynHtyyNgcz/3tGU/+Fbcn3DNU1UFs4 X-Gm-Gg: ASbGncuoY/q1KM3FQ3GkJqWGJXMoMTGHmBcM2wnLx4wlH6lnQlNtFSQNRdyXCLVV7Ul 8ytQW6YPi4ovfXc9vsRaHwpvsD3stfgNxmlnie71Ff1Lu/2csjtzt89vHw3b+ZsSQFm0IIgcY0Z aSkip/Z1So7aDZpkQ3nna/9J/rGJ7uuTo4x8eEZWC1t9KiKWWHxSBSGF7l0rPD9pz4cFf36CjwZ SaGhKsokTzEZAlICLTbFWwO4xWXASMvu/lUQvPhl3KPrYDnW1keeUN8hhE+JN3S8BRrN1mYHPXG xr5VXhyIrs3ZyvmGWFwLV9EaLGnPHA4vIAKx7squUE5yBci2xaAgWNU6+0dlMd3ZYEaOp8Bmwji 5lfCUKZkszSrMJzAKws7ssRKEbQtq55Ntl348LEA= X-Received: by 2002:a5d:64ef:0:b0:3a0:6a86:9477 with SMTP id ffacd0b85a97d-3a097a3e8a9mr8921392f8f.0.1746438705517; Mon, 05 May 2025 02:51:45 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGQIr0akqqVpSfJA+WqHy/RkGIsb/kMplUD1UgGlE7QwSA+HczFWZoFmADtXqSrBLR7+KQVbw== X-Received: by 2002:a5d:64ef:0:b0:3a0:6a86:9477 with SMTP id ffacd0b85a97d-3a097a3e8a9mr8921367f8f.0.1746438705146; Mon, 05 May 2025 02:51:45 -0700 (PDT) Received: from ?IPV6:2003:cb:c73d:2400:3be1:a856:724c:fd29? (p200300cbc73d24003be1a856724cfd29.dip0.t-ipconnect.de. [2003:cb:c73d:2400:3be1:a856:724c:fd29]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a099b1702dsm9703021f8f.88.2025.05.05.02.51.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 May 2025 02:51:44 -0700 (PDT) Message-ID: <48b4aa79-943b-46bc-ac24-604fdf998566@redhat.com> Date: Mon, 5 May 2025 11:51:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v4 1/5] mm/readahead: Honour new_order in page_cache_ra_order() To: Ryan Roberts , Andrew Morton , "Matthew Wilcox (Oracle)" , Alexander Viro , Christian Brauner , Jan Kara , Dave Chinner , Catalin Marinas , Will Deacon , Kalesh Singh , Zi Yan Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org References: <20250430145920.3748738-1-ryan.roberts@arm.com> <20250430145920.3748738-2-ryan.roberts@arm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250430145920.3748738-2-ryan.roberts@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: V4PDiJx1NaPMHLFxmbpg3TJJJ27d32m1uH9wxfkPmWc_1746438705 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 8690B1C0005 X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: 7gfg91h79ukafrfq7n9uda3hkw9cewp1 X-HE-Tag: 1746438708-957273 X-HE-Meta: U2FsdGVkX1+dnohTNfVe+B0wjPOHZmDyrmrzpGk7dE1KYBqpJCoWa5VBq9KasHokYQcKnTgCtxAg+AM5wQuZ7MVcxRzyZ7pH4R3OrYpiM/Mo7k/AgWsJ0ZhzTpBAJNu22aVTIY1Z2MO5wBH8HlMxGEgy+aAptDO7ommN0Zz0yi+FINso4/PZoTUqwXW7c4nuzWJt3SGL9k4Ug30hGDWiRdhBxjsV9hOeLvCyTdgLgoFG9Ofr98E1lG9k+m3bBKmyPO9jgLT/MiKklqTPkp0Gn/yZpmOW4PTALppEAHkCcjpqVKl6BvagdY1qCfzlnbn598C8sKlvabwG34oxHkB/8dyvoBypCnnHqf3CcFuiHValhw3L+Wct1yaCcyKS7hRpGfbbwNTadhf3TYre7nJ8hmcYv/hYciPk+n8MeKwRieMZ38otmu5MyH6ccEsSZ8w7VhBqMNbXIc+P7YESikeYD11R8zgB1+SSVwepT5onz/qhlRVdUP2Al87iPEaViE9Nn6x5c7+Rx1akV8JM/CA4KMo4nphynkbQ6MZiE0AVOzvWU+W+3GZ+ovmC65+vPgCpHMpQuwzeYNRqdw9O/vz9H21D0Ehc138LwGKxTzJZWr5stwmeAKtIVxbUXNa0sDHv/brBDBFW9HoSMhQdZ0MRpQPEieQTZ2uJdDYlmgNsvyS97NdnOJpIxlriwLooAqWFTgkImi6aMClnRg8N4CAgrp1p1sjj3Uq1njHOzs3itOM82z05KtwtvhHiB/Vob90jUNJqqDM3YqhR+IfO4N8zH5ykQQ6Y7rEgdX6YAYP49+IaolJSbNJUgSJ0rLJsF9mM4rncXxeNIorwBumSpruUhA0shZFWi4XG3VfmvsOSuGTox4nuzmGUkexlMwmp2N+cVYytjpBqJRqS5DQVAyfBKmXpXKZQR+Yf6Q2mWtWz4aaPDgmNYj/hIdLBMy1i8SilrscVfpAcm0J/Qv2vSVU R+QxLU/U PjJX2JJygBOyMomf1f/peOYBivnQ5Q3dI6/he6hAJ+9YDnHzIgUETT5ZfvHpDX/w+cc6Ci19aWYguSh5w+uPNNjgzuFeyCmroq8TSkPHICdZhcIFE0i511FUhbgEnMMxGGHwlN/hWIF1We53/bhT1lMDyZzb6nTDKWXsdCyzOdYdM1AWkzB/idMMs28+oHuK/G+GBR8vO6kfM8K9eiZYzArkMAZa+MCBZvlfCbACUh1N1oT+FNYwPzkJ94XSRT50l9j9D5VGn6rIA8MtUIVXMenIHlZp57HIbGwm/W+bfbJxhlJ84slOeMTlSLpkw/iSrcIZJPd993RIA23bgHQlyl1IFF66OUNYikkFgnM5k68TqK1DF4/HmGj1RxzCh+HT/n3VN5Vrlolr7uMdM0qOcHPhQMmNyJNIA8gsnBLDzY1foM0NHLpLUj58lY2c1bZHwCHPKLNQF36RFaV9cxfPTjlzYeqazcGOhmi/GZAvwPI//q5aXBvA395MsfsBwhd1IhzoZwsptuEx+3K0eqZB5zMak2VSd08cCUDYu X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 30.04.25 16:59, Ryan Roberts wrote: > page_cache_ra_order() takes a parameter called new_order, which is > intended to express the preferred order of the folios that will be > allocated for the readahead operation. Most callers indeed call this > with their preferred new order. But page_cache_async_ra() calls it with > the preferred order of the previous readahead request (actually the > order of the folio that had the readahead marker, which may be smaller > when alignment comes into play). > > And despite the parameter name, page_cache_ra_order() always treats it > at the old order, adding 2 to it on entry. As a result, a cold readahead > always starts with order-2 folios. > > Let's fix this behaviour by always passing in the *new* order. > > Worked example: > > Prior to the change, mmaping an 8MB file and touching each page > sequentially, resulted in the following, where we start with order-2 > folios for the first 128K then ramp up to order-4 for the next 128K, > then get clamped to order-5 for the rest of the file because pa_pages is > limited to 128K: > > TYPE STARTOFFS ENDOFFS SIZE STARTPG ENDPG NRPG ORDER > ----- ---------- ---------- --------- ------- ------- ----- ----- > FOLIO 0x00000000 0x00004000 16384 0 4 4 2 > FOLIO 0x00004000 0x00008000 16384 4 8 4 2 > FOLIO 0x00008000 0x0000c000 16384 8 12 4 2 > FOLIO 0x0000c000 0x00010000 16384 12 16 4 2 > FOLIO 0x00010000 0x00014000 16384 16 20 4 2 > FOLIO 0x00014000 0x00018000 16384 20 24 4 2 > FOLIO 0x00018000 0x0001c000 16384 24 28 4 2 > FOLIO 0x0001c000 0x00020000 16384 28 32 4 2 > FOLIO 0x00020000 0x00030000 65536 32 48 16 4 > FOLIO 0x00030000 0x00040000 65536 48 64 16 4 > FOLIO 0x00040000 0x00060000 131072 64 96 32 5 > FOLIO 0x00060000 0x00080000 131072 96 128 32 5 > FOLIO 0x00080000 0x000a0000 131072 128 160 32 5 > FOLIO 0x000a0000 0x000c0000 131072 160 192 32 5 Interesting, I would have thought we'd ramp up earlier. > ... > > After the change, the same operation results in the first 128K being > order-0, then we start ramping up to order-2, -4, and finally get > clamped at order-5: > > TYPE STARTOFFS ENDOFFS SIZE STARTPG ENDPG NRPG ORDER > ----- ---------- ---------- --------- ------- ------- ----- ----- > FOLIO 0x00000000 0x00001000 4096 0 1 1 0 > FOLIO 0x00001000 0x00002000 4096 1 2 1 0 > FOLIO 0x00002000 0x00003000 4096 2 3 1 0 > FOLIO 0x00003000 0x00004000 4096 3 4 1 0 > FOLIO 0x00004000 0x00005000 4096 4 5 1 0 > FOLIO 0x00005000 0x00006000 4096 5 6 1 0 > FOLIO 0x00006000 0x00007000 4096 6 7 1 0 > FOLIO 0x00007000 0x00008000 4096 7 8 1 0 > FOLIO 0x00008000 0x00009000 4096 8 9 1 0 > FOLIO 0x00009000 0x0000a000 4096 9 10 1 0 > FOLIO 0x0000a000 0x0000b000 4096 10 11 1 0 > FOLIO 0x0000b000 0x0000c000 4096 11 12 1 0 > FOLIO 0x0000c000 0x0000d000 4096 12 13 1 0 > FOLIO 0x0000d000 0x0000e000 4096 13 14 1 0 > FOLIO 0x0000e000 0x0000f000 4096 14 15 1 0 > FOLIO 0x0000f000 0x00010000 4096 15 16 1 0 > FOLIO 0x00010000 0x00011000 4096 16 17 1 0 > FOLIO 0x00011000 0x00012000 4096 17 18 1 0 > FOLIO 0x00012000 0x00013000 4096 18 19 1 0 > FOLIO 0x00013000 0x00014000 4096 19 20 1 0 > FOLIO 0x00014000 0x00015000 4096 20 21 1 0 > FOLIO 0x00015000 0x00016000 4096 21 22 1 0 > FOLIO 0x00016000 0x00017000 4096 22 23 1 0 > FOLIO 0x00017000 0x00018000 4096 23 24 1 0 > FOLIO 0x00018000 0x00019000 4096 24 25 1 0 > FOLIO 0x00019000 0x0001a000 4096 25 26 1 0 > FOLIO 0x0001a000 0x0001b000 4096 26 27 1 0 > FOLIO 0x0001b000 0x0001c000 4096 27 28 1 0 > FOLIO 0x0001c000 0x0001d000 4096 28 29 1 0 > FOLIO 0x0001d000 0x0001e000 4096 29 30 1 0 > FOLIO 0x0001e000 0x0001f000 4096 30 31 1 0 > FOLIO 0x0001f000 0x00020000 4096 31 32 1 0 > FOLIO 0x00020000 0x00024000 16384 32 36 4 2 > FOLIO 0x00024000 0x00028000 16384 36 40 4 2 > FOLIO 0x00028000 0x0002c000 16384 40 44 4 2 > FOLIO 0x0002c000 0x00030000 16384 44 48 4 2 > FOLIO 0x00030000 0x00034000 16384 48 52 4 2 > FOLIO 0x00034000 0x00038000 16384 52 56 4 2 > FOLIO 0x00038000 0x0003c000 16384 56 60 4 2 > FOLIO 0x0003c000 0x00040000 16384 60 64 4 2 > FOLIO 0x00040000 0x00050000 65536 64 80 16 4 > FOLIO 0x00050000 0x00060000 65536 80 96 16 4 > FOLIO 0x00060000 0x00080000 131072 96 128 32 5 > FOLIO 0x00080000 0x000a0000 131072 128 160 32 5 > FOLIO 0x000a0000 0x000c0000 131072 160 192 32 5 > FOLIO 0x000c0000 0x000e0000 131072 192 224 32 5 Similar here, do you know why we don't ramp up earlier. Allocating that many order-0 + order-2 pages looks a bit suboptimal to me for a sequential read. I wonder if you're change will have a measurable downside on sequential read. Anyhow, I think it was already not behaving how I would have expected it ... :) Acked-by: David Hildenbrand > ... > > Signed-off-by: Ryan Roberts > --- > mm/readahead.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/mm/readahead.c b/mm/readahead.c > index 6a4e96b69702..8bb316f5a842 100644 > --- a/mm/readahead.c > +++ b/mm/readahead.c > @@ -479,9 +479,6 @@ void page_cache_ra_order(struct readahead_control *ractl, > > limit = min(limit, index + ra->size - 1); > > - if (new_order < mapping_max_folio_order(mapping)) > - new_order += 2; > - > new_order = min(mapping_max_folio_order(mapping), new_order); > new_order = min_t(unsigned int, new_order, ilog2(ra->size)); > new_order = max(new_order, min_order); > @@ -683,6 +680,7 @@ void page_cache_async_ra(struct readahead_control *ractl, > ra->size = get_next_ra_size(ra, max_pages); > ra->async_size = ra->size; > readit: > + order += 2; > ractl->_index = ra->start; > page_cache_ra_order(ractl, ra, order); > } -- Cheers, David / dhildenb