From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 740A3C433F5 for ; Thu, 6 Jan 2022 17:26:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7C6536B0071; Thu, 6 Jan 2022 12:26:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 776506B0072; Thu, 6 Jan 2022 12:26:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 63D716B0073; Thu, 6 Jan 2022 12:26:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0239.hostedemail.com [216.40.44.239]) by kanga.kvack.org (Postfix) with ESMTP id 555066B0071 for ; Thu, 6 Jan 2022 12:26:09 -0500 (EST) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id ED82095AF0 for ; Thu, 6 Jan 2022 17:26:08 +0000 (UTC) X-FDA: 79000540416.24.527FD0B Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf11.hostedemail.com (Postfix) with ESMTP id F1E9C40007 for ; Thu, 6 Jan 2022 17:26:03 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id D33EE1F385; Thu, 6 Jan 2022 17:26:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1641489966; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uVaSzjfZpGkaAuEVEGES2CPozXp4YrFzHRLqYAww+cc=; b=LQfncRqUZRR4Xwo70xszyNk3wFg7OU/+dPATxQI+mczxd8AXyqAFbV7q0Np2ZqktrXK78/ ImKEgvUANvS7V3l+fTBYcv30o18a5XXUtlJdLZHVWZVTsvMdCNkDHpD1kNSoFRJ/u+HX74 Ah6RoS2RHezJwYksNgsP1X5E6N5D7zw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1641489966; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uVaSzjfZpGkaAuEVEGES2CPozXp4YrFzHRLqYAww+cc=; b=/ln33fgAMgSrJrXtAAEqLC1FJ4PYIJOCqFTGgXjYk2GPPQOuCbEc+vzGkIO3fzSIcici09 wSslaw8yzWM6EdBA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A585513C61; Thu, 6 Jan 2022 17:26:06 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id oYGvJy4m12GAJQAAMHmgww (envelope-from ); Thu, 06 Jan 2022 17:26:06 +0000 Message-ID: <48ab4217-a0c4-19ba-2335-1154086a562d@suse.cz> Date: Thu, 6 Jan 2022 18:26:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.1 Subject: Re: [PATCH v4 07/32] mm: Convert __ksize() to struct slab Content-Language: en-US To: Hyeonggon Yoo <42.hyeyoo@gmail.com> Cc: Matthew Wilcox , Christoph Lameter , David Rientjes , Joonsoo Kim , Pekka Enberg , linux-mm@kvack.org, Andrew Morton , Johannes Weiner , Roman Gushchin , patches@lists.linux.dev References: <20220104001046.12263-1-vbabka@suse.cz> <20220104001046.12263-8-vbabka@suse.cz> From: Vlastimil Babka In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=LQfncRqU; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="/ln33fgA"; dmarc=none; spf=pass (imf11.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: F1E9C40007 X-Stat-Signature: 7dcft3ipww1rtgqd3qfd9b1idwnwkiei X-HE-Tag: 1641489963-864402 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 1/6/22 14:42, Hyeonggon Yoo wrote: > On Tue, Jan 04, 2022 at 01:10:21AM +0100, Vlastimil Babka wrote: > > This patch Looks good. > Reviewed-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> Thanks! > BTW, I see no reason to implement SLAB version of __ksize separately. > And there are no modules that use __ksize. EXPORT_SYMBOL is unnecessary. OK, I'll look at a cleanup later. Or you can try? > BTW, Until when can I review your patches? until next week before starting > window? I will send it tomorrow already, so records of any further review will be archived in the mailing list only, but not git. Thanks again! > Thanks! > >> -- >> 2.34.1 >>