From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9E99C433F5 for ; Wed, 1 Jun 2022 10:49:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 776F08D0008; Wed, 1 Jun 2022 06:49:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 725C68D0006; Wed, 1 Jun 2022 06:49:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 638098D0008; Wed, 1 Jun 2022 06:49:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 525728D0006 for ; Wed, 1 Jun 2022 06:49:34 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 2D52F349D4 for ; Wed, 1 Jun 2022 10:49:34 +0000 (UTC) X-FDA: 79529345868.17.FF227FE Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf31.hostedemail.com (Postfix) with ESMTP id BA38C20074 for ; Wed, 1 Jun 2022 10:48:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1654080573; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DS4blGTPG/TNOCJCMaY+3+JCDXOQcHN0U1VXQhbGGI4=; b=OVW5GC3Q2fbman5xaKLPO1xCoh1UaDBTjmQKSuENQAIK3/dgxy80MzbyIXJJuzEwb2XFcI Se5r7k2VQaUOdwwpqYg2HE2g4E87kXrIW7x1YnLHFm64MRp08N/3GZNJrxNxx/gLzAYxs3 GGgRhbiMN4n70buN5qKUq9GNl5g8mhY= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-117-LCv2Kuu6P4SqRXmzhcpFUg-1; Wed, 01 Jun 2022 06:49:32 -0400 X-MC-Unique: LCv2Kuu6P4SqRXmzhcpFUg-1 Received: by mail-wr1-f71.google.com with SMTP id v4-20020adfebc4000000b002102c69be5eso222627wrn.13 for ; Wed, 01 Jun 2022 03:49:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=DS4blGTPG/TNOCJCMaY+3+JCDXOQcHN0U1VXQhbGGI4=; b=SirGQjh+tfiW3R5xpCVjguCIgv87RPbjOd8yImQdrAcENeAIRtEkzCbYL7I50hQMDK a8F9FgK/LIDtYet/i30vJ6OMfqQOAgcNAdZGs+P6nG2h1PDpJy19/bWAL9K2LQsoSyUn hAcaVoisWbioqdO3XK8y7NC7JInbmOUTCdblIPqIxrZGzzXgRQqQjS2MS1MCDl5BiUYr IuBr35aWsMNVR+ibGJWRf1dz4ApsJrYc5+gsQF/jjRNDGEvOu55iAu0rxxhBxmJ+Ls7j m69Lb7zfk+mhrVbkpp8LcOEo9SFoLMln5dmBbMsJoB9CosGRw0AuHCk4RvegoBsI6Dkj FnKg== X-Gm-Message-State: AOAM530PCcVkcCLRGpIreF9l6S4DL/XdRKea6Yy33sMsGF4aOlPGwLeo pxYG6uZ1zV4o7XCUuNTCKDO7c6Ia9YrlXW/QzNVD5vfBnXpZqwja49E6NqF8DXX3B3TXvnmMCFT +k2gZpruJn8k= X-Received: by 2002:adf:e10d:0:b0:20c:dc8f:e5a5 with SMTP id t13-20020adfe10d000000b0020cdc8fe5a5mr54387148wrz.265.1654080571196; Wed, 01 Jun 2022 03:49:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyNLblXQZWWG8YKRi1MWxDnwphi/PU6+MtD9BcohLoaFlU7Cvuccdym8QdqGZaoL9UVqtd5rQ== X-Received: by 2002:adf:e10d:0:b0:20c:dc8f:e5a5 with SMTP id t13-20020adfe10d000000b0020cdc8fe5a5mr54387131wrz.265.1654080570899; Wed, 01 Jun 2022 03:49:30 -0700 (PDT) Received: from ?IPV6:2003:cb:c705:2600:951d:63df:c091:3b45? (p200300cbc7052600951d63dfc0913b45.dip0.t-ipconnect.de. [2003:cb:c705:2600:951d:63df:c091:3b45]) by smtp.gmail.com with ESMTPSA id y18-20020a05600c365200b003942a244f54sm5775095wmq.45.2022.06.01.03.49.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Jun 2022 03:49:29 -0700 (PDT) Message-ID: <48a4a7f2-bee5-371a-1d9d-549fc59ce4f4@redhat.com> Date: Wed, 1 Jun 2022 12:49:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH 1/3] mm: hugetlb_vmemmap: cleanup hugetlb_vmemmap related functions To: Muchun Song , mike.kravetz@oracle.com Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, smuchun@bytedance.com References: <20220404074652.68024-1-songmuchun@bytedance.com> <20220404074652.68024-2-songmuchun@bytedance.com> <087817e3-98ce-09f6-9ae9-68e544f43775@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Authentication-Results: imf31.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OVW5GC3Q; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf31.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=david@redhat.com X-Stat-Signature: q5uey8guui8168p6ez64hs6smy5z89fg X-Rspam-User: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: BA38C20074 X-HE-Tag: 1654080532-899567 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: >>> #endif >>> #ifdef CONFIG_CGROUP_HUGETLB >>> /* cgroup control files */ >>> diff --git a/mm/hugetlb.c b/mm/hugetlb.c >>> index dd642cfc538b..1f9fbdddc86b 100644 >>> --- a/mm/hugetlb.c >>> +++ b/mm/hugetlb.c >>> @@ -1540,7 +1540,7 @@ static void __update_and_free_page(struct hstate *h, struct page *page) >>> if (hstate_is_gigantic(h) && !gigantic_page_runtime_supported()) >>> return; >>> >>> - if (alloc_huge_page_vmemmap(h, page)) { >>> + if (hugetlb_vmemmap_alloc(h, page)) { >>> spin_lock_irq(&hugetlb_lock); >>> /* >>> * If we cannot allocate vmemmap pages, just refuse to free the >>> @@ -1617,7 +1617,7 @@ static DECLARE_WORK(free_hpage_work, free_hpage_workfn); >>> >>> static inline void flush_free_hpage_work(struct hstate *h) >>> { >>> - if (free_vmemmap_pages_per_hpage(h)) >>> + if (hugetlb_optimize_vmemmap_pages(h)) >> >> It might be reasonable to call that hugetlb_should_optimize_vmemmap() >> then, letting it return a bool. >> > > How about the name of "hugetlb_vmemmap_optimizable()"? "should" seems to > tell the user that this hugetlb should be optimized, however, optimization > also depends on "hugetlb_free_vmemmap=on". "optimizable" seems to be more > appropriate, right? No strong opinion. Either is clearer to me compared to what we have right now :) -- Thanks, David / dhildenb