From: Vlastimil Babka <vbabka@suse.cz>
To: osalvador@techadventures.net, akpm@linux-foundation.org
Cc: mhocko@suse.com, sfr@canb.auug.org.au, rientjes@google.com,
pasha.tatashin@oracle.com, kemi.wang@intel.com,
jia.he@hxt-semitech.com, ptesarik@suse.com,
aryabinin@virtuozzo.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, dan.j.williams@intel.com,
Oscar Salvador <osalvador@suse.de>
Subject: Re: [PATCH] mm: Remove zone_id() and make use of zone_idx() in is_dev_zone()
Date: Mon, 30 Jul 2018 16:07:59 +0200 [thread overview]
Message-ID: <48a3c91d-14cd-ec1a-dd9f-952cc5e3d5f7@suse.cz> (raw)
In-Reply-To: <20180730133718.28683-1-osalvador@techadventures.net>
On 07/30/2018 03:37 PM, osalvador@techadventures.net wrote:
> From: Oscar Salvador <osalvador@suse.de>
>
> is_dev_zone() is using zone_id() to check if the zone is ZONE_DEVICE.
> zone_id() looks pretty much the same as zone_idx(), and while the use of
> zone_idx() is quite spread in the kernel, zone_id() is only being
> used by is_dev_zone().
>
> This patch removes zone_id() and makes is_dev_zone() use zone_idx()
> to check the zone, so we do not have two things with the same
> functionality around.
>
> Signed-off-by: Oscar Salvador <osalvador@suse.de>
Agreed.
Acked-by: Vlastimil Babka <vbabka@suse.cz>
next prev parent reply other threads:[~2018-07-30 14:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-30 13:37 osalvador
2018-07-30 14:00 ` Michal Hocko
2018-07-30 14:07 ` Vlastimil Babka [this message]
2018-07-30 14:10 ` Pavel Tatashin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48a3c91d-14cd-ec1a-dd9f-952cc5e3d5f7@suse.cz \
--to=vbabka@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=aryabinin@virtuozzo.com \
--cc=dan.j.williams@intel.com \
--cc=jia.he@hxt-semitech.com \
--cc=kemi.wang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=osalvador@suse.de \
--cc=osalvador@techadventures.net \
--cc=pasha.tatashin@oracle.com \
--cc=ptesarik@suse.com \
--cc=rientjes@google.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox