From: Rik van Riel <riel@redhat.com>
To: Nick Piggin <nickpiggin@yahoo.com.au>
Cc: Johannes Weiner <hannes@saeurebad.de>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org
Subject: Re: mm-more-likely-reclaim-madv_sequential-mappings.patch
Date: Sat, 18 Oct 2008 22:43:38 -0400 [thread overview]
Message-ID: <48FA9EDA.4030802@redhat.com> (raw)
In-Reply-To: <200810191321.25490.nickpiggin@yahoo.com.au>
Nick Piggin wrote:
>
> That's just handwaving. The patch still clears PG_referenced, which
> is a shared resource, and it is wrong, conceptually. You can't argue
> with that.
>
>
I don't see an easy way around that. If the PG_referenced bit is
set and the page is mapped, the code in vmscan.c will move the
page to the active list.
Even if the one pte mapping the page is in an MADV_SEQUENTIAL
VMA, in which case we definately do not want to activate the page.
Of course, if the PG_referenced came from a different access, things
would be a different matter.
Fixing the page fault code so that it does not set the PG_referenced bit
would take care of that.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-10-19 2:43 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-15 23:22 mm-more-likely-reclaim-madv_sequential-mappings.patch Andrew Morton
2008-10-16 1:30 ` mm-more-likely-reclaim-madv_sequential-mappings.patch KOSAKI Motohiro
2008-10-16 6:01 ` mm-more-likely-reclaim-madv_sequential-mappings.patch KOSAKI Motohiro
2008-10-16 6:06 ` mm-more-likely-reclaim-madv_sequential-mappings.patch Andrew Morton
2008-10-16 6:22 ` mm-more-likely-reclaim-madv_sequential-mappings.patch KOSAKI Motohiro
2008-10-16 6:31 ` mm-more-likely-reclaim-madv_sequential-mappings.patch Andrew Morton
2008-10-16 6:38 ` mm-more-likely-reclaim-madv_sequential-mappings.patch KOSAKI Motohiro
2008-10-16 8:07 ` mm-more-likely-reclaim-madv_sequential-mappings.patch KOSAKI Motohiro
2008-10-16 6:09 ` mm-more-likely-reclaim-madv_sequential-mappings.patch KOSAKI Motohiro
2008-10-16 13:43 ` mm-more-likely-reclaim-madv_sequential-mappings.patch Nick Piggin
2008-10-16 17:04 ` mm-more-likely-reclaim-madv_sequential-mappings.patch Rik van Riel
2008-10-17 2:21 ` mm-more-likely-reclaim-madv_sequential-mappings.patch Nick Piggin
2008-10-17 5:37 ` mm-more-likely-reclaim-madv_sequential-mappings.patch KOSAKI Motohiro
2008-10-17 5:56 ` mm-more-likely-reclaim-madv_sequential-mappings.patch Nick Piggin
2008-10-17 16:51 ` mm-more-likely-reclaim-madv_sequential-mappings.patch Johannes Weiner
2008-10-18 1:30 ` mm-more-likely-reclaim-madv_sequential-mappings.patch Nick Piggin
2008-10-18 10:45 ` mm-more-likely-reclaim-madv_sequential-mappings.patch Johannes Weiner
2008-10-19 2:21 ` mm-more-likely-reclaim-madv_sequential-mappings.patch Nick Piggin
2008-10-19 2:43 ` Rik van Riel [this message]
2008-10-19 2:58 ` mm-more-likely-reclaim-madv_sequential-mappings.patch Nick Piggin
2008-10-19 14:39 ` mm-more-likely-reclaim-madv_sequential-mappings.patch Johannes Weiner
2008-10-21 1:45 ` mm-more-likely-reclaim-madv_sequential-mappings.patch Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48FA9EDA.4030802@redhat.com \
--to=riel@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@saeurebad.de \
--cc=linux-mm@kvack.org \
--cc=nickpiggin@yahoo.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox