From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <48F79B42.3070106@linux-foundation.org> Date: Thu, 16 Oct 2008 14:51:30 -0500 From: Christoph Lameter MIME-Version: 1.0 Subject: Re: [PATCH 4/5] mm: rework do_pages_move() to work on page_sized chunks References: <48F3AD47.1050301@inria.fr> <48F3AE1D.3060208@inria.fr> In-Reply-To: <48F3AE1D.3060208@inria.fr> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Brice Goglin Cc: LKML , linux-mm@kvack.org, Andrew Morton , Nathalie Furmento List-ID: Brice Goglin wrote: > + err = -ENOMEM; > + pm = kmalloc(PAGE_SIZE, GFP_KERNEL); > + if (!pm) ok.... But if you need a page sized chunk then you can also do get_zeroed_page(GFP_KERNEL). Why bother the slab allocator for page sized allocations? > + chunk_nr_pages = PAGE_SIZE/sizeof(struct page_to_node) - 1; Blanks missing. > + /* fill the chunk pm with addrs and nodes from user-space */ > + for (j = 0; j < chunk_nr_pages; j++) { j? So the chunk_start used to be i? Acked-by: Christoph Lameter -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org