From: "H. Peter Anvin" <hpa@zytor.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Ingo Molnar <mingo@elte.hu>, Alan Cox <alan@lxorguk.ukuu.org.uk>,
Jiri Slaby <jirislaby@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-mm@kvack.org, "David S. Miller" <davem@davemloft.net>,
the arch/x86 maintainers <x86@kernel.org>
Subject: Re: GIT head no longer boots on x86-64
Date: Thu, 16 Oct 2008 03:31:18 -0700 [thread overview]
Message-ID: <48F717F6.10804@zytor.com> (raw)
In-Reply-To: <alpine.LFD.2.00.0810150815000.3288@nehalem.linux-foundation.org>
Linus Torvalds wrote:
>
> Oh, btw. This patch is *totally* untested. I don't even enable modules. So
> if it doesn't compile, it isn't perfect. But while it may not _work_, at
> least it's not _ugly_.
>
> (Quite frankly, I think an even more correct fix is to rename the whole
> "vmalloc_to_page()" function, since it's clearly used for other things
> than vmalloc. Maybe "kernel_virtual_to_page()". Whatever. This is trying
> to be minimal without being totally disgusting).
>
I have verified that this patch fixes the problem, at least in my test
rig, and has queued it up for tip:x86/urgent. It should be in the next
pull request.
Note that this bug only bites when CONFIG_DEBUG_VIRTUAL=y and we're
running an SMP kernel on UP. Not that that is any excuse.
-hpa
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2008-10-16 10:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <alpine.LFD.2.00.0810130752020.3288@nehalem.linux-foundation.org>
2008-10-13 15:11 ` Jiri Slaby
2008-10-13 15:47 ` Alan Cox
2008-10-15 11:51 ` Ingo Molnar
2008-10-15 13:19 ` Jiri Slaby
2008-10-15 15:06 ` Linus Torvalds
2008-10-15 15:33 ` Jiri Slaby
2008-10-15 16:01 ` Linus Torvalds
2008-10-15 20:31 ` Arjan van de Ven
2008-10-15 15:35 ` Linus Torvalds
2008-10-16 10:31 ` H. Peter Anvin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48F717F6.10804@zytor.com \
--to=hpa@zytor.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=davem@davemloft.net \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@elte.hu \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox