* [mmotm 02/Oct PATCH 1/3] adjust Quicklists field of /proc/meminfo
@ 2008-10-09 6:39 KOSAKI Motohiro
2008-10-09 6:42 ` [mmotm 02/Oct PATCH 2/3] adjust hugepage related " KOSAKI Motohiro
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: KOSAKI Motohiro @ 2008-10-09 6:39 UTC (permalink / raw)
To: linux-mm, Andrew Morton
Cc: kosaki.motohiro, LKML, Lee Schermerhorn, Rik van Riel, Hugh Dickins
vmscan-split-lru-lists-into-anon-file-sets.patch changed /proc/meminfo output length,
but only Quicklists: field doesn't.
(because quicklists field added after than split-lru)
example:
$ cat /proc/meminfo
MemTotal: 7994624 kB
MemFree: 21376 kB
(snip)
SUnreclaim: 78912 kB
PageTables: 1233472 kB
Quicklists: 7808 kB
NFS_Unstable: 0 kB
this patch fix it.
Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
---
fs/proc/proc_misc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: b/fs/proc/proc_misc.c
===================================================================
--- a/fs/proc/proc_misc.c
+++ b/fs/proc/proc_misc.c
@@ -195,7 +195,7 @@ static int meminfo_read_proc(char *page,
"SUnreclaim: %8lu kB\n"
"PageTables: %8lu kB\n"
#ifdef CONFIG_QUICKLIST
- "Quicklists: %8lu kB\n"
+ "Quicklists: %8lu kB\n"
#endif
"NFS_Unstable: %8lu kB\n"
"Bounce: %8lu kB\n"
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [mmotm 02/Oct PATCH 2/3] adjust hugepage related field of /proc/meminfo
2008-10-09 6:39 [mmotm 02/Oct PATCH 1/3] adjust Quicklists field of /proc/meminfo KOSAKI Motohiro
@ 2008-10-09 6:42 ` KOSAKI Motohiro
2008-10-09 11:24 ` Rik van Riel
2008-10-09 6:43 ` [mmotm 02/Oct PATCH 3/3] fix style issue of get_scan_ratio() KOSAKI Motohiro
2008-10-09 11:23 ` [mmotm 02/Oct PATCH 1/3] adjust Quicklists field of /proc/meminfo Rik van Riel
2 siblings, 1 reply; 6+ messages in thread
From: KOSAKI Motohiro @ 2008-10-09 6:42 UTC (permalink / raw)
To: linux-mm, Andrew Morton, Mel Gorman
Cc: kosaki.motohiro, LKML, Lee Schermerhorn, Rik van Riel
adjust hugepage related field in /proc/meminfo.
(because vmscan-split-lru-lists-into-anon-file-sets.patch changed
length of other field)
before:
CommitLimit: 6028800 kB
Committed_AS: 8685888 kB
VmallocTotal: 17592177655808 kB
VmallocUsed: 28544 kB
VmallocChunk: 17592177626816 kB
HugePages_Total: 0
HugePages_Free: 0
HugePages_Rsvd: 0
HugePages_Surp: 0
Hugepagesize: 262144 kB
after:
CommitLimit: 6028800 kB
Committed_AS: 8685888 kB
VmallocTotal: 17592177655808 kB
VmallocUsed: 28544 kB
VmallocChunk: 17592177626816 kB
HugePages_Total: 0
HugePages_Free: 0
HugePages_Rsvd: 0
HugePages_Surp: 0
Hugepagesize: 262144 kB
Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
---
mm/hugetlb.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
Index: b/mm/hugetlb.c
===================================================================
--- a/mm/hugetlb.c
+++ b/mm/hugetlb.c
@@ -1459,11 +1459,11 @@ int hugetlb_report_meminfo(char *buf)
{
struct hstate *h = &default_hstate;
return sprintf(buf,
- "HugePages_Total: %5lu\n"
- "HugePages_Free: %5lu\n"
- "HugePages_Rsvd: %5lu\n"
- "HugePages_Surp: %5lu\n"
- "Hugepagesize: %5lu kB\n",
+ "HugePages_Total: %5lu\n"
+ "HugePages_Free: %5lu\n"
+ "HugePages_Rsvd: %5lu\n"
+ "HugePages_Surp: %5lu\n"
+ "Hugepagesize: %8lu kB\n",
h->nr_huge_pages,
h->free_huge_pages,
h->resv_huge_pages,
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [mmotm 02/Oct PATCH 3/3] fix style issue of get_scan_ratio()
2008-10-09 6:39 [mmotm 02/Oct PATCH 1/3] adjust Quicklists field of /proc/meminfo KOSAKI Motohiro
2008-10-09 6:42 ` [mmotm 02/Oct PATCH 2/3] adjust hugepage related " KOSAKI Motohiro
@ 2008-10-09 6:43 ` KOSAKI Motohiro
2008-10-09 11:24 ` Rik van Riel
2008-10-09 11:23 ` [mmotm 02/Oct PATCH 1/3] adjust Quicklists field of /proc/meminfo Rik van Riel
2 siblings, 1 reply; 6+ messages in thread
From: KOSAKI Motohiro @ 2008-10-09 6:43 UTC (permalink / raw)
To: linux-mm, Andrew Morton, Rik van Riel
Cc: kosaki.motohiro, LKML, Lee Schermerhorn
vmscan-split-lru-lists-into-anon-file-sets.patch introduce two style issue.
this patch fix it.
Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
---
mm/vmscan.c | 22 +++++++++++-----------
1 file changed, 11 insertions(+), 11 deletions(-)
Index: b/mm/vmscan.c
===================================================================
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -1420,7 +1420,7 @@ static unsigned long shrink_list(enum lr
* percent[0] specifies how much pressure to put on ram/swap backed
* memory, while percent[1] determines pressure on the file LRUs.
*/
-static void get_scan_ratio(struct zone *zone, struct scan_control * sc,
+static void get_scan_ratio(struct zone *zone, struct scan_control *sc,
unsigned long *percent)
{
unsigned long anon, file, free;
@@ -1448,16 +1448,16 @@ static void get_scan_ratio(struct zone *
}
/*
- * OK, so we have swap space and a fair amount of page cache
- * pages. We use the recently rotated / recently scanned
- * ratios to determine how valuable each cache is.
- *
- * Because workloads change over time (and to avoid overflow)
- * we keep these statistics as a floating average, which ends
- * up weighing recent references more than old ones.
- *
- * anon in [0], file in [1]
- */
+ * OK, so we have swap space and a fair amount of page cache
+ * pages. We use the recently rotated / recently scanned
+ * ratios to determine how valuable each cache is.
+ *
+ * Because workloads change over time (and to avoid overflow)
+ * we keep these statistics as a floating average, which ends
+ * up weighing recent references more than old ones.
+ *
+ * anon in [0], file in [1]
+ */
if (unlikely(zone->recent_scanned[0] > anon / 4)) {
spin_lock_irq(&zone->lru_lock);
zone->recent_scanned[0] /= 2;
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [mmotm 02/Oct PATCH 1/3] adjust Quicklists field of /proc/meminfo
2008-10-09 6:39 [mmotm 02/Oct PATCH 1/3] adjust Quicklists field of /proc/meminfo KOSAKI Motohiro
2008-10-09 6:42 ` [mmotm 02/Oct PATCH 2/3] adjust hugepage related " KOSAKI Motohiro
2008-10-09 6:43 ` [mmotm 02/Oct PATCH 3/3] fix style issue of get_scan_ratio() KOSAKI Motohiro
@ 2008-10-09 11:23 ` Rik van Riel
2 siblings, 0 replies; 6+ messages in thread
From: Rik van Riel @ 2008-10-09 11:23 UTC (permalink / raw)
To: KOSAKI Motohiro
Cc: linux-mm, Andrew Morton, LKML, Lee Schermerhorn, Hugh Dickins
KOSAKI Motohiro wrote:
> vmscan-split-lru-lists-into-anon-file-sets.patch changed /proc/meminfo output length,
> but only Quicklists: field doesn't.
> (because quicklists field added after than split-lru)
> Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Acked-by: Rik van Riel <riel@redhat.com>
--
All rights reversed.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [mmotm 02/Oct PATCH 2/3] adjust hugepage related field of /proc/meminfo
2008-10-09 6:42 ` [mmotm 02/Oct PATCH 2/3] adjust hugepage related " KOSAKI Motohiro
@ 2008-10-09 11:24 ` Rik van Riel
0 siblings, 0 replies; 6+ messages in thread
From: Rik van Riel @ 2008-10-09 11:24 UTC (permalink / raw)
To: KOSAKI Motohiro
Cc: linux-mm, Andrew Morton, Mel Gorman, LKML, Lee Schermerhorn
KOSAKI Motohiro wrote:
> adjust hugepage related field in /proc/meminfo.
> (because vmscan-split-lru-lists-into-anon-file-sets.patch changed
> length of other field)
> Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Acked-by: Rik van Riel <riel@redhat.com>
--
All rights reversed.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [mmotm 02/Oct PATCH 3/3] fix style issue of get_scan_ratio()
2008-10-09 6:43 ` [mmotm 02/Oct PATCH 3/3] fix style issue of get_scan_ratio() KOSAKI Motohiro
@ 2008-10-09 11:24 ` Rik van Riel
0 siblings, 0 replies; 6+ messages in thread
From: Rik van Riel @ 2008-10-09 11:24 UTC (permalink / raw)
To: KOSAKI Motohiro; +Cc: linux-mm, Andrew Morton, LKML, Lee Schermerhorn
KOSAKI Motohiro wrote:
> vmscan-split-lru-lists-into-anon-file-sets.patch introduce two style issue.
> this patch fix it.
>
>
> Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Acked-by: Rik van Riel <riel@redhat.com>
--
All rights reversed.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2008-10-09 11:24 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-10-09 6:39 [mmotm 02/Oct PATCH 1/3] adjust Quicklists field of /proc/meminfo KOSAKI Motohiro
2008-10-09 6:42 ` [mmotm 02/Oct PATCH 2/3] adjust hugepage related " KOSAKI Motohiro
2008-10-09 11:24 ` Rik van Riel
2008-10-09 6:43 ` [mmotm 02/Oct PATCH 3/3] fix style issue of get_scan_ratio() KOSAKI Motohiro
2008-10-09 11:24 ` Rik van Riel
2008-10-09 11:23 ` [mmotm 02/Oct PATCH 1/3] adjust Quicklists field of /proc/meminfo Rik van Riel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox