From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <48EB8314.1030701@linux-foundation.org> Date: Tue, 07 Oct 2008 10:41:08 -0500 From: Christoph Lameter MIME-Version: 1.0 Subject: Re: [PATCH next 1/3] slub defrag: unpin writeback pages References: <48EB62F9.9040409@linux-foundation.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Hugh Dickins Cc: Pekka Enberg , Andrew Morton , linux-mm@kvack.org List-ID: Hugh Dickins wrote: > But since the cacheline is already dirty (from get_page_unless_zero), > and it's only a trylock, and we (almost certainly) need to repeat the > PageWriteback test once we've got the lock, and it does not hit this > case often enough for you to have noticed the missing put_page() bug, > I decided to save icache instead by just removing your optimization. Ok. Acked-by: Christoph Lameter -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org