From: Christoph Lameter <cl@linux-foundation.org>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Matt Mackall <mpm@selenic.com>, linux-mm <linux-mm@kvack.org>,
Nick Piggin <nickpiggin@yahoo.com.au>,
Linus Torvalds <torvalds@linux-foundation.org>,
Ingo Molnar <mingo@elte.hu>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [BUG] SLOB's krealloc() seems bust
Date: Tue, 07 Oct 2008 09:26:26 -0500 [thread overview]
Message-ID: <48EB7192.6090307@linux-foundation.org> (raw)
In-Reply-To: <1223388788.26330.38.camel@lappy.programming.kicks-ass.net>
Peter Zijlstra wrote:
> kernel/module.c: perpcu_modinit() reads:
>
> pcpu_size = kmalloc(sizeof(pcpu_size[0]) * pcpu_num_allocated,
> GFP_KERNEL);
>
> kernel/module.c: split_block() reads:
>
> new = krealloc(pcpu_size, sizeof(new[0])*pcpu_num_allocated*2,
> GFP_KERNEL);
>
That code is on the way out btw. cpu_alloc support removes this code.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-10-07 14:26 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-07 13:57 Peter Zijlstra
2008-10-07 14:07 ` Christoph Lameter
2008-10-07 14:13 ` Peter Zijlstra
2008-10-07 14:26 ` Christoph Lameter [this message]
2008-10-07 15:00 ` Matt Mackall
2008-10-07 15:20 ` Christoph Lameter
2008-10-07 15:58 ` Matt Mackall
2008-10-07 16:10 ` Peter Zijlstra
2008-10-07 16:37 ` Linus Torvalds
2008-10-07 16:37 ` Matt Mackall
2008-10-07 16:57 ` Pekka Enberg
2008-10-07 17:13 ` Matt Mackall
2008-10-07 17:31 ` Pekka Enberg
2008-10-07 23:08 ` Matt Mackall
2008-10-08 4:22 ` Nick Piggin
2008-10-08 4:46 ` Matt Mackall
2008-10-08 4:54 ` Nick Piggin
2008-10-08 5:11 ` Nick Piggin
2008-10-08 5:15 ` Matt Mackall
2008-10-08 6:43 ` Peter Zijlstra
2008-10-08 7:25 ` Pekka Enberg
2008-10-08 7:37 ` Peter Zijlstra
2008-10-08 7:39 ` Pekka Enberg
2008-10-07 17:57 ` Linus Torvalds
2008-10-07 18:11 ` Peter Zijlstra
2008-10-07 18:18 ` Linus Torvalds
2008-10-08 19:51 ` Matt Mackall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48EB7192.6090307@linux-foundation.org \
--to=cl@linux-foundation.org \
--cc=a.p.zijlstra@chello.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@elte.hu \
--cc=mpm@selenic.com \
--cc=nickpiggin@yahoo.com.au \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox