From: Christoph Lameter <cl@linux-foundation.org>
To: Richard Kennedy <richard@rsk.demon.co.uk>
Cc: penberg <penberg@cs.helsinki.fi>, mpm <mpm@selenic.com>,
linux-mm <linux-mm@kvack.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] slub: reduce total stack usage of slab_err & object_err
Date: Tue, 30 Sep 2008 12:36:08 -0500 [thread overview]
Message-ID: <48E26388.30202@linux-foundation.org> (raw)
In-Reply-To: <1222791638.2995.41.camel@castor.localdomain>
Richard Kennedy wrote:
> Yes, using vprintk is better but you still have this path :
> ( with your patch applied)
>
> object_err -> slab_bug(208) -> printk(216)
> instead of
> object_err -> slab_bug_message(8) -> printk(216)
>
> unfortunately the overhead for having var_args is pretty big, at least
> on x86_64. I haven't measured it on 32 bit yet.
Really 208 bytes for a va arg parameter declaration? I expected it to be
simply a null terminated pointer list.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-09-30 17:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-30 15:15 Richard Kennedy
2008-09-30 15:32 ` Matt Mackall
2008-09-30 15:38 ` Christoph Lameter
2008-09-30 15:49 ` Matt Mackall
2008-09-30 16:20 ` Richard Kennedy
2008-09-30 16:43 ` Matt Mackall
2008-09-30 17:36 ` Christoph Lameter [this message]
2008-09-30 17:37 ` Matt Mackall
2008-09-30 18:33 ` Matt Mackall
2008-10-01 9:50 ` Richard Kennedy
2008-10-01 0:02 ` Matt Mackall
2008-09-30 19:33 ` Jörn Engel
2008-10-01 10:06 ` Richard Kennedy
2008-10-01 10:32 ` Jörn Engel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48E26388.30202@linux-foundation.org \
--to=cl@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mpm@selenic.com \
--cc=penberg@cs.helsinki.fi \
--cc=richard@rsk.demon.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox