From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <48E2480A.9090003@linux-foundation.org> Date: Tue, 30 Sep 2008 10:38:50 -0500 From: Christoph Lameter MIME-Version: 1.0 Subject: Re: [PATCH] slub: reduce total stack usage of slab_err & object_err References: <1222787736.2995.24.camel@castor.localdomain> In-Reply-To: <1222787736.2995.24.camel@castor.localdomain> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Richard Kennedy Cc: penberg , mpm , linux-mm , lkml List-ID: Richard Kennedy wrote: > reduce the total stack usage of slab_err & object_err. > > Introduce a new function to display a simple slab bug message, and call > this when vprintk is not needed. You could simply get rid of the 100 byte buffer by using vprintk? Same method could be used elsewhere in the kernel and does not require additional functions. Compiles, untestted. Subject: Slub reduce slab_bug stack usage by using vprintk Signed-off-by: Christoph Lameter Index: linux-2.6/mm/slub.c =================================================================== --- linux-2.6.orig/mm/slub.c 2008-09-30 10:34:40.000000000 -0500 +++ linux-2.6/mm/slub.c 2008-09-30 10:36:10.000000000 -0500 @@ -422,15 +422,14 @@ static void slab_bug(struct kmem_cache *s, char *fmt, ...) { va_list args; - char buf[100]; va_start(args, fmt); - vsnprintf(buf, sizeof(buf), fmt, args); - va_end(args); printk(KERN_ERR "========================================" "=====================================\n"); - printk(KERN_ERR "BUG %s: %s\n", s->name, buf); - printk(KERN_ERR "----------------------------------------" + printk(KERN_ERR "BUG %s: ", s->name); + vprintk(fmt, args); + va_end(args); + printk(KERN_ERR "\n----------------------------------------" "-------------------------------------\n\n"); } -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org