From: Christoph Lameter <cl@linux-foundation.org>
To: akpm@linux-foundation.org
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
jeremy@goop.org, ebiederm@xmission.com, travis@sgi.com,
herbert@gondor.apana.org.au, xemul@openvz.org,
penberg@cs.helsinki.fi
Subject: Re: [patch 3/4] cpu alloc: The allocator
Date: Fri, 19 Sep 2008 15:32:03 -0500 [thread overview]
Message-ID: <48D40C43.5070200@linux-foundation.org> (raw)
In-Reply-To: <20080919145929.158651064@quilx.com>
Duh. A cast went missing which results in a pointer calculation going haywire.
Signed-off-by: <cl@linux-foundation.org>
Index: linux-2.6/mm/cpu_alloc.c
===================================================================
--- linux-2.6.orig/mm/cpu_alloc.c 2008-09-19 14:57:25.000000000 -0500
+++ linux-2.6/mm/cpu_alloc.c 2008-09-19 14:57:33.000000000 -0500
@@ -126,7 +126,7 @@
spin_unlock_irqrestore(&cpu_alloc_map_lock, flags);
- ptr = __per_cpu_end + start;
+ ptr = (int *)__per_cpu_end + start;
printk(KERN_INFO "%d per cpu units allocated at offset %lx address %p\n",
units, start, ptr)
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-09-19 20:32 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-19 14:58 [patch 0/4] Cpu alloc V5: Replace percpu allocator in modules.c Christoph Lameter
2008-09-19 14:59 ` [patch 1/4] Make the per cpu reserve configurable Christoph Lameter
2008-09-20 3:55 ` KAMEZAWA Hiroyuki
2008-09-20 23:15 ` Christoph Lameter
2008-09-19 14:59 ` [patch 2/4] percpu: Rename variables PERCPU_ENOUGH_ROOM -> PERCPU_AREA_SIZE Christoph Lameter
2008-09-19 14:59 ` [patch 3/4] cpu alloc: The allocator Christoph Lameter
2008-09-19 15:23 ` KOSAKI Motohiro
2008-09-19 16:27 ` Eric Dumazet
2008-09-19 16:49 ` Christoph Lameter
2008-09-19 17:00 ` Christoph Lameter
2008-09-19 20:32 ` Christoph Lameter [this message]
2008-09-19 14:59 ` [patch 4/4] cpu alloc: Use cpu allocator instead of the builtin modules per cpu allocator Christoph Lameter
2008-09-19 15:28 ` [patch 0/4] Cpu alloc V5: Replace percpu allocator in modules.c KOSAKI Motohiro
2008-09-19 15:50 ` Christoph Lameter
2008-09-29 19:35 [patch 0/4] Cpu alloc V6: " Christoph Lameter
2008-09-29 19:35 ` [patch 3/4] cpu alloc: The allocator Christoph Lameter
2008-09-30 6:35 ` Pekka Enberg
2008-09-30 11:38 ` Christoph Lameter
2008-09-30 11:48 ` Pekka Enberg
2008-09-30 12:12 ` Christoph Lameter
2008-10-03 7:33 ` Andrew Morton
2008-10-03 7:43 ` Pekka Enberg
2008-10-03 8:20 ` Andrew Morton
2008-10-03 14:15 ` Christoph Lameter
2008-10-03 12:48 ` Christoph Lameter
2008-10-05 21:10 ` Rusty Russell
2008-10-07 13:27 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48D40C43.5070200@linux-foundation.org \
--to=cl@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=herbert@gondor.apana.org.au \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@cs.helsinki.fi \
--cc=travis@sgi.com \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox