From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <48D2F05C.4040000@redhat.com> Date: Thu, 18 Sep 2008 17:20:44 -0700 From: Avi Kivity MIME-Version: 1.0 Subject: Re: Populating multiple ptes at fault time References: <48D142B2.3040607@goop.org> <48D17E75.80807@redhat.com> <48D1851B.70703@goop.org> <48D18919.9060808@redhat.com> <48D18C6B.5010407@goop.org> <48D2B970.7040903@redhat.com> <48D2D3B2.10503@goop.org> <48D2E65A.6020004@redhat.com> <48D2EBBB.205@goop.org> In-Reply-To: <48D2EBBB.205@goop.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Jeremy Fitzhardinge Cc: Nick Piggin , Hugh Dickens , Linux Memory Management List , Linux Kernel Mailing List , Andrew Morton , Rik van Riel , Marcelo Tosatti List-ID: Jeremy Fitzhardinge wrote: > >>> bet there's an appropriate pvop hook you could use to force >>> synchronization just before the kernel actually inspects the bits >>> (leaving lazy mode sounds good). >>> >>> >> It would have to be a new lazy mode, not the existing one, I think. >> > > The only direct use of pte_young() is in zap_pte_range, within a > mmu_lazy region. So syncing the A bit state on entering lazy mmu mode > would work fine there. > > Ugh, leaving lazy pte.a mode when entering lazy mmu mode? > The call via page_referenced_one() doesn't seem to have a very > convenient hook though. Perhaps putting something in > page_check_address() would do the job. > > Why there? Why not explicitly in the callers? We need more than to exit lazy pte.a mode, we also need to enter it again later. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org