From: Andrea Righi <righi.andrea@gmail.com>
To: kamezawa.hiroyu@jp.fujitsu.com
Cc: Balbir Singh <balbir@linux.vnet.ibm.com>,
Paul Menage <menage@google.com>,
Dave Hansen <dave@linux.vnet.ibm.com>,
Carl Henrik Lunde <chlunde@ping.uio.no>,
Divyesh Shah <dpshah@google.com>,
Naveen Gupta <ngupta@google.com>,
Fernando Luis V?zquez Cao <fernando@oss.ntt.co.jp>,
Andrew Morton <akpm@linux-foundation.org>,
Hirokazu Takahashi <taka@valinux.co.jp>,
Marco Innocenti <m.innocenti@cineca.it>,
Satoshi UCHIDA <s-uchida@ap.jp.nec.com>,
Ryo Tsuruta <ryov@valinux.co.jp>, Vivek Goyal <vgoyal@redhat.com>,
Matt Heaton <matt@bluehost.com>,
David Radford <dradford@bluehost.com>,
containers@lists.linux-foundation.org,
LKML <linux-kernel@vger.kernel.org>,
linux-mm@kvack.org
Subject: Re: [RFC] [PATCH -mm] cgroup: limit the amount of dirty file pages
Date: Tue, 09 Sep 2008 18:39:12 +0200 [thread overview]
Message-ID: <48C6A6B0.8090606@gmail.com> (raw)
In-Reply-To: <11118085.1220977593430.kamezawa.hiroyu@jp.fujitsu.com>
kamezawa.hiroyu@jp.fujitsu.com wrote:
> ----- Original Message -----
>> This is a totally experimental patch against 2.6.27-rc5-mm1.
>>
>> It allows to control how much dirty file pages a cgroup can have at any
>> given time. This feature is supposed to be strictly connected to a
>> generic cgroup IO controller (see below).
>>
>> Interface: a new entry "filedirty" is added to the file memory.stat,
>> reporting the number of dirty file pages (in pages), and a new file
>> memory.file_dirty_limit_in_pages is added in the cgroup filesystem to
>> show/set the current limit.
>>
> Before staring patch review, why not dirty_ratio per memcg ?
> Is there difficult implementation issue ?
mmmh.. maybe it's a bit more complex (would add some overhead?) to
translate the limit from dirty_ratio into pages or bytes, because we
need to evaluate it in function of the per-cgroup dirtyable memory (lru
pages and free pages I suppose). Maybe it's enough to implement it
directly in determine_dirtyable_memory().
I can try to implement it and post a new patch.
-Andrea
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-09-09 16:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-09 15:38 Andrea Righi
2008-09-09 16:26 ` kamezawa.hiroyu
2008-09-09 16:39 ` Andrea Righi [this message]
2008-09-09 17:49 ` Dave Hansen
2008-09-10 7:26 ` Andrea Righi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48C6A6B0.8090606@gmail.com \
--to=righi.andrea@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=chlunde@ping.uio.no \
--cc=containers@lists.linux-foundation.org \
--cc=dave@linux.vnet.ibm.com \
--cc=dpshah@google.com \
--cc=dradford@bluehost.com \
--cc=fernando@oss.ntt.co.jp \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=m.innocenti@cineca.it \
--cc=matt@bluehost.com \
--cc=menage@google.com \
--cc=ngupta@google.com \
--cc=ryov@valinux.co.jp \
--cc=s-uchida@ap.jp.nec.com \
--cc=taka@valinux.co.jp \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox