From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <48C67ED2.9030501@evidence.eu.com> Date: Tue, 09 Sep 2008 15:49:06 +0200 From: Claudio Scordino MIME-Version: 1.0 Subject: Re: Remove warning in compilation of ioremap References: <48C63E28.6060605@evidence.eu.com> <20080909095844.GF9104@flint.arm.linux.org.uk> In-Reply-To: <20080909095844.GF9104@flint.arm.linux.org.uk> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Russell King - ARM Linux Cc: linux-arm-kernel@lists.arm.linux.org.uk, linux-mm@kvack.org, Phil Blundell , "Luiz Fernando N. Capitulino" List-ID: Russell King - ARM Linux ha scritto: > On Tue, Sep 09, 2008 at 11:13:12AM +0200, Claudio Scordino wrote: >> When compiling Linux (latest kernel from Linus' git) on ARM, I noticed >> the following warning: >> >> CC arch/arm/mm/ioremap.o >> arch/arm/mm/ioremap.c: In function '__arm_ioremap_pfn': >> arch/arm/mm/ioremap.c:83: warning: control may reach end of non-void >> function 'remap_area_pte' being inlined >> >> If you look at the code, the problem is in a path including a BUG(). >> >> AFAIK, on ARM the code following BUG() is never executed: it's a NULL >> pointer dereference, so the handler of pagefault eventually calls >> do_exit(). Therefore, we may want to remove the goto as shown in the >> patch in attachment. >> >> It's obviously a minor issue. But I don't like having meaningless >> warnings during compilation: they just confuse output, and developers >> may miss some important warning message... >> >> The need for the goto exists only if BUG() can return. If it doesn't, >> we can safely remove it as shown in the patch. > > NAK. See patch 5211/2 in the patch system. Seen. Thanks, Claudio -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org