Remove warning in compilation of ioremap

* Remove warning in compilation of ioremap
@ 2008-09-09  9:13 Claudio Scordino
  2008-09-09  9:58 ` Russell King - ARM Linux
  2008-09-09 13:08 ` David Anders
  0 siblings, 2 replies; 7+ messages in thread
From: Claudio Scordino @ 2008-09-09  9:13 UTC (permalink / raw)
  To: linux-arm-kernel; +Cc: linux-mm, Luiz Fernando N. Capitulino, Phil Blundell

[-- Attachment #1: Type: text/plain, Size: 1132 bytes --]

Hi all.

[We already discussed this issue in linux-mm ML, but people suggested 
to post to linux-arm-kernel...]

When compiling Linux (latest kernel from Linus' git) on ARM, I noticed
the following warning:

CC      arch/arm/mm/ioremap.o
arch/arm/mm/ioremap.c: In function '__arm_ioremap_pfn':
arch/arm/mm/ioremap.c:83: warning: control may reach end of non-void
function 'remap_area_pte' being inlined

If you look at the code, the problem is in a path including a BUG().

AFAIK, on ARM the code following BUG() is never executed: it's a NULL
pointer dereference, so the handler of pagefault eventually calls
do_exit(). Therefore, we may want to remove the goto as shown in the
patch in attachment.

It's obviously a minor issue. But I don't like having meaningless
warnings during compilation: they just confuse output, and developers 
may miss some important warning message...

The need for the goto exists only if BUG() can return. If it doesn't,
we can safely remove it as shown in the patch.

Is this possible ? Should we update this piece of code ? Who's in
charge of maintaining it ?

Many thanks,

           Claudio






[-- Attachment #2: 0001-Fix-compilation-warning-in-remap_area_pte.patch --]
[-- Type: text/x-diff, Size: 1148 bytes --]

>From 08d2e6f14230bf2252c54f5421d92def5e70f6dc Mon Sep 17 00:00:00 2001
From: Claudio Scordino <claudio@evidence.eu.com>
Date: Mon, 8 Sep 2008 16:03:38 +0200
Subject: [PATCH 1/1] Fix compilation warning in remap_area_pte


Signed-off-by: Claudio Scordino <claudio@evidence.eu.com>
---
 arch/arm/mm/ioremap.c |   11 ++++-------
 1 files changed, 4 insertions(+), 7 deletions(-)

diff --git a/arch/arm/mm/ioremap.c b/arch/arm/mm/ioremap.c
index b81dbf9..bc6eca0 100644
--- a/arch/arm/mm/ioremap.c
+++ b/arch/arm/mm/ioremap.c
@@ -52,18 +52,15 @@ static int remap_area_pte(pmd_t *pmd, unsigned long addr, unsigned long end,
 		return -ENOMEM;
 
 	do {
-		if (!pte_none(*pte))
-			goto bad;
-
+		if (unlikely(!pte_none(*pte))){
+			printk(KERN_CRIT "%s: page already exists\n", __FUNCTION__);
+			BUG();
+		}
 		set_pte_ext(pte, pfn_pte(phys_addr >> PAGE_SHIFT, prot),
 			    type->prot_pte_ext);
 		phys_addr += PAGE_SIZE;
 	} while (pte++, addr += PAGE_SIZE, addr != end);
 	return 0;
-
- bad:
-	printk(KERN_CRIT "remap_area_pte: page already exists\n");
-	BUG();
 }
 
 static inline int remap_area_pmd(pgd_t *pgd, unsigned long addr,
-- 
1.5.4.3




^ permalink raw reply	[flat|nested] 7+ messages in thread