From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <48AD689F.6080103@linux-foundation.org> Date: Thu, 21 Aug 2008 08:07:43 -0500 From: Christoph Lameter MIME-Version: 1.0 Subject: Re: [RFC][PATCH 0/2] Quicklist is slighly problematic. References: <20080820195021.12E7.KOSAKI.MOTOHIRO@jp.fujitsu.com> <20080820113131.f032c8a2.akpm@linux-foundation.org> <20080821024240.GC23397@sgi.com> In-Reply-To: <20080821024240.GC23397@sgi.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Robin Holt Cc: Andrew Morton , KOSAKI Motohiro , linux-kernel@vger.kernel.org, linux-mm@kvack.org, tokunaga.keiich@jp.fujitsu.com, stable@kernel.org List-ID: Robin Holt wrote: > > Index: ia64-cleanups/include/linux/quicklist.h > =================================================================== > --- ia64-cleanups.orig/include/linux/quicklist.h 2008-08-20 21:35:10.000000000 -0500 > +++ ia64-cleanups/include/linux/quicklist.h 2008-08-20 21:38:00.891943270 -0500 > @@ -66,6 +66,15 @@ static inline void __quicklist_free(int > > static inline void quicklist_free(int nr, void (*dtor)(void *), void *pp) > { > +#ifdef CONFIG_NUMA > + unsigned long nid = page_to_nid(virt_to_page(pp)); > + > + if (unlikely(nid != numa_node_id())) { > + free_page((unsigned long)pp); > + return; > + } > +#endif > + > __quicklist_free(nr, dtor, pp, virt_to_page(pp)); > } > We removed this code because it frees a page before the TLB flush has been performed. This code segment was the reason that quicklists were not accepted for x86. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org