From: Balbir Singh <balbir@linux.vnet.ibm.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, skumar@linux.vnet.ibm.com,
yamamoto@valinux.co.jp, menage@google.com, lizf@cn.fujitsu.com,
linux-kernel@vger.kernel.org, nishimura@mxp.nes.nec.co.jp,
xemul@openvz.org, hugh@veritas.com,
kamezawa.hiroyu@jp.fujitsu.com
Subject: Re: [-mm][PATCH 0/2] Memory rlimit fix crash on fork
Date: Wed, 13 Aug 2008 06:54:08 +0530 [thread overview]
Message-ID: <48A237B8.6060004@linux.vnet.ibm.com> (raw)
In-Reply-To: <20080812171407.2f468729.akpm@linux-foundation.org>
Andrew Morton wrote:
> On Mon, 11 Aug 2008 15:37:19 +0530
> Balbir Singh <balbir@linux.vnet.ibm.com> wrote:
>
>> --- linux-2.6.27-rc1/mm/memory.c~memrlimit-fix-crash-on-fork 2008-08-11 14:57:48.000000000 +0530
>> +++ linux-2.6.27-rc1-balbir/mm/memory.c 2008-08-11 14:58:33.000000000 +0530
>> @@ -901,8 +901,12 @@ unsigned long unmap_vmas(struct mmu_gath
>
> ^^ returns a long.
>
>> unsigned long start = start_addr;
>> spinlock_t *i_mmap_lock = details? details->i_mmap_lock: NULL;
>> int fullmm = (*tlbp)->fullmm;
>> - struct mm_struct *mm = vma->vm_mm;
>> + struct mm_struct *mm;
>> +
>> + if (!vma)
>> + return;
>
> ^^ mm/memory.c:907: warning: 'return' with no value, in function returning non-void
>
> How does this happen?
>
> I'll drop the patch. The above mystery change needs a comment, IMO.
Oops.. I'll send the updated version. I'll comment it as well.
--
Balbir
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-08-13 1:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-11 10:07 Balbir Singh
2008-08-11 10:07 ` [-mm][PATCH 1/2] mm owner fix race between swap and exit Balbir Singh
2008-08-12 0:31 ` Andrew Morton
2008-08-12 0:43 ` Paul Menage
2008-08-12 4:06 ` Balbir Singh
2008-08-12 4:56 ` Andrew Morton
2008-08-12 5:04 ` Balbir Singh
2008-08-11 10:07 ` [-mm][PATCH 2/2] Memory rlimit enhance mm_owner_changed callback to deal with exited owner Balbir Singh
2008-08-12 0:39 ` Paul Menage
2008-08-13 0:14 ` [-mm][PATCH 0/2] Memory rlimit fix crash on fork Andrew Morton
2008-08-13 1:24 ` Balbir Singh [this message]
2008-08-13 2:07 ` Balbir Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48A237B8.6060004@linux.vnet.ibm.com \
--to=balbir@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=hugh@veritas.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizf@cn.fujitsu.com \
--cc=menage@google.com \
--cc=nishimura@mxp.nes.nec.co.jp \
--cc=skumar@linux.vnet.ibm.com \
--cc=xemul@openvz.org \
--cc=yamamoto@valinux.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox