From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49DAAC001B2 for ; Sun, 11 Dec 2022 06:04:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9C0948E0003; Sun, 11 Dec 2022 01:04:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 970388E0001; Sun, 11 Dec 2022 01:04:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 838B28E0003; Sun, 11 Dec 2022 01:04:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 73AB68E0001 for ; Sun, 11 Dec 2022 01:04:06 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 294C9160167 for ; Sun, 11 Dec 2022 06:04:06 +0000 (UTC) X-FDA: 80228984892.12.BE19D09 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf21.hostedemail.com (Postfix) with ESMTP id 8A73C1C000D for ; Sun, 11 Dec 2022 06:04:04 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=gvn7tDTw; spf=pass (imf21.hostedemail.com: domain of chao@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=chao@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670738644; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1EnAx1geRWwCfFzlBGrx4cqIztH4USU76VYUhrnSf9o=; b=1XVhfaK7XklYEz1XSvCkQyd2zewf6KMmDiLnzfWglny+ubw223kN/Pg+sGB4Edr4l2V1Fh dD5lsVqvAHDUd2cjHOssxkelW0Y6+/yTWrKcbU9QvLE7DkcAdJKE3yZY0q4ARoE8jGmepp JbWYmpTppilTav2fW4JRG2vA7r3Tlpk= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=gvn7tDTw; spf=pass (imf21.hostedemail.com: domain of chao@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=chao@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670738644; a=rsa-sha256; cv=none; b=7bs7XGtytSkKesq9Y2miFAZ6g0MLwiHd83hjMrqHYUz1d0iTOxBeKLImg/rAlCYovuC378 Mw66iANuwfAkk66GbI0MDje52iaYspr4T8raGVW2K8Q1OtjOmA+ibKnJzODgY7a+dw0PDl nR1HOJeGDzxMnLIMe/E2qYEyyOWXMD8= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 61B2F60C99; Sun, 11 Dec 2022 06:04:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A34B2C433D2; Sun, 11 Dec 2022 06:03:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1670738642; bh=U9Rhp55xf6rXsF3RAaS6Y+CbURUJS89vuN+H36qlHoI=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=gvn7tDTwTp770J0jxxGbJ/eD63c2MIQ371jcBZF6XySVsl5cwc/6/VJo7EmthNzpR ox3i1TMBwhRRllHhRuEMj7/Ug14/jRwkSLG9TzG1xFIyrs+jBie1F8LMjwY/9KeJtK eIJeshb0ZiuFM2HlcrQabSdC3HRmw7LCtQjh0nG2y2NaUW5CC69gWekQmEFR96jvA+ W3ZPJEJYx+e3y7DQ4q8N6XLP/qxyzl9WAQoFLBlxikvESbccCCFgAfPRaObz5IC/oX VspM7gm8zxvpsnKEKbW6OjUEbeBubLYFyePfm/TrC3WWIJWxybX8d6rAxbBHKq/UQM W5JZ+7R9vuEBQ== Message-ID: <489f2daa-4559-6c32-71e2-8bab65fb8154@kernel.org> Date: Sun, 11 Dec 2022 14:03:57 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [f2fs-dev] [PATCH v4 16/23] f2fs: Convert f2fs_sync_meta_pages() to use filemap_get_folios_tag() Content-Language: en-US To: "Vishal Moola (Oracle)" , linux-fsdevel@vger.kernel.org Cc: linux-cifs@vger.kernel.org, linux-nilfs@vger.kernel.org, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-mm@kvack.org, ceph-devel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-afs@lists.infradead.org, linux-btrfs@vger.kernel.org References: <20221102161031.5820-1-vishal.moola@gmail.com> <20221102161031.5820-17-vishal.moola@gmail.com> From: Chao Yu In-Reply-To: <20221102161031.5820-17-vishal.moola@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 8A73C1C000D X-Stat-Signature: czsrbrn7n31ary6tefd8kej3sr4ehceg X-Rspam-User: X-HE-Tag: 1670738644-374190 X-HE-Meta: U2FsdGVkX19BEPjEQYdOmKjQAZBrSs1foJuL++WI9C0AtrUKC6GElhS+67biHTp/Pk14aCJPAx8a7BtQjxuJT+xqXMDGr7Ef+JXN+0LptpOgCA4sVZmFe34ps8j0ahv20/60SynOAH9eYs/g+yGrRl66wM5Dqj+3hvezZJGoIiXLHVYpkUyJYUqI8mX0h2KZ7KZeWAgcXH2UmU3HNE4evAXzArvZVeAyxKN3w/ykEq1OcpcqE0lxVyw481Yrek9aiq5wyR7+g/0XH7XEdEle+zsrTL94HIgZyJpT6cTPohsytzKkfmfQTcYTfA/Yy/LlitMJWhVrMM3fZksRYVYJ29bW0X2/64tVA97SIN9WcvAF0XVo7QpGW+JisIkUxbc8tFn97cPMfcBXH/qtKZAN0CqtFR/QHo4OavNR8Lwt2e7J8jOzJbBwrYlGXmlnhW/d20lyuX4jsOD6RWzBzuaEZI5FPhhCf1iqEUC6/nu4fuk5MC1fKBFfj793ARCFjHkSHQ7gdtTAFDIDO7g3uafBD2xBOcszJL1f8q9ilZdI9/qAWTZVUvF+RPng0PmDzUe8DFw/Pq/u8aJ5ng50qFzsi/iIJlzzow4Dechg0uA3dbf4PWl1Bh9txDInii1GuR3toS050tUlnNl+V6i9CRD6H928rJxjZF4MLnzzzbO73Hb8YXFI62eahoe4sEeYCzWlN/9JgfcJrrHnxifZ3OzbnpEGtuYmlJwOLwKYVxT0Hgi8DklG3jRSS1vfvVWFJ2PDl3Ak6p2LclPFMFnFrxCSQoYp0vtePH3mw8rIQhz6vRqgoqwgH3eOvxJu3RNWD//h8+Gu7/6SPgdFdvTV0LmdLnOqBaNfhSB3ztpjNQ89t++PTnhle3x2XnXCTELa1L7tqQCWLwDKa+ZcB0hOEaBcgVX/cUGNi2gAsduDTRBz7/lnXmBS1DpW5Ks/0wpAOElMjRza4021K3PM1pSb5lL Sa1gq3Cb 1A9G0zM6IiPQe3jA5bG0YubYmz9gho1yFsF8YRJFQMKQ3J051vwbjSAJUg5hNrcuki2BR3e8PefjEcGuJ6WZdPAVZVGEg3bH+4+UXWpwF2bOrmLxYAhE4e1s7yVBYgySXJg1V1pDhQq6Qv0VvmaXWtBS6Eg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/11/3 0:10, Vishal Moola (Oracle) wrote: > Convert function to use folios throughout. This is in preparation for the > removal of find_get_pages_range_tag(). This change removes 5 calls to > compound_head(). > > Initially the function was checking if the previous page index is truly the > previous page i.e. 1 index behind the current page. To convert to folios and > maintain this check we need to make the check > folio->index != prev + folio_nr_pages(previous folio) since we don't know > how many pages are in a folio. > > At index i == 0 the check is guaranteed to succeed, so to workaround indexing > bounds we can simply ignore the check for that specific index. This makes the > initial assignment of prev trivial, so I removed that as well. > > Also modified a comment in commit_checkpoint for consistency. > > Signed-off-by: Vishal Moola (Oracle) Acked-by: Chao Yu Thanks,