linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: J Freyensee <why2jjj.linux@gmail.com>
To: Igor Stoppa <igor.stoppa@huawei.com>,
	david@fromorbit.com, willy@infradead.org, keescook@chromium.org,
	mhocko@kernel.org
Cc: labbott@redhat.com, linux-security-module@vger.kernel.org,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	kernel-hardening@lists.openwall.com
Subject: Re: [PATCH 2/7] genalloc: selftest
Date: Mon, 5 Mar 2018 11:37:10 -0800	[thread overview]
Message-ID: <488cc366-bd10-425c-ef62-ce8536e3c62a@gmail.com> (raw)
In-Reply-To: <20180228200620.30026-3-igor.stoppa@huawei.com>


> +
> +/*
> + * In case of failure of any of these tests, memory corruption is almost
> + * guarranteed; allowing the boot to continue means risking to corrupt
> + * also any filesystem/block device accessed write mode.
> + * Therefore, BUG_ON() is used, when testing.
> + */
> +
> +

I like the explanation; good background info on why something is 
implemented the way it is :-).

Reviewed-by: Jay Freyensee <why2jjj.linux@gmail.com>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2018-03-05 19:37 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-28 20:06 [RFC PATCH v18 0/7] mm: security: ro protection for dynamic data Igor Stoppa
2018-02-28 20:06 ` [PATCH 1/7] genalloc: track beginning of allocations Igor Stoppa
2018-03-02 16:37   ` kbuild test robot
2018-03-02 16:47   ` kbuild test robot
2018-03-05 19:00   ` J Freyensee
2018-03-06 17:39     ` Igor Stoppa
2018-03-06 13:19   ` Mike Rapoport
2018-03-06 14:13     ` Matthew Wilcox
2018-03-07 14:48     ` Igor Stoppa
2018-03-07 15:46       ` Igor Stoppa
2018-03-07 17:44       ` Mike Rapoprt
2018-03-06 14:10   ` Matthew Wilcox
2018-03-06 16:05     ` Igor Stoppa
2018-03-07 10:51       ` Igor Stoppa
2018-02-28 20:06 ` [PATCH 2/7] genalloc: selftest Igor Stoppa
2018-03-05 19:37   ` J Freyensee [this message]
2018-02-28 20:06 ` [PATCH 3/7] struct page: add field for vm_struct Igor Stoppa
2018-03-03  2:35   ` kbuild test robot
2018-03-05 20:31   ` J Freyensee
2018-02-28 20:06 ` [PATCH 4/7] Protectable Memory Igor Stoppa
2018-03-06  3:59   ` J Freyensee
2018-03-07 14:07     ` Igor Stoppa
2018-03-12 19:13   ` Matthew Wilcox
2018-03-12 21:25     ` Igor Stoppa
2018-02-28 20:06 ` [PATCH 5/7] Pmalloc selftest Igor Stoppa
2018-03-03  6:59   ` kbuild test robot
2018-03-06 17:13   ` J Freyensee
2018-02-28 20:06 ` [PATCH 6/7] lkdtm: crash on overwriting protected pmalloc var Igor Stoppa
2018-03-06 17:20   ` J Freyensee
2018-03-07 13:18     ` Igor Stoppa
2018-03-07 17:26       ` J Freyensee
2018-02-28 20:06 ` [PATCH 7/7] Documentation for Pmalloc Igor Stoppa
2018-03-06 13:30   ` Mike Rapoport
2018-03-06 17:33   ` J Freyensee
  -- strict thread matches above, loose matches on Subject: below --
2018-02-23 14:48 [RFC PATCH v17 0/7] mm: security: ro protection for dynamic data Igor Stoppa
2018-02-23 14:48 ` [PATCH 2/7] genalloc: selftest Igor Stoppa
2018-02-23 22:42   ` J Freyensee
2018-02-26 12:11     ` Igor Stoppa
2018-02-26 17:46       ` J Freyensee
2018-02-26 18:00         ` Igor Stoppa
2018-02-26 19:12           ` Matthew Wilcox
2018-02-26 19:26             ` Igor Stoppa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=488cc366-bd10-425c-ef62-ce8536e3c62a@gmail.com \
    --to=why2jjj.linux@gmail.com \
    --cc=david@fromorbit.com \
    --cc=igor.stoppa@huawei.com \
    --cc=keescook@chromium.org \
    --cc=kernel-hardening@lists.openwall.com \
    --cc=labbott@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=mhocko@kernel.org \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox