From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by fg-out-1718.google.com with SMTP id 19so7379445fgg.4 for ; Mon, 28 Jul 2008 10:19:47 -0700 (PDT) Message-ID: <488DFFB0.1090107@gmail.com> Date: Mon, 28 Jul 2008 19:19:44 +0200 From: Andrea Righi Reply-To: righi.andrea@gmail.com MIME-Version: 1.0 Subject: Re: [PATCH 1/1] mm: unify pmd_free() implementation References: <488DF119.2000004@gmail.com> <20080729012656.566F.KOSAKI.MOTOHIRO@jp.fujitsu.com> In-Reply-To: <20080729012656.566F.KOSAKI.MOTOHIRO@jp.fujitsu.com> Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: KOSAKI Motohiro , Linus Torvalds Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org List-ID: KOSAKI Motohiro wrote: >> yep! clear. >> >> Ok, in this case wouldn't be better at least to define pud_free() as: >> >> static inline pud_free(struct mm_struct *mm, pmd_t *pmd) >> { >> } > > I also like this :) ok, a simpler patch using the inline function will follow. -Andrea -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org