From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 516F8C433F5 for ; Wed, 30 Mar 2022 02:05:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BDF0A8D0002; Tue, 29 Mar 2022 22:04:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B8FE68D0001; Tue, 29 Mar 2022 22:04:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A57798D0002; Tue, 29 Mar 2022 22:04:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 92C088D0001 for ; Tue, 29 Mar 2022 22:04:59 -0400 (EDT) Received: from smtpin31.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 3B67C18290E64 for ; Wed, 30 Mar 2022 02:04:59 +0000 (UTC) X-FDA: 79299409518.31.C4C94F1 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by imf23.hostedemail.com (Postfix) with ESMTP id 52C1D140003 for ; Wed, 30 Mar 2022 02:04:58 +0000 (UTC) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.54]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4KSqQr32ndzBrml; Wed, 30 Mar 2022 10:00:52 +0800 (CST) Received: from [10.174.177.76] (10.174.177.76) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Wed, 30 Mar 2022 10:04:55 +0800 Subject: Re: [PATCH 3/8] mm/vmscan: introduce helper function reclaim_page_list() To: Matthew Wilcox CC: , , References: <20220329132619.18689-1-linmiaohe@huawei.com> <20220329132619.18689-4-linmiaohe@huawei.com> From: Miaohe Lin Message-ID: <4880f7de-625c-1d93-3b65-81f6c849de7b@huawei.com> Date: Wed, 30 Mar 2022 10:04:54 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.76] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 52C1D140003 X-Stat-Signature: 4qkc8879thn46qucmg3dzt3amckk3w1x X-Rspam-User: Authentication-Results: imf23.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf23.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com X-HE-Tag: 1648605898-168450 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/3/29 21:50, Matthew Wilcox wrote: > On Tue, Mar 29, 2022 at 09:26:14PM +0800, Miaohe Lin wrote: >> -unsigned long reclaim_pages(struct list_head *page_list) >> +static inline unsigned int reclaim_page_list(struct list_head *page_list, struct pglist_data *pgdat) >> { >> - int nid = NUMA_NO_NODE; >> - unsigned int nr_reclaimed = 0; >> - LIST_HEAD(node_page_list); >> struct reclaim_stat dummy_stat; >> + unsigned int nr_reclaimed; >> struct page *page; >> - unsigned int noreclaim_flag; >> struct scan_control sc = { >> .gfp_mask = GFP_KERNEL, >> .may_writepage = 1, >> @@ -2529,6 +2526,24 @@ unsigned long reclaim_pages(struct list_head *page_list) >> .no_demotion = 1, >> }; >> >> + nr_reclaimed = shrink_page_list(page_list, pgdat, &sc, &dummy_stat, false); >> + while (!list_empty(page_list)) { >> + page = lru_to_page(page_list); >> + list_del(&page->lru); >> + putback_lru_page(page); > > Why wouldn't you use a folio here? > I was just wanting to keep the code consistent with the previous one. Am I supposed to use a folio here ? If so, will do it in V2. Thanks. > > . >