From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FF35C433F5 for ; Sat, 8 Jan 2022 10:24:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 079C36B0072; Sat, 8 Jan 2022 05:24:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 029246B0073; Sat, 8 Jan 2022 05:24:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E32B26B0074; Sat, 8 Jan 2022 05:24:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0229.hostedemail.com [216.40.44.229]) by kanga.kvack.org (Postfix) with ESMTP id D0DAC6B0072 for ; Sat, 8 Jan 2022 05:24:54 -0500 (EST) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 82DF0181CA77D for ; Sat, 8 Jan 2022 10:24:54 +0000 (UTC) X-FDA: 79006736508.30.0BE24AC Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf14.hostedemail.com (Postfix) with ESMTP id 626C4100007 for ; Sat, 8 Jan 2022 10:24:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1641637493; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iPPO12sw1JDTD0G37wpQg5PEFCtRv8KYfwzslX319+E=; b=DhdtP3fyw2jzgWkna6+U9tXJVegZZUyFSQ73Vb2OBTOFByHw+Bo9FGfa4cefvv0LJfF95W y1VnWdj08NGz4CCcBOCEjCsthxmMiNgu4fc9B+UoYQ/1X0jh83/SFEoHIfReMdCc6u0D8/ wycr/TT/yd1lhbDVdqtWd1hpzRqVR9A= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-255-fz9QJHOgON2auBDupriYuw-1; Sat, 08 Jan 2022 05:24:49 -0500 X-MC-Unique: fz9QJHOgON2auBDupriYuw-1 Received: by mail-ed1-f72.google.com with SMTP id z8-20020a056402274800b003f8580bfb99so6619576edd.11 for ; Sat, 08 Jan 2022 02:24:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=iPPO12sw1JDTD0G37wpQg5PEFCtRv8KYfwzslX319+E=; b=tZ4HIVd3HaCnEEDFdjSfvdo57D23G+UBugcnuv2ioVCdJlUAoNWdJzRzGnuKxj6B/x mYjOZo8fJ8nmiYO3BCbymap5Il+/xfXum4pDDZQ7+KjflZpqtta8qfaMNFVUUNdUMEvK 5rEaCyB67g9eEU5lGBrAvMwFOE7H+rqEvEKoCWo7gKfsvLz6zgv0G6CDMcmvscx9t2ew Dl+Lvp8Rf4hQrUbqCh3aWLz3yHoIrGXX/LJp07rpOAsJL2jn1IDgM7KiSFntITB4QFrp oCOEp3uXk7PgPJl4KpohM5KbBiCC/web+D+Ku6YofytZWMS3432vr8DOdDaEpcN13JHM TC2Q== X-Gm-Message-State: AOAM532RDq7S6rey5yY8NOQi0eS93X5KXDOFt/g6s6N3ngAVLZNexSCC Itja++ClBSOxEmEGaQ6Q5lOWA9sHNXtpPiy3IQqLrWV5d4Hwg6eAaN6v17U33QdbfrnpxMLd+U8 uON9ZI+W5gg0= X-Received: by 2002:a17:906:a15a:: with SMTP id bu26mr17816463ejb.335.1641637488549; Sat, 08 Jan 2022 02:24:48 -0800 (PST) X-Google-Smtp-Source: ABdhPJzAhWh1NKfACYP0Cn1qZyt0xEa0yfMdtSFEA/CAe4Fj79c/yiiwaYZbVwRtQS9bkIqhud9ftA== X-Received: by 2002:a17:906:a15a:: with SMTP id bu26mr17816451ejb.335.1641637488322; Sat, 08 Jan 2022 02:24:48 -0800 (PST) Received: from ?IPV6:2001:1c00:c1e:bf00:1db8:22d3:1bc9:8ca1? (2001-1c00-0c1e-bf00-1db8-22d3-1bc9-8ca1.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:1db8:22d3:1bc9:8ca1]) by smtp.gmail.com with ESMTPSA id sh11sm401222ejc.17.2022.01.08.02.24.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 08 Jan 2022 02:24:47 -0800 (PST) Message-ID: <487dd7a3-8f29-de9a-2612-65fe895e676f@redhat.com> Date: Sat, 8 Jan 2022 11:24:47 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Subject: Re: [linux-next:master 8287/11475] drivers/platform/x86/thinkpad_acpi.c:9600:9: error: implicit declaration of function 'power_supply_charge_behaviour_show' To: kernel test robot , =?UTF-8?Q?Thomas_Wei=c3=9fschuh?= Cc: kbuild-all@lists.01.org, Linux Memory Management List , Thomas Koch , =?UTF-8?Q?Nicol=c3=b2_Piazzalunga?= References: <202201080424.U284YcVw-lkp@intel.com> From: Hans de Goede In-Reply-To: <202201080424.U284YcVw-lkp@intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 626C4100007 X-Stat-Signature: tmnhxmiw3aor9hzkjwr8k3onq7155e3a Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=DhdtP3fy; spf=none (imf14.hostedemail.com: domain of hdegoede@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=hdegoede@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-HE-Tag: 1641637493-423860 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi, On 1/7/22 21:08, kernel test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > head: b8170452cd5121b11a5726e3ea8dbdfc2d74e771 > commit: b55d416d48f5907f66218ae3d878e3bfb69ae4e6 [8287/11475] platform/x86: thinkpad_acpi: support force-discharge > config: x86_64-buildonly-randconfig-r005-20220107 (https://download.01.org/0day-ci/archive/20220108/202201080424.U284YcVw-lkp@intel.com/config) > compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 > reproduce (this is a W=1 build): > # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=b55d416d48f5907f66218ae3d878e3bfb69ae4e6 > git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git > git fetch --no-tags linux-next master > git checkout b55d416d48f5907f66218ae3d878e3bfb69ae4e6 > # save the config file to linux build tree > mkdir build_dir > make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/platform/x86/ > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > > All errors (new ones prefixed by >>): > > drivers/platform/x86/thinkpad_acpi.c: In function 'charge_behaviour_show': >>> drivers/platform/x86/thinkpad_acpi.c:9600:9: error: implicit declaration of function 'power_supply_charge_behaviour_show' [-Werror=implicit-function-declaration] > 9600 | return power_supply_charge_behaviour_show(dev, available, active, buf); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > drivers/platform/x86/thinkpad_acpi.c: In function 'charge_behaviour_store': >>> drivers/platform/x86/thinkpad_acpi.c:9627:13: error: implicit declaration of function 'power_supply_charge_behaviour_parse' [-Werror=implicit-function-declaration] > 9627 | selected = power_supply_charge_behaviour_parse(available, buf); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > cc1: some warnings being treated as errors Ok, so this is caused by the config used by this test having the following: # CONFIG_SYSFS is not set Thomas, can you do a patch adding static inline stubs for these 2 functions to include/linux/power_supply.h ? Like it is done for the: power_supply_add_hwmon_sysfs() power_supply_remove_hwmon_sysfs() Just above the declaration of these 2 functions. Regards, Hans