Re: [linux-next:master 8287/11475] drivers/platform/x86/thinkpad_acpi.c:9600:9: error: implicit declaration of function 'power_supply_charge_behaviour_show'

[Hans de Goede <hdegoede@redhat.com>]

Hi,

On 1/7/22 21:08, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head:   b8170452cd5121b11a5726e3ea8dbdfc2d74e771
> commit: b55d416d48f5907f66218ae3d878e3bfb69ae4e6 [8287/11475] platform/x86: thinkpad_acpi: support force-discharge
> config: x86_64-buildonly-randconfig-r005-20220107 (https://download.01.org/0day-ci/archive/20220108/202201080424.U284YcVw-lkp@intel.com/config)
> compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
> reproduce (this is a W=1 build):
>         # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=b55d416d48f5907f66218ae3d878e3bfb69ae4e6
>         git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
>         git fetch --no-tags linux-next master
>         git checkout b55d416d48f5907f66218ae3d878e3bfb69ae4e6
>         # save the config file to linux build tree
>         mkdir build_dir
>         make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/platform/x86/
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> 
> All errors (new ones prefixed by >>):
> 
>    drivers/platform/x86/thinkpad_acpi.c: In function 'charge_behaviour_show':
>>> drivers/platform/x86/thinkpad_acpi.c:9600:9: error: implicit declaration of function 'power_supply_charge_behaviour_show' [-Werror=implicit-function-declaration]
>     9600 |  return power_supply_charge_behaviour_show(dev, available, active, buf);
>          |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>    drivers/platform/x86/thinkpad_acpi.c: In function 'charge_behaviour_store':
>>> drivers/platform/x86/thinkpad_acpi.c:9627:13: error: implicit declaration of function 'power_supply_charge_behaviour_parse' [-Werror=implicit-function-declaration]
>     9627 |  selected = power_supply_charge_behaviour_parse(available, buf);
>          |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>    cc1: some warnings being treated as errors


Ok, so this is caused by the config used by this test having the following:

# CONFIG_SYSFS is not set

Thomas, can you do a patch adding static inline stubs for these 2 functions
to include/linux/power_supply.h ? Like it is done for the:

power_supply_add_hwmon_sysfs()
power_supply_remove_hwmon_sysfs()

Just above the declaration of these 2 functions.

Regards,

Hans