linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Chris Snook <csnook@redhat.com>
To: Rik van Riel <riel@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Eric Rannaud <eric.rannaud@gmail.com>,
	linux-kernel@vger.kernel.org, linux-mm <linux-mm@kvack.org>
Subject: Re: madvise(2) MADV_SEQUENTIAL behavior
Date: Wed, 16 Jul 2008 17:05:14 -0400	[thread overview]
Message-ID: <487E628A.3050207@redhat.com> (raw)
In-Reply-To: <20080716105025.2daf5db2@cuia.bos.redhat.com>

Rik van Riel wrote:
> On Wed, 16 Jul 2008 14:14:55 +0200
> Peter Zijlstra <peterz@infradead.org> wrote:
> 
>> On Tue, 2008-07-15 at 23:03 +0000, Eric Rannaud wrote:
>>> mm/madvise.c and madvise(2) say:
>>>
>>>  *  MADV_SEQUENTIAL - pages in the given range will probably be accessed
>>>  *		once, so they can be aggressively read ahead, and
>>>  *		can be freed soon after they are accessed.
>>>
>>>
>>> But as the sample program at the end of this post shows, and as I
>>> understand the code in mm/filemap.c, MADV_SEQUENTIAL will only increase
>>> the amount of read ahead for the specified page range, but will not
>>> influence the rate at which the pages just read will be freed from
>>> memory.
>> Correct, various attempts have been made to actually implement this, but
>> non made it through.
>>
>> My last attempt was:
>>   http://lkml.org/lkml/2007/7/21/219
>>
>> Rik recently tried something else based on his split-lru series:
>>   http://lkml.org/lkml/2008/7/15/465
> 
> M patch is not going to help with mmap, though.
> 
> I believe that for mmap MADV_SEQUENTIAL, we will have to do
> an unmap-behind from the fault path.  Not every time, but
> maybe once per megabyte, unmapping the megabyte behind us.
> 
> That way the normal page cache policies (use once, etc) can
> take care of page eviction, which should help if the file
> is also in use by another process.
> 

Wouldn't it just be easier to not move pages to the active list when 
they're referenced via an MADV_SEQUENTIAL mapping?  If we keep them on 
the inactive list, they'll be candidates for reclaiming, but they'll 
still be in pagecache when another task scans through, as long as we're 
not under memory pressure.

-- Chris

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2008-07-16 21:05 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1216163022.3443.156.camel@zenigma>
2008-07-16 12:14 ` Peter Zijlstra
2008-07-16 14:50   ` Rik van Riel
2008-07-16 21:05     ` Chris Snook [this message]
2008-07-17  0:01       ` Eric Rannaud
2008-07-17  6:14         ` Nick Piggin
2008-07-17 14:21           ` Rik van Riel
2008-07-17 18:04             ` Chris Snook
2008-07-17 18:09               ` Peter Zijlstra
2008-07-17 14:20       ` Rik van Riel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=487E628A.3050207@redhat.com \
    --to=csnook@redhat.com \
    --cc=eric.rannaud@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=peterz@infradead.org \
    --cc=riel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox