From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <487153B3.80002@garzik.org> Date: Sun, 06 Jul 2008 19:22:27 -0400 From: Jeff Garzik MIME-Version: 1.0 Subject: Re: [bug?] tg3: Failed to load firmware "tigon/tg3_tso.bin" References: <1215178035.10393.763.camel@pmac.infradead.org> <486E2818.1060003@garzik.org> <20080704142753.27848ff8@lxorguk.ukuu.org.uk> <20080704.134329.209642254.davem@davemloft.net> <20080704220444.011e7e61@lxorguk.ukuu.org.uk> <1215376034.3189.127.camel@shinybook.infradead.org> <1215377814.3189.137.camel@shinybook.infradead.org> <48713B73.6030708@garzik.org> <1215382225.3189.174.camel@shinybook.infradead.org> In-Reply-To: <1215382225.3189.174.camel@shinybook.infradead.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: David Woodhouse Cc: david@lang.hm, Alan Cox , David Miller , andi@firstfloor.org, tytso@mit.edu, hugh@veritas.com, akpm@linux-foundation.org, kosaki.motohiro@jp.fujitsu.com, mchan@broadcom.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org List-ID: David Woodhouse wrote: > On Sun, 2008-07-06 at 17:38 -0400, Jeff Garzik wrote: >> David Woodhouse wrote: >>> On Sun, 2008-07-06 at 13:52 -0700, david@lang.hm wrote: >>>> On Sun, 6 Jul 2008, David Woodhouse wrote: >>>> >>>>> On Sun, 2008-07-06 at 13:17 -0700, david@lang.hm wrote: >>>>>> if David W were to make it possible to not use the load_firmware() call to >>>>>> userspace and build the firmware into the driver (be it in a monolithic >>>>>> kernel or the module that contains the driver) >>>>> You _can_ build the firmware into the kernel. >>>> right, but not into a module. you have half of the answer in place, but >>>> not all of it. >>> The useful half. If you have userspace to load modules, you have >>> userspace to load firmware too. >> Existing examples have already been provided where this logic fails. > > I even provided such an example, where your script greps the module for > 'request_firmware' and fails if there's a match. I don't think any of > the other provided examples were _much_ more sensible than that... That makes the false presumption that scripts have been updated to avoid the obvious case -- non-working drivers. Why is it so difficult to follow a simple principle: Keep things working tomorrow, that work today. hmmm? That's how kernel module support was integrated, so many years ago. Jeff -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org