From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F17A2C77B7F for ; Thu, 27 Apr 2023 00:58:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7640A6B0071; Wed, 26 Apr 2023 20:58:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 713CB6B0072; Wed, 26 Apr 2023 20:58:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 602E96B0074; Wed, 26 Apr 2023 20:58:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 510DF6B0071 for ; Wed, 26 Apr 2023 20:58:06 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 0983E402F2 for ; Thu, 27 Apr 2023 00:58:06 +0000 (UTC) X-FDA: 80725359372.12.84A0F4B Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf20.hostedemail.com (Postfix) with ESMTP id 8B0DE1C0012 for ; Thu, 27 Apr 2023 00:58:03 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=none; spf=pass (imf20.hostedemail.com: domain of linyunsheng@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linyunsheng@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682557084; a=rsa-sha256; cv=none; b=D6XnVJR4VIouyYm6GW8BO9XrhrsUssYsJRKDg7wOWZyDRwKH8bUU3QF47YwBb+zmYIum2K wbQB2A2z+5U5t0yZWN21byKIJtO4l2JLWm8ZiYa+Q8OEXm/W8f7kYIjGlvJ4+w64bY+3+l Ccq32RhcHy9aQP6ZPt+ooQ1oQCODDf8= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=none; spf=pass (imf20.hostedemail.com: domain of linyunsheng@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linyunsheng@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682557084; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YuMWqCG+kKJPWLaDdqD/pnXXDMBSHtfUGJQwJ6NDcnE=; b=RfAva/MWwyKq9rHkiUcWsbPLcUUJTzVTwJv3+FwUnG4MuG1If4ggm8o2L5M2sM2T8Kj9Xe LV7399E8RzPGEOhiYMER2XwQ3jWqq8hZrDPl/q1e4w7I3FaLG93AyNiLSz1B+p6eDfC2DQ fPYahHPo27CHJmGIZRya07yvfGfUYPs= Received: from dggpemm500005.china.huawei.com (unknown [172.30.72.54]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4Q6HP0262szsR8d; Thu, 27 Apr 2023 08:56:20 +0800 (CST) Received: from [10.69.30.204] (10.69.30.204) by dggpemm500005.china.huawei.com (7.185.36.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 27 Apr 2023 08:57:58 +0800 Subject: Re: [PATCH RFC net-next/mm V1 1/3] page_pool: Remove workqueue in new shutdown scheme To: Jesper Dangaard Brouer , Ilias Apalodimas , , Eric Dumazet , , Mel Gorman CC: , =?UTF-8?Q?Toke_H=c3=b8iland-J=c3=b8rgensen?= , , "David S. Miller" , Jakub Kicinski , Paolo Abeni , Andrew Morton , References: <168244288038.1741095.1092368365531131826.stgit@firesoul> <168244293875.1741095.10502498932946558516.stgit@firesoul> From: Yunsheng Lin Message-ID: <48661b51-1cbb-e3e0-a909-6d0a1532733a@huawei.com> Date: Thu, 27 Apr 2023 08:57:58 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: <168244293875.1741095.10502498932946558516.stgit@firesoul> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.69.30.204] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpemm500005.china.huawei.com (7.185.36.74) X-CFilter-Loop: Reflected X-Rspam-User: X-Rspamd-Queue-Id: 8B0DE1C0012 X-Rspamd-Server: rspam01 X-Stat-Signature: h1ipg9d8tz4i73jdme59wufnfa7y5aug X-HE-Tag: 1682557083-326682 X-HE-Meta: U2FsdGVkX19iiyN3uLR5v7U7402L8XpKckpsrnJnv0HXORphnqRd4nwIORh/NQBtHpj3aUFpoCExNugOPesRvVeGgigbldyQcmN2y9Z1X5B/AY98kXZqFD2CumU+C9qBK36yCYy+3IDQLNDp4jtBmSS6F0h6BQyaONkXVVe4RHlgIBbbAFlbT69LucIxeIMGYfR0FOcSKQIjvHSSjsakhY/wYaJSaVvp0OOl6HuDPLOD3OSY7rn5K994XecGju53NJMLijXZ6FPk68ejPvIrW9IQeX8CbiqRu+ldNEKqFlYdYj7KsWrCfbUmNt0SeVBFOVYIX/TnlLqDJlilgtdWTPIDF/8ZYp8Q3ojKw8kr4/TVyUIJ0/hqWpNDn5MOXsEWi8aRleHj9jxMQAVLHN9K67IK+RDHZoxCwFSBQNu2SgMNW8K2hCK1D5brmw+6P/gga/LhxYtBT5KAMejYBxRQm1LtT4Uaqf34yLQrrtOxSImClXSHo+xIB/eEZFtswg57hbOA4V41DTPS4iNM3hXS86HK7F0wmtXhbQbY7rVfQOBgp0PZpmCoxlrNjOZ5HTpmX0SxZt7UxI2pCM3RGZkOmFlZ+GYbgW2vwgHkR5Fxxwzk75Sj0VAASXvLCG7pzt2pwHItABxX0+lOH/7L4khHZRcQu8FR9xgzluGzCT4QDp73i/+y6gfe+TsC9U/tI/5Bom2TjyIS1Fddj0t2AwtdScNovqC4f7tj1R1ONCvPyCbjY1TY+bph+qu27jBEbUpcMYn1LMeDk4k+zaRD2k962GsqMe2+hyTRqOw6fbVHXqAy9MqyUd/dvEtKfhXLahJUlEoc232d3oOh3wx+BDel73bY2oS2bIwRu+ST2ZxU6Xy7oFiZcxG6GA14X7SnBGZxA/5SCyGr5YNWB3vbyI4SIE1NCrQvd/ymQEVLSTn5QoMZhRsdEzTYHSjfs+AnN9kNBVBzURyKCC4WDI7kf9r iCegaAf2 xFgi4OefUi4NGqmXuM+32lkJ7nh1/rzVSNwM2eDmR2zTcZiK0LlX8tzw2VWTbs9Ysa/7UyAjVenqMzQ5QYg6D+BnDU2UsH62aNghHZIYNjcoYEHx1zGNJyjZQ5nRbH/0h1sWTMgzBKn54ilfKF1PNsTRyBHv22z8G5FyEgUHW6jicpuomWSBRjJ9fA5Dyho4qZ6s2Ny4hsaDPXFa9EIuP9LQwG9D8pNqsl1kSpibgsy0o8AqT3P17lMEkajPhFRDy/e3dK4TVi27FR5DlUzbpjny5hegilIEA+F6zZal0TJkgQkPegf+7O2e4pA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/4/26 1:15, Jesper Dangaard Brouer wrote: > @@ -609,6 +609,8 @@ void page_pool_put_defragged_page(struct page_pool *pool, struct page *page, > recycle_stat_inc(pool, ring_full); > page_pool_return_page(pool, page); > } > + if (pool->p.flags & PP_FLAG_SHUTDOWN) > + page_pool_shutdown_attempt(pool); It seems we have allowed page_pool_shutdown_attempt() to be called concurrently here, isn't there a time window between atomic_inc_return_relaxed() and page_pool_inflight() for pool->pages_state_release_cnt, which may cause double calling of page_pool_free()?