From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E15CAC07E9D for ; Mon, 26 Sep 2022 08:32:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4D0BD8E002F; Mon, 26 Sep 2022 04:32:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4598B8E0007; Mon, 26 Sep 2022 04:32:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2F9F38E002F; Mon, 26 Sep 2022 04:32:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 1BEA08E0007 for ; Mon, 26 Sep 2022 04:32:51 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id DFA328018F for ; Mon, 26 Sep 2022 08:32:50 +0000 (UTC) X-FDA: 79953570900.15.97ED375 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf28.hostedemail.com (Postfix) with ESMTP id 9697DC0016 for ; Mon, 26 Sep 2022 08:32:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1664181170; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2ZGYtOLY3FItcJklTsztDmIawuiBAYb+rnQ59of1z3Y=; b=NLNSCarC+/bPrBR9pFoylnsGsZv4XN49oEZbjR0+iVvbPiUqTTigQaGr6qq990VIpd3Y6N 4/Ss5QECl8S+qpyIIe7Gf445Pz0rP7fNRpILgR0Q5GMFl+Z/MMJ+e8flQ1acSF16QcxY6j 1kTmPN2wAGQB5hBQlUUuLOhNvJm127w= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-170-KiIgTF74MFWbzXV2F-NuXw-1; Mon, 26 Sep 2022 04:32:48 -0400 X-MC-Unique: KiIgTF74MFWbzXV2F-NuXw-1 Received: by mail-wm1-f72.google.com with SMTP id d5-20020a05600c34c500b003b4fb42ccdeso6694009wmq.8 for ; Mon, 26 Sep 2022 01:32:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date; bh=2ZGYtOLY3FItcJklTsztDmIawuiBAYb+rnQ59of1z3Y=; b=1CNgeuo/lULfWeBz8j/SWny1Cfn1kZ4oyCIG7usSP4Syx5p1dwgtiWUwzTDfZgseJZ hRiugXaNJuFZQ0zpPFmJakfcqKz9Oo6xMdg4HbdPrmrGc7YiuWb+uVAefPWTXt3FPyds wEzK0JdHpyfjwK14lhnriBRIrAm5fy/pFgpcuzdeNeGKvQffGTnijRzVPBjizmg2ZVFZ gTjjetYcdArE8H55gxpP4qMkEPGrBBd2OExXot0CUQx7u9O93YmAu3SyOO1p4nGzTSku zCLPWi7j91Fb0ZHeo/wHC7kP1sOI0JclK909D7kNRkZGaLG1hzzK8UqlnMUT6uXYz7xr Z79Q== X-Gm-Message-State: ACrzQf2fsWu2VKwTqNCzGlsruGgRZ/reHfsCAdfAPgbEilqGoNFx6BV+ rA5rrj/yyMRVevOLeVFuvCDsWqC3rkNFAhqIwFmfQwlmed9yTw9764JAA5RGJiSmM9e323xTgS+ HKv/dOO59KsQ= X-Received: by 2002:a7b:ce97:0:b0:3b3:4136:59fe with SMTP id q23-20020a7bce97000000b003b3413659femr14230796wmj.24.1664181167081; Mon, 26 Sep 2022 01:32:47 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5r+QgKNI1zWUxSeUKHpaNiNk/Wrai0XDoRmaIxA2kk5MN5p5JzGTH0lcnJ0escKeEkpByYlQ== X-Received: by 2002:a7b:ce97:0:b0:3b3:4136:59fe with SMTP id q23-20020a7bce97000000b003b3413659femr14230772wmj.24.1664181166762; Mon, 26 Sep 2022 01:32:46 -0700 (PDT) Received: from ?IPV6:2003:cb:c703:4b00:e090:7fa6:b7d6:d4a7? (p200300cbc7034b00e0907fa6b7d6d4a7.dip0.t-ipconnect.de. [2003:cb:c703:4b00:e090:7fa6:b7d6:d4a7]) by smtp.gmail.com with ESMTPSA id m13-20020a05600c3b0d00b003a2e92edeccsm11212861wms.46.2022.09.26.01.32.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Sep 2022 01:32:46 -0700 (PDT) Message-ID: <48590f80-fc58-bf67-5acf-082880a607b2@redhat.com> Date: Mon, 26 Sep 2022 10:32:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH] mm: fix misuse of update_mmu_cache() in do_anonymous_page() To: Muchun Song , Qi Zheng Cc: Andrew Morton , Linux MM , linux-kernel@vger.kernel.org, chris@zankel.net, jcmvbkbc@gmail.com, maobibo@loongson.cn References: <20220924053239.91661-1-zhengqi.arch@bytedance.com> <3A09E40A-E2C5-4C6F-8550-DD0E17B7DAB9@linux.dev> From: David Hildenbrand Organization: Red Hat In-Reply-To: <3A09E40A-E2C5-4C6F-8550-DD0E17B7DAB9@linux.dev> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NLNSCarC; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1664181170; a=rsa-sha256; cv=none; b=LMoAjua0ywqIVm2ba9yipz9SPl1JbvxBj21sC1nWnHJfWoeAIGeUhL0Ob2aebTrgNZwd+t EbSYy+gdP+23w9DUj4tRCJkw3nhDsra1l2ej6LVUuXLw+NhDNMsbbrRaqsNwHAWtJhb8OX S5S2KkUe8y9LXkAxBqEQ1ZynTsIHRrA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1664181170; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2ZGYtOLY3FItcJklTsztDmIawuiBAYb+rnQ59of1z3Y=; b=7+ONgyfvj4fyCrDX0zZUcQqr/FBrZSI0wJRfFxqxKZtHHxYZwgmx0Sas9wHTTKh5hSUPQN L8Bnvnf8VVYoyumGHyuB6/jQ3Zt0AmMyq1KF2InxUZYe23dAfXV50AP2IM0KyPy+dqutnu qCwRcxHpA8XJK+onzjHBqZm5ox0+Okk= Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NLNSCarC; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Stat-Signature: buibn8gn89ycmceqq6dxt9jffa95cb3w X-Rspamd-Queue-Id: 9697DC0016 X-Rspamd-Server: rspam12 X-Rspam-User: X-HE-Tag: 1664181170-328813 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 25.09.22 03:43, Muchun Song wrote: > > >> On Sep 24, 2022, at 13:32, Qi Zheng wrote: >> >> As message in commit 7df676974359 ("mm/memory.c: Update local TLB >> if PTE entry exists") said, we should update local TLB only on the >> second thread. So fix the misuse of update_mmu_cache() by using >> update_mmu_tlb() in the do_anonymous_page(). >> >> Signed-off-by: Qi Zheng > > The change looks good to me. However, I am not sure what is the user-visible > effect to xtensa users. So Cc xtensa’s maintainer and the author of 7df676974359 > to double check this. And if there is one, do we have a fixes tag? -- Thanks, David / dhildenb