From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5C06C25B6D for ; Wed, 25 Oct 2023 14:53:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 525736B0327; Wed, 25 Oct 2023 10:53:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4D60C6B0329; Wed, 25 Oct 2023 10:53:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3C47D6B032B; Wed, 25 Oct 2023 10:53:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 2CE7E6B0327 for ; Wed, 25 Oct 2023 10:53:30 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 06B95140707 for ; Wed, 25 Oct 2023 14:53:30 +0000 (UTC) X-FDA: 81384277380.04.F5CB207 Received: from smtpout.efficios.com (smtpout.efficios.com [167.114.26.122]) by imf15.hostedemail.com (Postfix) with ESMTP id 21449A0004 for ; Wed, 25 Oct 2023 14:53:27 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=efficios.com header.s=smtpout1 header.b="XAd/nMlB"; dmarc=pass (policy=none) header.from=efficios.com; spf=pass (imf15.hostedemail.com: domain of mathieu.desnoyers@efficios.com designates 167.114.26.122 as permitted sender) smtp.mailfrom=mathieu.desnoyers@efficios.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698245608; a=rsa-sha256; cv=none; b=wh8ZqcWbIuDy7gx/+q3gnxER3B9R9FYXXFPBEkOdovvFmwd3wTQJidoa/qdV5r7m0T5Cxr PlXhPvWg8Dxv/4B+DCO2HtqkfsIWOymacufb+pFUqsH1qbLI9ngnAlYJFuvnnSn/1+F4fW BPJloUV7J1Hpi+bEnodjLLPQap4pSik= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=efficios.com header.s=smtpout1 header.b="XAd/nMlB"; dmarc=pass (policy=none) header.from=efficios.com; spf=pass (imf15.hostedemail.com: domain of mathieu.desnoyers@efficios.com designates 167.114.26.122 as permitted sender) smtp.mailfrom=mathieu.desnoyers@efficios.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698245608; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=18Y/lYy9OtjpBQhuixW5D624zoamNFAZ4mtQPANBVDk=; b=sX6yWq+10V7yR6GuuWtEStLtEE/hn6mNkJoDuBTRRywKDpTcMpQE8SsvFhW8SQNcMNfr6Z KqqtbKnktiLBoPAOoOfbekOBZkyMXROc6ohf9tPSLwWDDgNzwmG8t9qWPYcEXsbFgjwkSY HSQkblK4q+3dVqX6UOtt/K/zegS+wSY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=efficios.com; s=smtpout1; t=1698245606; bh=me9S70DpiLbb790yThjt8DPX14g2rPC87Y76GX6j2Uw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=XAd/nMlBbaHy4E/vK0HRMBeETjYBBrCvqX/9ky+7CHulrbETkoFDwprjNCFdr/Cpm 8/DMOG7mUCoaH+vjOVoR8r5iOqu1Hx9tzHGWVzrGoe+UvxLvnja1oMwlMdstZc8Nc3 MvRaTy+rHqkkFx6YY5v0LqR8uzzRAzUj0g5j4TI/XjnAyIq9esXjiuVjhH4N5WOeW/ fAq8sgTH+Pvgrhxnxb84oAfZR9yRWkMW/qGmWnoQtIbYpLoHoGF7pJcgr1LhSu+nfy qZX0A0Iz6XCWh8C7mJ0Gzvpe6BjcVY6Th0tGSbchxr5KpbQ1JjBgcxfpp0zRWo/GK8 +7WFIgtbZ31KQ== Received: from [172.16.0.134] (192-222-143-198.qc.cable.ebox.net [192.222.143.198]) by smtpout.efficios.com (Postfix) with ESMTPSA id 4SFsPK0WyBz1YyS; Wed, 25 Oct 2023 10:53:25 -0400 (EDT) Message-ID: <48573a20-19d9-4400-a35e-86bf3dc043ad@efficios.com> Date: Wed, 25 Oct 2023 10:53:38 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [POC][RFC][PATCH] sched: Extended Scheduler Time Slice Content-Language: en-US To: Steven Rostedt , Peter Zijlstra Cc: LKML , Thomas Gleixner , Ankur Arora , Linus Torvalds , linux-mm@kvack.org, x86@kernel.org, akpm@linux-foundation.org, luto@kernel.org, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, mingo@redhat.com, juri.lelli@redhat.com, vincent.guittot@linaro.org, willy@infradead.org, mgorman@suse.de, jon.grimm@amd.com, bharata@amd.com, raghavendra.kt@amd.com, boris.ostrovsky@oracle.com, konrad.wilk@oracle.com, jgross@suse.com, andrew.cooper3@citrix.com, Joel Fernandes , Youssef Esmat , Vineeth Pillai , Suleiman Souhlal , Ingo Molnar , Daniel Bristot de Oliveira References: <20231025054219.1acaa3dd@gandalf.local.home> <20231025102952.GG37471@noisy.programming.kicks-ass.net> <20231025085434.35d5f9e0@gandalf.local.home> <20231025135545.GG31201@noisy.programming.kicks-ass.net> <20231025103105.5ec64b89@gandalf.local.home> From: Mathieu Desnoyers In-Reply-To: <20231025103105.5ec64b89@gandalf.local.home> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 21449A0004 X-Stat-Signature: ti66rgpqu97jixknymboihqkhqzwrtsn X-HE-Tag: 1698245607-902208 X-HE-Meta: U2FsdGVkX18coIRHSJB3jVIgwTp7Si/AMZ3DOY5Xuiwp0coEYgNBtFxMPz9ckJDoNE6fKALghUCFM69sewtuJorZH6NlTFj+r4JCRKmf7CQWzZ1u2AX1IbeIZGMo0mZHDUo4kUf0whE0/OrpJeeNV/featlNN21SHQ6s5Fvs4AHlVgkhQH4ze1473kY2STLRow/fAA/4dyOx6R4z5gE3gbIdAmjElLajKdz9e8x0SG1bksqOvZZ+oLXVpp3QmkWX9pcDdF8DsgZiuDI++JbHJf+KPvaOYeGVOvfR0POrbnyfQWH2eQjiV/MW9AFXtJkZ5ueXesfXMCYUkLTMhRFJviZ3gcnSCagq730MCrE3kXCCCBBtgwJzOJlq/1whSKc9VmKiGVf4C1uU3KOIB6+hAJkJatbX3CVhpYwMDSBoOcP95OTjASgGapGBCxsth6HFVbl1aX6oH/WBRU1PE/DwGO4nnJpD/+wGZ7ndd4RK+eRI37pi3+bYYm4xB7omTCTZU7ro4v7Ca6X1FD+igYrYZQW5H4LhkHd4DgupZWEC5eVySM3HS/DcgA3w/LFv92NTBQBiobiiMokxLl6oX0PwngvcZh8s8A+VtShEhc4BT08o6zAGhhSIEBGQ5lIXC5ssNsNwi+B72p3gdN2AOLfxvCS+4D6bSqmlIdqP64lG0ZIRzA4AoWeINkWZ/3dxrWh3s9D4yqntc3rTRlsawWe90Fb0hWOqHY9MTvTuQjG7HEx8WtBs1M9cssQvVSEzWjvkzsu63aKNuvuLmY5yRw42XaT+sb+WXjWbxMGmo+Quj0RstJYySFGLN3de13Jp0NyuST634aIilUlh1s1TWS6HzDFiBmR0Jx+CZWRBYX+AATccxerENadg9no74iuto7ThURYUBmx3dpi/bmvr8i68U8vgX45dNZLBEHTaq7QjnvCY5QQSAmSNXBC6LKk5zJ9CseU88Y9Rg9BLfZsOEzj s7q84Qgc j/CEF1qGINfmkL4Taeq0T8Jd9QkPZW6np39McKFwOkSCjB4/dZCBfZU3em5PlLBkuR4DPnXREqf3acOTTTds9bkFRyuCjqmi8K83lQaJY7oRvdqZjA3jxHMGx986SuEx+RIsgKxorCOwa1WRI+cjXtMZ+SZ4Z0ETjUWvi4d+mhGq8ewz9aQIHp/CMBbGDYPMda5WgiBTrSJRu502Mxkjq+4+/JPt3Tb+YD/LnoR60VUcFbYwbr1M7YNc+4e5fTUGD3GrJBaHpq4BRoyJzWo7T+722bhEuv0JhheZ3Q4FeeeWM+Ni1pjTuRlXz/sb5kh3t9ubICqbBJiwTcYg8JFWjyxLtT9cLaikklxeprwZyz+SyLn4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2023-10-25 10:31, Steven Rostedt wrote: > On Wed, 25 Oct 2023 15:55:45 +0200 > Peter Zijlstra wrote: > >> On Wed, Oct 25, 2023 at 08:54:34AM -0400, Steven Rostedt wrote: >> >>> I didn't want to overload that for something completely different. This is >>> not a "restartable sequence". >> >> Your hack is arguably worse. At least rseq already exists and most >> threads will already have it set up if you have a recent enough glibc. > > I don't expect that file to be the final solution. I can look at the rseq > code, but I really hate to overload that. I'm thinking perhaps another > system call, or what the hell, add another ioctl like feature to prctl()! > Actually, prctl() may be the proper place for this. > I don't have an informed opinion on whether the proposed heuristic is a good idea or not, but it should definitely be implemented as an extension to rseq as suggested by Peter. I've even made the whole rseq ABI extensible to accommodate those additional use-cases. In the initial rounds of rseq implementation, I even called rseq "kTLS" because I expected it to be extended and eventually become an ABI that contains various per-thread fields which are shared between kernel and userspace. So don't let the specific naming of the rseq system call stop you from extending it for other purposes when per-thread shared memory between kernel and userspace is needed. Setting up various per-thread areas like this on thread creation is not free: it requires additional system calls on thread creation. It really makes no sense to have more than one. Thanks, Mathieu -- Mathieu Desnoyers EfficiOS Inc. https://www.efficios.com