From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua0-f197.google.com (mail-ua0-f197.google.com [209.85.217.197]) by kanga.kvack.org (Postfix) with ESMTP id AD2A36B0038 for ; Thu, 1 Sep 2016 13:32:53 -0400 (EDT) Received: by mail-ua0-f197.google.com with SMTP id j4so190835885uaj.2 for ; Thu, 01 Sep 2016 10:32:53 -0700 (PDT) Received: from sandeen.net (sandeen.net. [63.231.237.45]) by mx.google.com with ESMTP id o14si21068694itb.13.2016.09.01.10.32.52 for ; Thu, 01 Sep 2016 10:32:52 -0700 (PDT) Subject: Re: [PATCH] fs:Fix kmemleak leak warning in getname_flags about working on unitialized memory References: <1470260896-31767-1-git-send-email-xerofoify@gmail.com> <20160804135712.GK2356@ZenIV.linux.org.uk> <20160901171637.GO2356@ZenIV.linux.org.uk> From: Eric Sandeen Message-ID: <4856a8c0-890d-da93-510d-d177b9133eb5@sandeen.net> Date: Thu, 1 Sep 2016 12:32:51 -0500 MIME-Version: 1.0 In-Reply-To: <20160901171637.GO2356@ZenIV.linux.org.uk> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: owner-linux-mm@kvack.org List-ID: To: Al Viro Cc: Tetsuo Handa , akpm@linux-foundation.org, msalter@redhat.com, kuleshovmail@gmail.com, david.vrabel@citrix.com, vbabka@suse.cz, ard.biesheuvel@linaro.org, jgross@suse.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org On 9/1/16 12:16 PM, Al Viro wrote: > On Thu, Sep 01, 2016 at 08:10:44AM -0500, Eric Sandeen wrote: >> On 8/4/16 8:57 AM, Al Viro wrote: >> >>> Don't feed the troll. On all paths leading to that place we have >>> result->name = kname; >>> len = strncpy_from_user(kname, filename, EMBEDDED_NAME_MAX); >>> or >>> result->name = kname; >>> len = strncpy_from_user(kname, filename, PATH_MAX); >>> with failure exits taken if strncpy_from_user() returns an error, which means >>> that the damn thing has already been copied into. >>> >>> FWIW, it looks a lot like buggered kmemcheck; as usual, he can't be bothered >>> to mention which kernel version would it be (let alone how to reproduce it >>> on the kernel in question), but IIRC davej had run into some instrumentation >>> breakage lately. >> >> The original report is in https://bugzilla.kernel.org/show_bug.cgi?id=120651 >> if anyone is interested in it. > > What the hell does that one have to getname_flags(), other than having > attracted the same... something on the edge of failing the Turing Test? Sigh, pasted the wrong one, thus making things worse. I suppose reverse-engineering Nick is a fool's errand, only adding to the noise, sorry. I'll stop. ;) -Eric -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org