From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B43AAC02181 for ; Thu, 23 Jan 2025 01:45:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1B2F46B0082; Wed, 22 Jan 2025 20:45:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1634A6B0083; Wed, 22 Jan 2025 20:45:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 02A676B0085; Wed, 22 Jan 2025 20:45:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D805C6B0082 for ; Wed, 22 Jan 2025 20:45:35 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 4E6851607CD for ; Thu, 23 Jan 2025 01:45:35 +0000 (UTC) X-FDA: 83037024630.12.062DA1B Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) by imf03.hostedemail.com (Postfix) with ESMTP id 9008A20004 for ; Thu, 23 Jan 2025 01:45:33 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf03.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737596733; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OT07u/2EV7eEzntyy26Zt5bLR4l1dj3hYJ+5xRqIegs=; b=c+i5+c2rXxtJivLukV9UJmDb0iRV1zBTxbwGlWnElKQkA3BMdoM7ulu/J/DxKyrTYmYKZE 8dDa7By8HaFCbWJV7MD4TUWd2B45iE+BvLnJyvXezucVp+qEGwqcx1AtM9TMrS05dcDN/m qqTS/yH0llZA0yaZRGcatwPKyiU7Gjk= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf03.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737596733; a=rsa-sha256; cv=none; b=51hG1eA4jVPeD/F0BJForb023W+r4Vwb4zDmIB8+hM6xgwclMAKZY3hE8/q13HB4KoN5sk GFvJdz/FzRJohXerJ3j9pt+Ahu+2Bhgx9JuE5J1ZxUxM6zAonZjrSJEBxhZCXYQgp7e+B6 h88MZL/aHayMPf3z6QUWi4IzxZ9CoZ8= Received: from fangorn.home.surriel.com ([10.0.13.7]) by shelob.surriel.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.97.1) (envelope-from ) id 1tamCy-0000000046P-47Xn; Wed, 22 Jan 2025 20:40:37 -0500 Message-ID: <48566857457796507d57ae0fb19fda16f6c3e8c6.camel@surriel.com> Subject: Re: [PATCH v6 09/12] x86/mm: enable broadcast TLB invalidation for multi-threaded processes From: Rik van Riel To: Peter Zijlstra Cc: x86@kernel.org, linux-kernel@vger.kernel.org, bp@alien8.de, dave.hansen@linux.intel.com, zhengqi.arch@bytedance.com, nadav.amit@gmail.com, thomas.lendacky@amd.com, kernel-team@meta.com, linux-mm@kvack.org, akpm@linux-foundation.org, jannh@google.com, mhklinux@outlook.com, andrew.cooper3@citrix.com Date: Wed, 22 Jan 2025 20:40:36 -0500 In-Reply-To: <20250121103333.GA7145@noisy.programming.kicks-ass.net> References: <20250120024104.1924753-1-riel@surriel.com> <20250120024104.1924753-10-riel@surriel.com> <20250121095507.GB5388@noisy.programming.kicks-ass.net> <20250121103333.GA7145@noisy.programming.kicks-ass.net> Autocrypt: addr=riel@surriel.com; prefer-encrypt=mutual; keydata=mQENBFIt3aUBCADCK0LicyCYyMa0E1lodCDUBf6G+6C5UXKG1jEYwQu49cc/gUBTTk33A eo2hjn4JinVaPF3zfZprnKMEGGv4dHvEOCPWiNhlz5RtqH3SKJllq2dpeMS9RqbMvDA36rlJIIo47 Z/nl6IA8MDhSqyqdnTY8z7LnQHqq16jAqwo7Ll9qALXz4yG1ZdSCmo80VPetBZZPw7WMjo+1hByv/ lvdFnLfiQ52tayuuC1r9x2qZ/SYWd2M4p/f5CLmvG9UcnkbYFsKWz8bwOBWKg1PQcaYHLx06sHGdY dIDaeVvkIfMFwAprSo5EFU+aes2VB2ZjugOTbkkW2aPSWTRsBhPHhV6dABEBAAG0HlJpayB2YW4gU mllbCA8cmllbEByZWRoYXQuY29tPokBHwQwAQIACQUCW5LcVgIdIAAKCRDOed6ShMTeg05SB/986o gEgdq4byrtaBQKFg5LWfd8e+h+QzLOg/T8mSS3dJzFXe5JBOfvYg7Bj47xXi9I5sM+I9Lu9+1XVb/ r2rGJrU1DwA09TnmyFtK76bgMF0sBEh1ECILYNQTEIemzNFwOWLZZlEhZFRJsZyX+mtEp/WQIygHV WjwuP69VJw+fPQvLOGn4j8W9QXuvhha7u1QJ7mYx4dLGHrZlHdwDsqpvWsW+3rsIqs1BBe5/Itz9o 6y9gLNtQzwmSDioV8KhF85VmYInslhv5tUtMEppfdTLyX4SUKh8ftNIVmH9mXyRCZclSoa6IMd635 Jq1Pj2/Lp64tOzSvN5Y9zaiCc5FucXtB9SaWsgdmFuIFJpZWwgPHJpZWxAc3VycmllbC5jb20+iQE +BBMBAgAoBQJSLd2lAhsjBQkSzAMABgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAAKCRDOed6ShMTe g4PpB/0ZivKYFt0LaB22ssWUrBoeNWCP1NY/lkq2QbPhR3agLB7ZXI97PF2z/5QD9Fuy/FD/jddPx KRTvFCtHcEzTOcFjBmf52uqgt3U40H9GM++0IM0yHusd9EzlaWsbp09vsAV2DwdqS69x9RPbvE/Ne fO5subhocH76okcF/aQiQ+oj2j6LJZGBJBVigOHg+4zyzdDgKM+jp0bvDI51KQ4XfxV593OhvkS3z 3FPx0CE7l62WhWrieHyBblqvkTYgJ6dq4bsYpqxxGJOkQ47WpEUx6onH+rImWmPJbSYGhwBzTo0Mm G1Nb1qGPG+mTrSmJjDRxrwf1zjmYqQreWVSFEt26tBpSaWsgdmFuIFJpZWwgPHJpZWxAZmIuY29tP okBPgQTAQIAKAUCW5LbiAIbIwUJEswDAAYLCQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQznneko TE3oOUEQgAsrGxjTC1bGtZyuvyQPcXclap11Ogib6rQywGYu6/Mnkbd6hbyY3wpdyQii/cas2S44N cQj8HkGv91JLVE24/Wt0gITPCH3rLVJJDGQxprHTVDs1t1RAbsbp0XTksZPCNWDGYIBo2aHDwErhI omYQ0Xluo1WBtH/UmHgirHvclsou1Ks9jyTxiPyUKRfae7GNOFiX99+ZlB27P3t8CjtSO831Ij0Ip QrfooZ21YVlUKw0Wy6Ll8EyefyrEYSh8KTm8dQj4O7xxvdg865TLeLpho5PwDRF+/mR3qi8CdGbkE c4pYZQO8UDXUN4S+pe0aTeTqlYw8rRHWF9TnvtpcNzZw== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.54.1 (3.54.1-1.fc41) MIME-Version: 1.0 X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 9008A20004 X-Stat-Signature: cfr7qyop6dnsgf9ze6frgxzpnq4gu1yk X-Rspam-User: X-HE-Tag: 1737596733-388944 X-HE-Meta: U2FsdGVkX1+WcBpp+5Ow4+Ct00/txaTJ1jkRO+W3WLjGXzZ3oiZJgQHEBDqU6OTzHUpqwDUxEKjQ8eR6emSDvpxtqt0q3Zrl6nAYA8d1NWlqaiILJuuD0d33mzOzHzCE9Rg0zGbjODhmrXTVLMrKoyeZv2i1ZpUT9eszAdtHSx/c6fbFy6iwU9vO8XYTih5mnAjIH7Dok7OaQuEfhxiYPIh4AjygAb7cOv5Fc1DwCkge4AO3oMp+GE1QSaHMoFss3EytC9R3FQi4WUcQ7eMWQ+pcXdy/vHqXMFUIWFrlJUS2chQr36CsKn6YFTHIrjJXKCzTAWi2oghrY5bOgNLO+zZHrWZW2vS1bWAdPb17/y+qrVYwehZHCJUcI3tyBM71UuaWfoMgROIhyh5kvzxLqnjAqA/YYd2SZYJXJG/abQzx0JBF3kcKNG1GXgA/bKUiI164TbvtNRKu020eIbAuMcNmoeV0lhkJohDgACvpridMui0xnFUHdAI3dJITpjpy+A3LN1M7In41F9aBGuBsHmGxg3lQUtql0a9deWR8T7OXzSXytnVRc6QVZfHeWdyFjP0oYn/arV45ylvWGThwMN2vYCq0hFv2Drw0mIfuEnHvrCOsHdUw70gCoO8HTaE6fDXf6Yxxc7zt09ZpKzGERQtmBgQNQHXzRVvha/y0q7ha5D9MhdpDFJ6r4bGJWPwLqJG3BHJVWrx/1UWtbwxJ8R11jHePu0LKCQuWlABKbtlRGEP+VKQMkHo/z615u0ROpCnFKLOCpl9uK9NrIwBDP2zsUCqGiPYKvhQaYs/DHHtqfPR2Vqytt00GTEy1wp8sWkj5UqvVtcIsvAdJaV8VkjDCkAJNTjUeOeHm8Dq09AbtF4BghsgkdOqdxXkG92anAKoWml/cQhn0PiQWP2f/Rp94o8n7dC06Yi0RWRaZAonEjluEzyytLAMeVGJ6o8VlRHz1lK8ZMo4P05FItUm YR9/i4L2 gJth61X85491NrdEG/DVRz1NCvwlFq0QwzZuNm9qwCz6T21VLIxqiGmzpf8ZvaP7B3WS1vs8D9f3rE+WfYd3gPESQL5Nfw90DasWNUkyj9BDcbx7TWGE34SJYtvrpLGQm8UYwnXULibGqOracqhi6W3d7+IUw/aeWVYueFApucMq4rEwLjcMp7K8/YwfP+slTCUH6hhbQ7pp5Ebi5Dinbq/L7xYC3Ldclx2pwXJk3ez2LA13ECayLKb7hF3/aidTKqBf5JaTOuBtJRocnCHUORi41wwd1utDHQmjKryPgRZ50c1fYYsYUnjWrGw3DbcYEw04Z/8CUr8czGqrehLUczIJ/kw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 2025-01-21 at 11:33 +0100, Peter Zijlstra wrote: > On Tue, Jan 21, 2025 at 10:55:07AM +0100, Peter Zijlstra wrote: > >=20 > > Can't we just start with a very simple constant test and poke at > > things > > if/when its found to not work? >=20 > Something like so perhaps? I've applied your suggestions, with the exception of some code that was already simplified further based on other people's suggestions (get_global_asid is no longer a loop). --=20 All Rights Reversed.