From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4AF0C7EE30 for ; Thu, 26 Jun 2025 21:53:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 462E06B00B9; Thu, 26 Jun 2025 17:53:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3E5B36B00BA; Thu, 26 Jun 2025 17:53:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 287316B00BB; Thu, 26 Jun 2025 17:53:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 11F776B00B9 for ; Thu, 26 Jun 2025 17:53:08 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 878B21A040D for ; Thu, 26 Jun 2025 21:53:07 +0000 (UTC) X-FDA: 83598902814.24.1E54758 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf04.hostedemail.com (Postfix) with ESMTP id 1C86240010 for ; Thu, 26 Jun 2025 21:53:04 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ibFPaFA9; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750974785; a=rsa-sha256; cv=none; b=yGxNvLwJtG6XkR8AHS99eUjljYZcJrumXHPKKMXLr3pePNPfda2O7NrLi50/4CyIo5Xwsu ZYMsiYw4mmi8YtR1gS4uwVHp9Tr9556T5goWn1yAZCEPUzZ+71nEajhDmWY7Z4DSTtAwiP CcXSOdxqfLifW9u1tcecusc4QNwWw7I= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ibFPaFA9; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750974785; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Sds+EnePYO1cZCHbAHOJn503ulI/pwm3RK5XFeMRA7A=; b=cJ3EEU1xA+Mgsvy7rCv8YacsqoV1/iV0/Ile5e6fOQd75AHanKvRizfeYl8IluBtc9OUq4 jN1LNyw/tzH24+AeJ0Wj1N9kEt50/8Y4zbRSATtNP/6rv9U/F3yduC2aZbWQYeYHqtHRcu YNjTo81XYthaorHj3+vRrmkb+3+9CGg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750974784; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Sds+EnePYO1cZCHbAHOJn503ulI/pwm3RK5XFeMRA7A=; b=ibFPaFA9ewYKPqsI+P2wNJw1P16rCaZz1kZC9TjKxpTuuBc8UeMPoJREXvE5aNOiFbxngX bFqOn3OrsqS3NHMnl40VOVpF0/3fY3dEySa0AWs2ezOfp4F1vuJW5OXiUJqmioiiWtd/EF TtFDdD+aygnDB+WbJxFmhDC+jwzThTg= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-443-Xe49jyBBNkGgXQQyewYiaQ-1; Thu, 26 Jun 2025 17:52:55 -0400 X-MC-Unique: Xe49jyBBNkGgXQQyewYiaQ-1 X-Mimecast-MFC-AGG-ID: Xe49jyBBNkGgXQQyewYiaQ_1750974774 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3a4f7ebfd00so769407f8f.2 for ; Thu, 26 Jun 2025 14:52:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750974774; x=1751579574; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=Sds+EnePYO1cZCHbAHOJn503ulI/pwm3RK5XFeMRA7A=; b=Pfcvp8xxyNgGlmMZ8G88XkISZPA5xGkkPedoZNVW/tzK4vanj8ptIxLHy/iEK5Mjgj PU5vmA+R+9xSW8eCQG9DMQwY02jT7dYZ4LTI3Q764L9j4qksMwTXBBXI5Y0JpOVwiB3K cz0J36hsOQ2eppk8sPApapDK0TOEGodHHUf05uPJkPQG7qr8jEzXsQo9cVhSmj3Gbw5Z Y5mRkNKYpL4uS3Qlbc9WMSeKy/8wET645ghcIOMNQXz45wTP+BwU10ZsMZvrcapHQ5sd R3tFAZjngei6lv9X9NfyHQCY2YBR7tUNvSlCTXOkXQswjr3AyMMcJfDSMo6+gI1Bcd85 ZPhQ== X-Forwarded-Encrypted: i=1; AJvYcCU74ADjMOQohCl9czj8GsAUsWBs/XUrh0nAWAOdm4Pb/HSXMsTZtCGovwk88/e2kIF4ZEVEEq6oDQ==@kvack.org X-Gm-Message-State: AOJu0YzyDnErvMG+wRhcsNmCpnqpt+ffoFVjBvqIV0u5Ew+Ei13hEDpS rOU4+/wUY/hJ3sVFbletoYOIuKBdOp2JfMfCe0qYA0GPXrbHMQHpQ9TFNIeGkD+wS3Lx5yGqUCl QP84/v+02bxAbe+lWN46xGBfntYE5dYK3JzTUJCJU2U3M5g+gyuH0 X-Gm-Gg: ASbGncsQvjhmJUIk5GfEft3qxHJurSAIuFnU0vZ+z4E/he/oMR6jjxM0s5BAQDBgoYC cXT6imOHFv30mijD77gw3JJSe4qqWpyD8vmoHhutkTFMDSDfmQqgU/iKis4Uv/BMeDbEMn/RToU 7PNhBhQEcfxN3+eGeOddYnexmFLXQ3AHhgkIk7YYNTlXGMiIOBe5hvEa2CvzwjFWnovjLyycRaw HE3sHVE87DZttST6OSLjbjkaj55LafH5X3GXWohaU0URvA+kWvGOJQMhXlcFAxTs+XuQua3w96L k/ODtPNB3obKbsHD4pBENHb8QL/mqKgP9HzHMtJ7JoAFlsoC78p1PEwyEwq07t8BgyejK0hLjl/ oJoVuSuan6bteBv2EbdkpmZ6amkXGyNrjryVzNH5+3KH/YDZLhg== X-Received: by 2002:adf:b60f:0:b0:3a6:d296:feaf with SMTP id ffacd0b85a97d-3a8fe985feamr656653f8f.24.1750974773615; Thu, 26 Jun 2025 14:52:53 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF91pFzkN010jPQk8nO4iHG/+bQ0g3gbQdu1CsS5nqxXRrx9a1rGPo2RPO9VipXGBPN3oatgg== X-Received: by 2002:adf:b60f:0:b0:3a6:d296:feaf with SMTP id ffacd0b85a97d-3a8fe985feamr656645f8f.24.1750974773213; Thu, 26 Jun 2025 14:52:53 -0700 (PDT) Received: from ?IPV6:2003:d8:2f3c:2f00:8afc:23fe:3813:776c? (p200300d82f3c2f008afc23fe3813776c.dip0.t-ipconnect.de. [2003:d8:2f3c:2f00:8afc:23fe:3813:776c]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a88c7fadf3sm958775f8f.34.2025.06.26.14.52.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 Jun 2025 14:52:52 -0700 (PDT) Message-ID: <4856517e-fb68-436f-8130-b7eb5749b7c0@redhat.com> Date: Thu, 26 Jun 2025 23:52:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 3/4] mm: Support batched unmap for lazyfree large folios during reclamation To: Barry Song <21cnbao@gmail.com>, Lance Yang Cc: akpm@linux-foundation.org, baolin.wang@linux.alibaba.com, chrisl@kernel.org, kasong@tencent.com, lance.yang@linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, lorenzo.stoakes@oracle.com, ryan.roberts@arm.com, v-songbaohua@oppo.com, x86@kernel.org, ying.huang@intel.com, zhengtangquan@oppo.com References: <20250626092905.31305-1-ioworker0@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: PL3kQtvbvqtrlUAy_Lq0pmjL5wNbrzK7ODbBfOFtPig_1750974774 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Stat-Signature: j6j5p5ey9gfjunnuu1cmhri8knd73esm X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 1C86240010 X-Rspam-User: X-HE-Tag: 1750974784-416083 X-HE-Meta: U2FsdGVkX1/z9UaT6qUEruqgEzCv841XBG/WyeyUbqzbQh2/KGZFF+MNhQrnz4N9++0sl/Z99IdA36VmQVFCMLbD/o96OXVAxyfU+UP3jEiMMecYMM/mRT//Gum+sFUpQleE0HGq3z6I53bHRC9W2erQc4tbJTjtAe1WHKZ6nDRn/CiEa3V0edOH9lm/YF3FqcSr0sz3sl7zxcyDlEWK64KsIKa7WlhsFr6evEzMtFvRJhgjCvKcqCEfrw83wxmVSq7YsJ+JoF7rBKwoNrkuUt4vIrm14Wb+Wt5AU2mytCZDDZXqUgxb9wq+EEN6ib6n0DigWCl4R5XPLOIzp9Y98xYDn+IuZGcYeR1eqflICvi28PfnR2ZF25p5vW+xiN8gENi2zG6yTVzR7R+CSxc1QYTDMUaXdd1rbGuBLbFKMwdvmlgxyE+/QDx5QUHKZBhhnkW9dQuHNGkGa6c8IUJTHP89QMPd0uYJ2OdRVD6I/bt6iFazQVJxD9D9JTQ/9TKtw02+D3ieIybrCEcbAoSOHKyyacALps+VcNUu/iSPTRb6GsDe6YtICA6EN0UfG5UOUeDCoQHlTF3Fv2/34S/rIx7yfsbrC2B2E7QtGHOpoX/JjnhUNj+L2UxtX5lEoVhxDTFZyNKdWkJ0VtwMAMlzia3Gtu3rhzaHNLRa6ZW6QF8eepELxj02Ys/c68Mn2QW94l7Oo7VYEq9X8mCVKwNbpY1LGfWYDfjBRgXs/0NQ2wKfbuYDb2zwWU58oKzrHfcxJUm0ocFUgSNPkNzW7BzKZ0Cb3lvMn/7dFTPSjxl8EeLMG3Xcts+mxCYCkofX5XGuVYc79Crzfq2wnx0qw0e70dNj3tiPwcQrXfKGmv6CEY/r0UhY92aVkwmr0lwZV+bXAuYGPC0j7SS60sTfQhKvbeLIA8zlO3Y7wL6Nkm/99WDPrbo1dZmD78TjhbLrS0IAe9B2viJPdVXOws+XGci 0LcWQYyx BrmL80/+TbndBpAo9Ry777Xgh+DOBrqLoMz/bV7xxd5XEhxv4pyecEUl2RLbhkx6zD2daeAxkk48EVQpYCqYMGmjbpCYPnJ3SK7n5bTI2zPWaUt+Jgy3/Iv9BDV86luJgAyVlVseh9+MZeR+v6EPtXpbBVOgNPrXLdFak1EthyGHW+M29Ped+GarFtbdr2SKt105I+b0bsbcU+iVrAetdGTFyNAHdk/quhXtlzQXTGrwivtNJMjKRjJbbglO4PUdPolZJwpjWJxVS8gFLKizamw/r7UW/q0f4UsPU0O0Hkgfj9rwnyoQVYDgt3oPnPZGcFsEfnb7/D4av9bZyd6v46VEpAYrwoB2mSINF3cvvln6OqZz0etyoZmaB8/ROqxlX+gRqrQhghtuQ3ihJeMERpZVAscERoHqYmX2YZTpIe/of7/h5qZRnWX9rctku+HrEKDmR2X+G0zYYQv0rgREeigbBYr6/QdV3zBoWJgDYTCqhWBEV3bBRYdhQqaOGk1GfrT7p X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 26.06.25 23:46, Barry Song wrote: > On Thu, Jun 26, 2025 at 9:29 PM Lance Yang wrote: >> > [...] >> + >> + /* >> + * If we are sure that we batched the entire folio and cleared >> + * all PTEs, we can just optimize and stop right here. >> + */ >> + if (nr_pages == folio_nr_pages(folio)) > > David also mentioned if (nr_pages > 1 && nr_pages == folio_nr_pages(folio)). > I assume it’s still fine when nr_pages == 1 for small folios? No? Yeah, as raised I think it is fine. We should never have any folio page mapped multiple times into the same VMA in any case. (excluding KSM pages, but they are handled differenty, using a specialized rmap walk) -- Cheers, David / dhildenb