From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f71.google.com (mail-lf0-f71.google.com [209.85.215.71]) by kanga.kvack.org (Postfix) with ESMTP id EE22F6B0263 for ; Wed, 21 Sep 2016 05:06:45 -0400 (EDT) Received: by mail-lf0-f71.google.com with SMTP id s64so4997809lfs.1 for ; Wed, 21 Sep 2016 02:06:45 -0700 (PDT) Received: from mx2.suse.de (mx2.suse.de. [195.135.220.15]) by mx.google.com with ESMTPS id xw9si33380928wjc.295.2016.09.21.02.06.44 for (version=TLS1 cipher=AES128-SHA bits=128/128); Wed, 21 Sep 2016 02:06:44 -0700 (PDT) Subject: Re: [PATCH v5 1/6] mm/page_alloc: don't reserve ZONE_HIGHMEM for ZONE_MOVABLE request References: <1472447255-10584-1-git-send-email-iamjoonsoo.kim@lge.com> <1472447255-10584-2-git-send-email-iamjoonsoo.kim@lge.com> From: Vlastimil Babka Message-ID: <48499d66-c861-7007-bd29-58c390a329c6@suse.cz> Date: Wed, 21 Sep 2016 11:06:39 +0200 MIME-Version: 1.0 In-Reply-To: <1472447255-10584-2-git-send-email-iamjoonsoo.kim@lge.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: js1304@gmail.com, Andrew Morton Cc: Rik van Riel , Johannes Weiner , mgorman@techsingularity.net, Laura Abbott , Minchan Kim , Marek Szyprowski , Michal Nazarewicz , "Aneesh Kumar K.V" , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Joonsoo Kim On 08/29/2016 07:07 AM, js1304@gmail.com wrote: > From: Joonsoo Kim > > Freepage on ZONE_HIGHMEM doesn't work for kernel memory so it's not that > important to reserve. When ZONE_MOVABLE is used, this problem would > theorectically cause to decrease usable memory for GFP_HIGHUSER_MOVABLE > allocation request which is mainly used for page cache and anon page > allocation. So, fix it. > > And, defining sysctl_lowmem_reserve_ratio array by MAX_NR_ZONES - 1 size > makes code complex. For example, if there is highmem system, following > reserve ratio is activated for *NORMAL ZONE* which would be easyily > misleading people. > > #ifdef CONFIG_HIGHMEM > 32 > #endif > > This patch also fix this situation by defining sysctl_lowmem_reserve_ratio > array by MAX_NR_ZONES and place "#ifdef" to right place. > > Signed-off-by: Joonsoo Kim Acked-by: Vlastimil Babka -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org