From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B4F8E80A86 for ; Wed, 27 Sep 2023 05:19:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B2A0B6B017E; Wed, 27 Sep 2023 01:19:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ADA6D6B0180; Wed, 27 Sep 2023 01:19:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9C8986B0190; Wed, 27 Sep 2023 01:19:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 8E4B16B017E for ; Wed, 27 Sep 2023 01:19:47 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 5110D80EF4 for ; Wed, 27 Sep 2023 05:19:47 +0000 (UTC) X-FDA: 81281225214.04.6720B64 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.115]) by imf29.hostedemail.com (Postfix) with ESMTP id D392712000E for ; Wed, 27 Sep 2023 05:19:44 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=nG7MImAv; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf29.hostedemail.com: domain of binbin.wu@linux.intel.com has no SPF policy when checking 192.55.52.115) smtp.mailfrom=binbin.wu@linux.intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695791985; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EJBmqOrPjvwuz3TdUb66dwChBKQwJC7E1LUoIPvUZTE=; b=NW3p6U2GpGLMBNTJlSFLZqAMdy7GAWCzYqv2AJOpBuP/DHQcRanSM/pdi3lq6qnC/KMfhj 2eC24QVvetWra09jmeF8VBAX1QrHhPQLn2fpEMmJ1yOYw6yeXsvzfyBQInvEH/k5HSFiaC A7/uzPHHlIN78uN3AQqhnGkdg96sjk0= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=nG7MImAv; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf29.hostedemail.com: domain of binbin.wu@linux.intel.com has no SPF policy when checking 192.55.52.115) smtp.mailfrom=binbin.wu@linux.intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695791985; a=rsa-sha256; cv=none; b=D7bH6i4foRtHZUyS0ul9eC60nLkMf6ez1zSIl4DR9k97ciHiwfR6D430O31w3r02u8AGCV BxplULEZZw7chcbXYCs5KH0R4/9h6cG7b6xCF2Mrtx4qFwoFW0lw3/oD6fWkWm5yeOBEde bdg9TTXOJImxitaqMxQd9SyKJHoQhCU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1695791984; x=1727327984; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=XWRHK3XHMCPUS7DjwBYEn6sN3WEf4Pd1a63R09LlTdM=; b=nG7MImAvsDmZqU6FSZE/SDeFin7r1hFFpcpdXxupOmTlcFD8wtqo0LNe gE3gqvBEW8lMy3Olwcnl8MzIb6T4gzAbq18ai0hi3CKdG6lx9Wel5p8fr Jaupn1fYmY1E83Y93oMSSob8IIFUKBvwp/yRmCsCJI4zJxRgL0vJYhONQ 58pxptex8xlDfcFgifskSCMgXGIWEu6319RJIjrPn87zooVIlhbea0sUM Y/E9IiiF00WcRmtYLcIL17SSxnnqqQNuKP+1o1G8tTzJfB8maKNNgbvIY ND2VEl0rI5i9EjTzrGwnH9qxJ2bW33b+FibFsZJcFHb+M0+nN7ur8FwoX Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10845"; a="381633596" X-IronPort-AV: E=Sophos;i="6.03,179,1694761200"; d="scan'208";a="381633596" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Sep 2023 22:19:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10845"; a="725676254" X-IronPort-AV: E=Sophos;i="6.03,179,1694761200"; d="scan'208";a="725676254" Received: from binbinwu-mobl.ccr.corp.intel.com (HELO [10.238.8.84]) ([10.238.8.84]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Sep 2023 22:19:32 -0700 Message-ID: <483f9e1e-7d01-5f06-3bfa-3788d2554724@linux.intel.com> Date: Wed, 27 Sep 2023 13:19:29 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [RFC PATCH v12 11/33] KVM: Introduce per-page memory attributes To: Sean Christopherson Cc: kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, Paolo Bonzini , Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , "Matthew Wilcox (Oracle)" , Andrew Morton , Paul Moore , James Morris , "Serge E. Hallyn" , Chao Peng , Fuad Tabba , Jarkko Sakkinen , Anish Moorthy , Yu Zhang , Isaku Yamahata , Xu Yilun , Vlastimil Babka , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , David Hildenbrand , Quentin Perret , Michael Roth , Wang , Liam Merwick , Isaku Yamahata , "Kirill A . Shutemov" References: <20230914015531.1419405-1-seanjc@google.com> <20230914015531.1419405-12-seanjc@google.com> From: Binbin Wu In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: D392712000E X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: yfarzjjprj1kdac7atojxn44i5391z7m X-HE-Tag: 1695791984-710477 X-HE-Meta: U2FsdGVkX19uYtEVDZMBTBWjZhIMHeVuz+49jWBnAqqAA0BMIl8AehN4wutxL5LeQW6T7I7Ij1q/1bvFAN4GO/pzTJkWI6hbvIbTUPOIMaDi2/domDa7dENlg7l7DxfGECep8YF/wWWJeOxJDcGU6uS7TiA53IbmeUUwAvbXw4WzpcmHEzQoNV8QjPlP4YJb/vnlBfC9FIm4Z8CyvYUU/YC0jiNjRHLNw6V5VkYQlXUn0twMIopQcIykZTyLMCUDzDeVh/a1CAxjFaPDrngT1tjHKTfRmvl4CZeRVhCW5aCnjyfWul1tYoyO39kxzcibqG/ypp3ejlDPmMYy220lPeM0IkGQv5hCi8iaSNpfDjoP7Sj1KUDzOsnF8vBCW+wPQKpUsUWhYDy1NUCb1JqVSLMs3HQYVOhD61aFqMLFjjD1HcWkKkc7I1BscE5wWLLdkClVgynqfLLrfteG6q07IQ0RFqp89gsli2CnE/uqTWUnyaMDVDMfQ38k7fGgiAIPncfatvpG8Ny1ECnjvX8aWOF3BGdhkWjAR3Q+bNgb+nyLGJgIqfSjIFJIQFGC8z7EHSNomSko9tPR3gfLFkALUfy4QV4Prm//VzmxudnOM8kUjfrWQkthsNFg1kelgQdPWcSPppvLdw16zSTPx1J7HDJXpmDmIc8bYOOEsFxkonVfr5UmStvryKcbAQUbxol5nNqcqkMv5NZynezstVesXmJukbQfa3liPuoO2NWdxCp7NcSNCHNAaiAp0aOoFLmsZmwO1u0g41YX2mFUAA328TGibnvC95Hq0oR0E0Zn8gAcfnPr6EXCE2Gz4oosZtZGn8dmWydbDbCMMbQxhbf4YgE+rugut7J8DImhVL5/tdandNwZ48dH0LZlypSTP10yVKwUrmnsraNuqA27jYCL507SqVreBHAgSFDk73+Hw628tbs/0Tv7HaivrwSgykV7FutUPZ0TbbWz98PEV1r CPN4x8CM Nv4ZfeS8FKe3iTKahQL/mFSREnfnzGZn/Mufd1EKJTNXSDeVlgNdhv19TY83a2I8vdSjPE/QSwWLlzLLRdMfrq+BN1ZvGPGf06Elher1OKbrsDd9dozLyxl+mnm3RVZ341yDMVZVEEEnYponw/sL0eI020Lu2d3QLOUHvOaX6ubTC4jW5gtfJPy1lPxjw3tRux0m/IUnBGLH4RX5YJ43B9feMih0veHuOIXbFM5MQd0fNxYF1pKrEbBUW+GAhpZyPnjKEkk4l8+xJ57L0956rj22bO+N9bGfsXiLOsx5HsyTIssjRQEONY5Ld9A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 9/21/2023 5:03 AM, Sean Christopherson wrote: > On Mon, Sep 18, 2023, Binbin Wu wrote: >> >> On 9/14/2023 9:55 AM, Sean Christopherson wrote: >>> From: Chao Peng >> [...] >>> +#ifdef CONFIG_KVM_GENERIC_MEMORY_ATTRIBUTES >>> +/* >>> + * Returns true if _all_ gfns in the range [@start, @end) have attributes >>> + * matching @attrs. >>> + */ >>> +bool kvm_range_has_memory_attributes(struct kvm *kvm, gfn_t start, gfn_t end, >>> + unsigned long attrs) >>> +{ >>> + XA_STATE(xas, &kvm->mem_attr_array, start); >>> + unsigned long index; >>> + bool has_attrs; >>> + void *entry; >>> + >>> + rcu_read_lock(); >>> + >>> + if (!attrs) { >>> + has_attrs = !xas_find(&xas, end); >> IIUIC, xas_find() is inclusive for "end", so here should be "end - 1" ? > Yes, that does appear to be the case. Inclusive vs. exclusive on gfn ranges has > is the bane of my existence. Seems this one is not included in the "KVM: guest_memfd fixes" patch series? https://lore.kernel.org/kvm/20230921203331.3746712-1-seanjc@google.com/