From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BCBFC369B2 for ; Thu, 17 Apr 2025 11:36:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B6C0528001A; Thu, 17 Apr 2025 07:36:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B1B3F280005; Thu, 17 Apr 2025 07:36:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 994D328001A; Thu, 17 Apr 2025 07:36:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 7B919280005 for ; Thu, 17 Apr 2025 07:36:47 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id DF08D1CCC45 for ; Thu, 17 Apr 2025 11:36:48 +0000 (UTC) X-FDA: 83343333696.03.1863A7D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf13.hostedemail.com (Postfix) with ESMTP id 60D062000B for ; Thu, 17 Apr 2025 11:36:46 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=X1zwu8qd; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf13.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744889806; a=rsa-sha256; cv=none; b=hkdX15vwZLXd9DHgMdvoVUx4njZlFdedPoSgzo1ceLwqV/zdY6UQgcJGwiQQAOiux8DX3m Z6oBDWMuS0CSzjOsaoYGIFEenGroLsO5NN99zr+HmLmsta07NAJLYgzIonrIWKHjfYMHLS t6B9/uglTokloH1hNz0UrpsysNyP2ng= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=X1zwu8qd; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf13.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744889806; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kzx9Eu/WeFq19jl2vTkSNZswgKYF5RL3vB3YRfJwvFQ=; b=NIEQuzVmiLlvTwjRZ39s/JYbm6ZwAhvBJB+cEHjJ28eGTtfnNB8Gjzu1ZTxgoy8+DPau/D lbAajfiElhoHnf4YIV6VLc0OeItWcW/FjhXvqFy865ewCZG93yKZu70BVisuuY9L0Uaib5 fatUjIWSqMp1+LIRxpNp069qdZr/PfQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1744889805; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=kzx9Eu/WeFq19jl2vTkSNZswgKYF5RL3vB3YRfJwvFQ=; b=X1zwu8qdzKB/qULx66/vlppCda3FaAkbTeyJc2miziElb1508kQRu9TGv+ZP54JgOb8gWq s0KP2egVkalbvygDLk8z3DM2WSQHWybX/bWmVqEqtiQM/K8b//CSmaQRXwtktF1lr2doh9 bR6MkBKCt4yKFCGOeS0lYzk3Y3Y/Eag= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-553-_tmGFemYMCG9Xgxe9tHn0A-1; Thu, 17 Apr 2025 07:36:44 -0400 X-MC-Unique: _tmGFemYMCG9Xgxe9tHn0A-1 X-Mimecast-MFC-AGG-ID: _tmGFemYMCG9Xgxe9tHn0A_1744889803 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3912a0439afso279076f8f.3 for ; Thu, 17 Apr 2025 04:36:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744889803; x=1745494603; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=kzx9Eu/WeFq19jl2vTkSNZswgKYF5RL3vB3YRfJwvFQ=; b=qLX4hLpRz+i2OA8UGrRLLdEeKcT1J08G5yCFYwSz3kjU8pkYzEGWAaF2DAwP6siPd1 79jROBubXt5NfUI1eawYTOA94ze0xJV1M0uPjTZ/kYD+s7NOlHdJ17rGSRF0+KRqKRBa XepKs29UBPG5g+HjYVxwvPif+Hl0LcYm1npsvwNKycJz+rjdY16hS6wvwbS7maQ7zfs/ eooRsBWap5FwnjBXm6MgFuxZnEOuWl10lMp0Kk8zIvQyDHb3et52hm4MXv5K7YM32QTo dmqUyeP7utfAEqaLiv77KXzrnSsRUnA/0uOKC7x2cWT/QA+qcYW68uyO5znQsEraVKUA 8Zsg== X-Gm-Message-State: AOJu0YwuVlUnUbcOY2HSg5bIQpEcX88zm6QK4J7+fIDfmCqBH6egI6hZ KYx3l8QGhclWc6EOZgvEaAlqQ+rFCeJddb/HXwQGD3nDboIlJJaUSjiJX5Wb8It+irneCWWcvjg zjnrqHT0QeUWVpXxp1V3RYDmPrHTwOW4dBbUsCmHzOplK1JsA X-Gm-Gg: ASbGncuuFld7fvyJf7444kOID0A5GhVZ5CItaF/LF6jOxA/IMRDv5KWNePA0hI7OFaI mCJxFS4iTcBvWWA62gpYsh3KafGMXCXj3uxu/kHRzUvHkSI1PzmdCeoptGo+g1S4ceahZQj6KhS Qcbp3qxTWesAinQNWIliGHeKIQrMlyTB99NG7FnNPSgwD8gbbTrRtDlvVgBAj/LzIG4RkGWXAnG 5eF0pXJbq9sUvdWmlxsFQHnLFHx9np6gtXPj8u9smpD/69L2sAuO1UGlMPT615ADJKnOhA6MFZv QGaE5D5SeoHAlP+9S/pNIHj9Tc0IRgHdmLlKRLmuj+tzol017ndXgOVXChXv7l/Awdl5O6y/ie/ Lv9YazglbIdLPTY/N4XIm6mAs9IE8c6Zy6IYE4SM= X-Received: by 2002:a05:6000:1a8a:b0:391:3094:d696 with SMTP id ffacd0b85a97d-39ee5ba0571mr5429297f8f.54.1744889803398; Thu, 17 Apr 2025 04:36:43 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGe/gNkqzmEXTARV/xkcy3k35IanjkSyZQslxVkUk7XlP0HTpe4AK8oiUQDFWYHHUGHEY/5qA== X-Received: by 2002:a05:6000:1a8a:b0:391:3094:d696 with SMTP id ffacd0b85a97d-39ee5ba0571mr5429264f8f.54.1744889802860; Thu, 17 Apr 2025 04:36:42 -0700 (PDT) Received: from ?IPV6:2003:cb:c706:2700:abf9:4eac:588c:adab? (p200300cbc7062700abf94eac588cadab.dip0.t-ipconnect.de. [2003:cb:c706:2700:abf9:4eac:588c:adab]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39eae97b249sm20040789f8f.58.2025.04.17.04.36.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Apr 2025 04:36:42 -0700 (PDT) Message-ID: <4828e28d-eb56-449b-83c3-b5b2dc2ac6e2@redhat.com> Date: Thu, 17 Apr 2025 13:36:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/huge_memory: fix dereferencing invalid pmd migration entry To: Gavin Guo , Hugh Dickins Cc: linux-mm@kvack.org, akpm@linux-foundation.org, willy@infradead.org, ziy@nvidia.com, linmiaohe@huawei.com, revest@google.com, kernel-dev@igalia.com, linux-kernel@vger.kernel.org References: <20250414072737.1698513-1-gavinguo@igalia.com> <27d13454-280f-4966-b694-d7e58d991547@redhat.com> <6787d0ea-a1b9-08cf-1f48-e361058eec20@google.com> <83f17b85-c9fa-43a0-bec1-22c8565b67ad@redhat.com> <98d1d195-7821-4627-b518-83103ade56c0@redhat.com> <7d0ef7b5-043b-beca-72a9-6ae98b0d55fb@google.com> <05a7d51e-f065-445a-af0e-481f3461a76e@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 4l8al7pd823SmEeLmUrs_guOuwTjyT7xhqeUZLEnFxs_1744889803 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 60D062000B X-Stat-Signature: 45ertmbmog1mu9dd41xi7hc7sn9959j7 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1744889806-33568 X-HE-Meta: U2FsdGVkX19LqStKAbeAeY0e/wDGqgQHJUZNF6rpO6Xra3nib59w7/INjdeyk+DvZelQQBXmG0y8v/JseTLBXauEfVKROmnDr5Bjhz5UAUz8vUBUhln65Gy2mBP5GjM8nVco5GNeCh+MoU5j7y4Y9gxz5FA8Puy0gZEmyvOd2MdyQlDLDKf4UgBcmAR//w/BE6qwjsTTZSevHsLW5PQID1yhKVkrCYMK+s2SndaFwCdq1dZyJeC/YJVcPyjx0ZvSYsOGwML2C+8MJuiWsBsSFgSa619AO/6zh/sbgmfUk6ZHKac7FTiaTk7DNI8FF/Eoq7GOlYbaDR2xUY/+Zmc80awlvoXJ23ve0F1s1whRVINzMT+FlldEuY5q39fYnC1tfCgXdweP89xzTwQsOB9i0tsGog4iRh3Miye0f6DrtoC62aW+T1khs9n6sQZo9pe5sMZ9hLUPz2TwnIhqY05CTpYYbbxt50dpI/I3gqpvJIGxdmIacfG4fBEOTMamWcns32zXh1LrPVAFfZgju+s7MTSw0clGAQRV1b7wnKjNWelfYccEYgBGJrRoHf4oRVMysmb+hYatq5/0HSaevWNLso1+Im/v4cMFU0GMfHgEp3C4pkh/iHbidvgUBH3m10Bc7E2xao/xObFfyBFbmPUJIsqvd+gKQ/FcvOT5Lud/nNY8Fe/iubL2Z4YzHKjofX74XUyR7W3v0l/YV3eQ33DOqcX/XALiolII8XNOH+6Da+hbRLif2eitXUpiYS4V2zxEKLR9+3S6FlGAmZ2GGH7ZPxx4ZIHHK7rzhGX2Hz+JTm+ZsJcvQ79lz6HfoSZEEVVBRZmOuRAtrBQwkENbhahPz2w+1lHb9pjYWd0Jgh6PXwGqHJdypKdRXzXmsHT+uT+WwV/mSDC1KHGJ2jWiQ41bj2uYBuQ0bfX9MUX8YkIJkFOnosKDN10iMYHCcqOgsXcf+Ax6CLHLfpYTiCw52Tg 4n9rg2pH GvdHDml8+PooyGDyHiU95cmyfyoBZb3jHs0N2xSy4MtYAVqNt2ibmyxXd5Pvh4GERQ9qX3ieoG4LtsZv4moYjkHAWXrmJfDIbdLf3WDbid5spi6BccqQGW/0ej4u0utXnM01soVv+qBM7RVTlg6VOXYb9imlDA5+8tnf2PzOviLPBFNGJrSYdbp/z2Dee1yo8L7wnZbMNbFB/r1qYvxy0OklWZ2cZayGsvyxh38m/YeOsJsgYk2T+1H/nppmWNKbXYWl9ffPOl7GJtYiFtNa/2EPaWB0Rou5/yDFMae3ZbRoZk6MWRjGMwxbwJEVKZs5zb4yvxZNupVbQYN5qvxEVAh6OT3lG4MX4pzIjpHnQ0ttqEWk054Dpo98mQb7n992HNpaXTS9KPG1oRiAEFPtEygRS4kq04XhQCwKlzsSj/quKGKRER4yENOcgPFWfegulxGeR292RCegqjI++zLD6Y/1P+HxjvcL0hXXdM4qmN0CEQMH5fghYSi+v3g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 17.04.25 13:21, Gavin Guo wrote: > On 4/17/25 17:04, David Hildenbrand wrote: >> On 17.04.25 10:55, Hugh Dickins wrote: >>> On Thu, 17 Apr 2025, David Hildenbrand wrote: >>>> On 17.04.25 09:18, David Hildenbrand wrote: >>>>> On 17.04.25 07:36, Hugh Dickins wrote: >>>>>> On Wed, 16 Apr 2025, David Hildenbrand wrote: >>>>>>> >>>>>>> Why not something like >>>>>>> >>>>>>> struct folio *entry_folio; >>>>>>> >>>>>>> if (folio) { >>>>>>>   if (is_pmd_migration_entry(*pmd)) >>>>>>>       entry_folio = pfn_swap_entry_folio(pmd_to_swp_entry(*pmd))); >>>>>>>   else >>>>>>>    entry_folio = pmd_folio(*pmd)); >>>>>>> >>>>>>>   if (folio != entry_folio) >>>>>>>         return; >>>>>>> } >>>>>> >>>>>> My own preference is to not add unnecessary code: >>>>>> if folio and pmd_migration entry, we're not interested in entry_folio. >>>>>> But yes it could be written in lots of other ways. >>>>> >>>>> While I don't disagree about "not adding unnecessary code" in general, >>>>> in this particular case just looking the folio up properly might be the >>>>> better alternative to reasoning about locking rules with conditional >>>>> input parameters :) >>>>> >>>> >>>> FWIW, I was wondering if we can rework that code, letting the caller >>>> to the >>>> checking and getting rid of the folio parameter. Something like this >>>> (incomplete, just to >>>> discuss if we could move the TTU_SPLIT_HUGE_PMD handling). >>> >>> Yes, I too dislike the folio parameter used for a single case, and agree >>> it's better for the caller who chose pmd to check that *pmd fits the >>> folio. >>> >>> I haven't checked your code below, but it looks like a much better way >>> to proceed, using the page_vma_mapped_walk() to get pmd lock and check; >>> and cutting out two or more layers of split_huge_pmd obscurity. >>> >>> Way to go.  However... what we want right now is a fix that can easily >>> go to stable: the rearrangements here in 6.15-rc mean, I think, that >>> whatever goes into the current tree will have to be placed differently >>> for stable, no seamless backports; but Gavin's patch (reworked if you >>> insist) can be adapted to stable (differently for different releases) >>> more more easily than the future direction you're proposing here. >> >> I'm fine with going with the current patch and looking into cleaning it >> up properly (if possible). >> >> So for this patch >> >> Acked-by: David Hildenbrand >> >> @Gavin, can you look into cleaning that up? > > Thank you for your review. Before I begin the cleanup, could you please > confirm the following action items: > > Zi Yan's suggestions for the patch are: > 1. Replace the page fault with an invalid address access in the commit > description. Yes, that makes sense. > > 2. Simplify the nested if-statements into a single if-statement to > reduce indentation. > > David, based on your comment, I understand that you are recommending the > entry_folio implementation. Also, from your discussion with Hugh, it > appears you agreed with my original approach of returning early when > encountering a PMD migration entry, thereby avoiding unnecessary checks. > Is that correct? If so, I will keep the current logic. Do you have any > additional cleanup suggestions? Yes, the current patch is okay for upstream+stable, but we should look into cleaning that up. See the cleanup RFC patch I posted where we remove the folio check completely. Please let me know if you need more information. -- Cheers, David / dhildenb