linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Shi Weihua <shiwh@cn.fujitsu.com>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: akpm@linux-foundation.org, Hugh Dickins <hugh@veritas.com>,
	Mel Gorman <mel@csn.ul.ie>,
	balbir@linux.vnet.ibm.com, xemul@openvz.org,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [BUGFIX][PATCH] Fix usemap initialization v3
Date: Wed, 23 Apr 2008 14:19:04 +0800	[thread overview]
Message-ID: <480ED4D8.5070607@cn.fujitsu.com> (raw)
In-Reply-To: <20080423134621.6020dd83.kamezawa.hiroyu@jp.fujitsu.com>

KAMEZAWA Hiroyuki wrote::
> fixed typos.
> ==
> usemap must be initialized only when pfn is within zone.
> If not, it corrupts memory.
> 
> And this patch also reduces the number of calls to set_pageblock_migratetype()
> from
> 	(pfn & (pageblock_nr_pages -1)
> to
> 	!(pfn & (pageblock_nr_pages-1)
> it should be called once per pageblock.
> 
> Changelog.
> v2->v3
>  - Fixed typos.
> v1->v2
>  - Fixed boundary check.
>  - Move calculation of pointer for zone struct to out of loop.

I noticed v3 takes "zone" instead of "zid" in the code line 
"z = &NODE_DATA(nid)->node_zones[zone];".
I tested v3, it works well now.

Thanks,
-Shi

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2008-04-23  6:19 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <48080706.50305@cn.fujitsu.com>
     [not found] ` <48080930.5090905@cn.fujitsu.com>
2008-04-18  2:46   ` [PATCH] memcgroup: check and initialize page->cgroup in memmap_init_zone Shi Weihua
2008-04-18  3:04     ` KAMEZAWA Hiroyuki
2008-04-18  3:14       ` Shi Weihua
2008-04-18  3:14     ` Andrew Morton
2008-04-18  3:32       ` KAMEZAWA Hiroyuki
2008-04-18  5:09         ` KAMEZAWA Hiroyuki
2008-04-18  5:43           ` Shi Weihua
2008-04-18  5:57             ` KAMEZAWA Hiroyuki
2008-04-18  6:47             ` KAMEZAWA Hiroyuki
2008-04-18  3:37       ` Balbir Singh
2008-04-18  3:49         ` Shi Weihua
2008-04-18 12:12     ` [PATCH]Fix usemap for DISCONTIG/FLATMEM with not-aligned zone initilaization KAMEZAWA Hiroyuki
2008-04-18 16:15       ` Mel Gorman
2008-04-18 17:41         ` Dave Hansen
2008-04-18 17:25       ` kamezawa.hiroyu
2008-04-21  2:20         ` KAMEZAWA Hiroyuki
2008-04-21 10:12           ` Mel Gorman
2008-04-21 10:29             ` KAMEZAWA Hiroyuki
2008-04-21 11:56           ` Hugh Dickins
2008-04-22  1:40             ` [BUGFIX][PATCH] Fix usemap initialization v2 KAMEZAWA Hiroyuki
2008-04-22 10:12               ` Hugh Dickins
2008-04-23  1:45                 ` KAMEZAWA Hiroyuki
2008-04-23  2:17                 ` Shi Weihua
2008-04-23  4:46               ` [BUGFIX][PATCH] Fix usemap initialization v3 KAMEZAWA Hiroyuki
2008-04-23  6:19                 ` Shi Weihua [this message]
2008-04-23  8:04                   ` KAMEZAWA Hiroyuki
2008-04-23 12:46                 ` Mel Gorman
2008-04-27 19:18                 ` Andrew Morton
2008-04-27 19:30                   ` Balbir Singh
2008-04-27 22:50                     ` Hugh Dickins
2008-04-28  0:39                   ` KAMEZAWA Hiroyuki
2008-04-21 13:02           ` Re: [PATCH]Fix usemap for DISCONTIG/FLATMEM with not-aligned zone initilaization kamezawa.hiroyu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=480ED4D8.5070607@cn.fujitsu.com \
    --to=shiwh@cn.fujitsu.com \
    --cc=akpm@linux-foundation.org \
    --cc=balbir@linux.vnet.ibm.com \
    --cc=hugh@veritas.com \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mel@csn.ul.ie \
    --cc=xemul@openvz.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox