From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B20C6C28B25 for ; Wed, 5 Mar 2025 18:59:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3054128000B; Wed, 5 Mar 2025 13:59:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 28CC7280008; Wed, 5 Mar 2025 13:59:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1307A28000B; Wed, 5 Mar 2025 13:59:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id E611F280008 for ; Wed, 5 Mar 2025 13:59:19 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id CE2D4B6CD6 for ; Wed, 5 Mar 2025 16:32:29 +0000 (UTC) X-FDA: 83188040418.06.50D12CE Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf15.hostedemail.com (Postfix) with ESMTP id A799FA0019 for ; Wed, 5 Mar 2025 16:32:27 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf15.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741192348; a=rsa-sha256; cv=none; b=BaHMH+hjdG1v+4fMqTL2G2tGFIhzgqR6MpNL/45QgfnlDm5avqVLBb1oZ4HlemL5HNgPJq UNa9ROK1vgiSWVUSI0jSh0ZTyzW1UxL9hIBWJYJRd9crPLf3R/wFxbnnh0E8Nc8vLN5Cxp upLIocpY8ZQQNqJNzYyoEMkKCsXINAs= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf15.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741192348; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OhHkM0O9+jIPqivBsfyP54DdmHAXG6cxfY+5oRx8nSU=; b=pRxUYn7kG6YGBsUIKNmuLk+OWhVNTwxILPsrjqbLOKbRKj2oKSs9g1K0oQr9aR5OEm2U3h eL1jbwBGpaiJlkt/EXCeY49b4uePSzfERNaT8lT7mFM+i8m1hwgFLl0fUz2sOMzalxQsHB 4DfTKuxgZPn9E3nVT65fo8bQxMXcYi8= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id ECB8EFEC; Wed, 5 Mar 2025 08:32:39 -0800 (PST) Received: from [10.57.83.152] (unknown [10.57.83.152]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id CAD883F5A1; Wed, 5 Mar 2025 08:32:23 -0800 (PST) Message-ID: <47fd6aed-cb91-488d-ac2c-92f9ce73887f@arm.com> Date: Wed, 5 Mar 2025 16:32:21 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 05/11] arm64: hugetlb: Use set_ptes_anysz() and ptep_get_and_clear_anysz() Content-Language: en-GB To: kernel test robot , Catalin Marinas , Will Deacon , Pasha Tatashin , Andrew Morton , Uladzislau Rezki , Christoph Hellwig , David Hildenbrand , "Matthew Wilcox (Oracle)" , Mark Rutland , Anshuman Khandual , Alexandre Ghiti , Kevin Brodsky Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, Linux Memory Management List , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20250304150444.3788920-6-ryan.roberts@arm.com> <202503052315.vk7m958M-lkp@intel.com> From: Ryan Roberts In-Reply-To: <202503052315.vk7m958M-lkp@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: A799FA0019 X-Stat-Signature: 9hnkq83iikbbny7db513kj7ms565k8oh X-Rspam-User: X-HE-Tag: 1741192347-306446 X-HE-Meta: U2FsdGVkX19HUT/R3UtkW3lS7Zsa+5Y3gqR3NT+aItPUZU7Qd299hnyU+mu+W71YkL+jtd6ccfPS9LCpXzHfAQj5vk3L2Rw/Ueqrw1WZldLYChXZQ0BgzfPbGu/pXdhVa/ndIMvEBzI8pONuHaZXuc2rwJqyTOTQvYkV8Eew33IIGXJ9LAZ6DWSPg5Rfc0ESx9l5fLUs4gsZMA1wTqCFHfnU77bB61kmsFlDrfhUtj7m07IjJr8KcbM21RcvTcl8Ro3gIltl2drxzTvnvG6hLnxgpeqwCgzgDRMR9vJH5gv0qvJeVMWcrTzeYfdCQxt8uiOQxoQerBzbORVJjM7nI9nFp+66RUU3iOHUqqfiB+sE+gjcTUwC0UHz6njTxx+UdItk/k7k0CjnTV8XCCgHhJfliIGi0rEZ9SsfE8oKGCZYQW1SyB8K4nkRPgVlCVaoidPOr0awYZHXGEHZwgoj3Z1eMzRS2Z8CGBrJBIlUIC9NA0qaCUwLTot6PD9NL50JQbwyGcNxccR3tcpyLFXfPl52uwklVPwHKZLzUf3tuZNuEBuucbHIPtpteTQZchJLIW7oeSk5gzJsffshsAOUJ0CiY2rz0j3oVhp/TO01J3SrweIAO7b1eVHCKFwdZV/sNdALDG7wyqLjuBMTlqwFMEXMS7iN1ZGAwT/MFdqCecTYdEDs4TuH3CBt1ApQcUWcZ4h2DwRzayY2S3J0RUjjGIcorilXE5dJB10aGFHsXAzYjb91+e0zc2sAInRBl/nCG4JSQTtXh8iBGcicwoUI0074LGwsnMji7KQAA/C1i/fL8u9SrrJ6EaubzDtkrKQPgQiI9SqX6WT359/OIK+InQlD8z+BxTJjkRsTbe2ahd1nPmvwmTO5B2FYVTfA3Zy40v62i5Bn9Ya3UUx/MOavQaBCfKDlqwifSD/WC8L5lcTRWdYOmxvmETecb/L0euQkupD8no06ADddHiJrvRH yeMrZX/x BvxovTFCbAAH6qxhOx5VWAK0QSMQ4iGQv8hHMLL9HcRT2/PBbFCd6f9TmujyNcqpE3AE/C7dvkl2D9YRztg35rnl43D14Y0xMXeYeozwWSc2pOYbJ6LmruVhJ3wwccDWo+LhG6XsaM1sVMiAfOw1XBs/FHxanCHJ5bTyfbVgBIkc5Unzs+4tQZjcuRHlYE1YRr3IGWrfNXIyS47bOt4BQtiH+GoQ/7qEcK7jY2rio1mAM81FiKGqwFxKaUC+KhXXAEWiyaJyYDadg4l0xutPIOiKjkjKguowoDCse10c54RiZdxMuUUXzqTwq/A8HtoDnLyCc6Qhde4Rf853mj8MN1V9A930Wl/TX6AfAjdae04anah4mEOjW4ZVQeIGfTP2De+ItG+iIJElD9Cq+0KFklgBydw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 05/03/2025 16:00, kernel test robot wrote: > Hi Ryan, > > kernel test robot noticed the following build warnings: > > [auto build test WARNING on linus/master] > [also build test WARNING on v6.14-rc5 next-20250305] > [cannot apply to arm64/for-next/core akpm-mm/mm-everything arm-perf/for-next/perf] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > url: https://github.com/intel-lab-lkp/linux/commits/Ryan-Roberts/arm64-hugetlb-Cleanup-huge_pte-size-discovery-mechanisms/20250304-230647 > base: linus/master > patch link: https://lore.kernel.org/r/20250304150444.3788920-6-ryan.roberts%40arm.com > patch subject: [PATCH v3 05/11] arm64: hugetlb: Use set_ptes_anysz() and ptep_get_and_clear_anysz() > config: arm64-randconfig-003-20250305 (https://download.01.org/0day-ci/archive/20250305/202503052315.vk7m958M-lkp@intel.com/config) > compiler: clang version 21.0.0git (https://github.com/llvm/llvm-project 14170b16028c087ca154878f5ed93d3089a965c6) > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250305/202503052315.vk7m958M-lkp@intel.com/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/oe-kbuild-all/202503052315.vk7m958M-lkp@intel.com/ > > All warnings (new ones prefixed by >>): > > In file included from arch/arm64/mm/hugetlbpage.c:12: > In file included from include/linux/mm.h:2224: > include/linux/vmstat.h:504:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion] > 504 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS + > | ~~~~~~~~~~~~~~~~~~~~~ ^ > 505 | item]; > | ~~~~ > include/linux/vmstat.h:511:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion] > 511 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS + > | ~~~~~~~~~~~~~~~~~~~~~ ^ > 512 | NR_VM_NUMA_EVENT_ITEMS + > | ~~~~~~~~~~~~~~~~~~~~~~ >>> arch/arm64/mm/hugetlbpage.c:154:23: warning: parameter 'addr' set but not used [-Wunused-but-set-parameter] > 154 | unsigned long addr, > | ^ > 3 warnings generated. > > > vim +/addr +154 arch/arm64/mm/hugetlbpage.c > > bc5dfb4fd7bd471 Baolin Wang 2022-05-16 144 > d8bdcff2876424d Steve Capper 2017-08-22 145 /* > d8bdcff2876424d Steve Capper 2017-08-22 146 * Changing some bits of contiguous entries requires us to follow a > d8bdcff2876424d Steve Capper 2017-08-22 147 * Break-Before-Make approach, breaking the whole contiguous set > d8bdcff2876424d Steve Capper 2017-08-22 148 * before we can change any entries. See ARM DDI 0487A.k_iss10775, > d8bdcff2876424d Steve Capper 2017-08-22 149 * "Misprogramming of the Contiguous bit", page D4-1762. > d8bdcff2876424d Steve Capper 2017-08-22 150 * > d8bdcff2876424d Steve Capper 2017-08-22 151 * This helper performs the break step. > d8bdcff2876424d Steve Capper 2017-08-22 152 */ > fb396bb459c1fa3 Anshuman Khandual 2022-05-10 153 static pte_t get_clear_contig(struct mm_struct *mm, > d8bdcff2876424d Steve Capper 2017-08-22 @154 unsigned long addr, > d8bdcff2876424d Steve Capper 2017-08-22 155 pte_t *ptep, > d8bdcff2876424d Steve Capper 2017-08-22 156 unsigned long pgsize, > d8bdcff2876424d Steve Capper 2017-08-22 157 unsigned long ncontig) > d8bdcff2876424d Steve Capper 2017-08-22 158 { > 49c87f7677746f3 Ryan Roberts 2025-02-26 159 pte_t pte, tmp_pte; > 49c87f7677746f3 Ryan Roberts 2025-02-26 160 bool present; > 49c87f7677746f3 Ryan Roberts 2025-02-26 161 > 66251d3eadf78e2 Ryan Roberts 2025-03-04 162 pte = ptep_get_and_clear_anysz(mm, ptep, pgsize); > 49c87f7677746f3 Ryan Roberts 2025-02-26 163 present = pte_present(pte); > 49c87f7677746f3 Ryan Roberts 2025-02-26 164 while (--ncontig) { > 49c87f7677746f3 Ryan Roberts 2025-02-26 165 ptep++; > 49c87f7677746f3 Ryan Roberts 2025-02-26 166 addr += pgsize; Ahh yes, thanks! Looks like this line can be removed since we no longer need the address. Catalin, I was optimistically hoping this might be the final version. If it is, are you happy to fold this in? Or do you want me to re-spin regardless? > 66251d3eadf78e2 Ryan Roberts 2025-03-04 167 tmp_pte = ptep_get_and_clear_anysz(mm, ptep, pgsize); > 49c87f7677746f3 Ryan Roberts 2025-02-26 168 if (present) { > 49c87f7677746f3 Ryan Roberts 2025-02-26 169 if (pte_dirty(tmp_pte)) > 49c87f7677746f3 Ryan Roberts 2025-02-26 170 pte = pte_mkdirty(pte); > 49c87f7677746f3 Ryan Roberts 2025-02-26 171 if (pte_young(tmp_pte)) > 49c87f7677746f3 Ryan Roberts 2025-02-26 172 pte = pte_mkyoung(pte); > d8bdcff2876424d Steve Capper 2017-08-22 173 } > 49c87f7677746f3 Ryan Roberts 2025-02-26 174 } > 49c87f7677746f3 Ryan Roberts 2025-02-26 175 return pte; > d8bdcff2876424d Steve Capper 2017-08-22 176 } > d8bdcff2876424d Steve Capper 2017-08-22 177 >