From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40759E6F061 for ; Fri, 1 Nov 2024 14:17:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BB3C76B00A0; Fri, 1 Nov 2024 10:17:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B64436B00A1; Fri, 1 Nov 2024 10:17:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A04686B00A2; Fri, 1 Nov 2024 10:17:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 7FCD06B00A0 for ; Fri, 1 Nov 2024 10:17:04 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 3145FC0771 for ; Fri, 1 Nov 2024 14:17:04 +0000 (UTC) X-FDA: 82737726876.25.C012412 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) by imf18.hostedemail.com (Postfix) with ESMTP id 87F5D1C0022 for ; Fri, 1 Nov 2024 14:16:49 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=QuYl71up; spf=pass (imf18.hostedemail.com: domain of groeck7@gmail.com designates 209.85.210.172 as permitted sender) smtp.mailfrom=groeck7@gmail.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730470540; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NFchV1PjszL4CoLP5K130zG0LqBxt/CVi1vhj5zjfFA=; b=ZHUG7ngHcURHaIIi3ccwX7xLUIKyw/sECuuPDi6uhnVVKZeC6/MuQAX310wYfpl/86wfwz lSZz7pdZlKgi9lO8cheins4+871/ZY0k47AAHcW7Hvejh06wmUxet/dndHkk115SaHkoga p4Hn15MB3sAs2s7SRrWjEUoyOA+n2io= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730470540; a=rsa-sha256; cv=none; b=WiYqY8QdgWhChKAJg997ZGX22NTNvEKn2iWtey5snqgI4iOuhFh1HPaeGWuWHwiEKPTa98 bjDxlAKA906Jtc/rHMQGdgOA7+n7akaGc4DWwBc1mGENKbMc5HbqzPK4P6BXwwT8oyi7LA iCfniumRno/cJ0vn6ja1rClcD5BgQo8= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=QuYl71up; spf=pass (imf18.hostedemail.com: domain of groeck7@gmail.com designates 209.85.210.172 as permitted sender) smtp.mailfrom=groeck7@gmail.com; dmarc=none Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-720be2b27acso1451672b3a.0 for ; Fri, 01 Nov 2024 07:17:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1730470621; x=1731075421; darn=kvack.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:from:to:cc:subject:date:message-id:reply-to; bh=NFchV1PjszL4CoLP5K130zG0LqBxt/CVi1vhj5zjfFA=; b=QuYl71upvINz1WZDtVzgWQz8Q8BST7cERltR5vCZhIxdDG3bHCDbvB9EimHQtYnMQd MSEOI5mEMXSILsCJoINqTf/nWZnNLjiLbJVGQp6JY5K6GHPvAjhmVSfUEwOTneCOqLIh brMohcmDoN+wWTXHOcuCfsUaUV2Jg1c6mEi8CnRX/m5oqJV7DVC3waDCYfqvvvCnQne7 sxcwsazoJHltYK/eycQGy/4zwKExz2mNFGOcZSRniYFRD0EEyYwmWngF6m4sdlsOT8fT w3CfISWFoRhb6am+VW3ChucfnSem453oTKOHXVI221zqNgJeFcH40Jc8gE1OnBr+Q1WH bLzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730470621; x=1731075421; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=NFchV1PjszL4CoLP5K130zG0LqBxt/CVi1vhj5zjfFA=; b=JlaLsLS/S/XIYfWE2JmMBoFaVq689AcPdCVNan58+uaQrvgxjdyfuEGBvWvqTB2ngE t2cA/IXXQhqhvagkazZc4u/SsUiEhsjDi7lhzAXi2iV6gwKpS8Eh+4esURXg+4sWTK6T /sUJC57JdG5bq/gbOtWR7m9khcniL7nvHVjB6fT0bfwJPl6aqoO8DjhQ5Hd4VZMLpu4g HUfzDObM4NlRe1gNwkSSjSfhiPssACgvElXi5FfrGB7JwFnZElIcZlVKEBlPoeKU01o0 a3SDR9Ijmj9J/FgsTjMjQeigJzEIIQm1qWvvvxAziyeiBPBkZm6CURSoJ53Pf0Rpi82P cf+w== X-Forwarded-Encrypted: i=1; AJvYcCX/AccTljFPeRU+ZsvGt05NQzKWz9RaZNu9dtM4u0tAoeFBK6U6uEeApkDmPfouGu5VFeRa4U+9XA==@kvack.org X-Gm-Message-State: AOJu0YyPlO0gnasKiseQ7FD8q431nDubfaIUt5qGI8vmVM66H+ZuvjHe Xd8Ideb0BH8P1Pkzv+kje6Sx4qlEHYr7SgM7zijspO5B2UUklxDa X-Google-Smtp-Source: AGHT+IHTl99hV0UaJza8mCwc5/j47zox+uBjZ2VwG6HPCKDS+py5HiCuDMUr5ohMbkU6Yehx0Bc+AA== X-Received: by 2002:a05:6a21:6e4a:b0:1d4:e4a9:c126 with SMTP id adf61e73a8af0-1db91e6983bmr9692192637.32.1730470620669; Fri, 01 Nov 2024 07:17:00 -0700 (PDT) Received: from ?IPV6:2600:1700:e321:62f0:329c:23ff:fee3:9d7c? ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7ee45296fc5sm2473086a12.11.2024.11.01.07.16.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 01 Nov 2024 07:16:59 -0700 (PDT) Message-ID: <47fae3a3-3597-43ef-961b-c47558a779ab@roeck-us.net> Date: Fri, 1 Nov 2024 07:16:57 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH] mm/damon/core: avoid overflow in damon_feed_loop_next_input() To: SeongJae Park Cc: damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20241031052113.66155-1-sj@kernel.org> Content-Language: en-US From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAlVcphcFCRmg06EACgkQyx8mb86fmYFg0RAA nzXJzuPkLJaOmSIzPAqqnutACchT/meCOgMEpS5oLf6xn5ySZkl23OxuhpMZTVX+49c9pvBx hpvl5bCWFu5qC1jC2eWRYU+aZZE4sxMaAGeWenQJsiG9lP8wkfCJP3ockNu0ZXXAXwIbY1O1 c+l11zQkZw89zNgWgKobKzrDMBFOYtAh0pAInZ9TSn7oA4Ctejouo5wUugmk8MrDtUVXmEA9 7f9fgKYSwl/H7dfKKsS1bDOpyJlqhEAH94BHJdK/b1tzwJCFAXFhMlmlbYEk8kWjcxQgDWMu GAthQzSuAyhqyZwFcOlMCNbAcTSQawSo3B9yM9mHJne5RrAbVz4TWLnEaX8gA5xK3uCNCeyI sqYuzA4OzcMwnnTASvzsGZoYHTFP3DQwf2nzxD6yBGCfwNGIYfS0i8YN8XcBgEcDFMWpOQhT Pu3HeztMnF3HXrc0t7e5rDW9zCh3k2PA6D2NV4fews9KDFhLlTfCVzf0PS1dRVVWM+4jVl6l HRIAgWp+2/f8dx5vPc4Ycp4IsZN0l1h9uT7qm1KTwz+sSl1zOqKD/BpfGNZfLRRxrXthvvY8 BltcuZ4+PGFTcRkMytUbMDFMF9Cjd2W9dXD35PEtvj8wnEyzIos8bbgtLrGTv/SYhmPpahJA l8hPhYvmAvpOmusUUyB30StsHIU2LLccUPPOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAlVcpi8FCRmg08MACgkQyx8mb86fmYHNRQ/+ J0OZsBYP4leJvQF8lx9zif+v4ZY/6C9tTcUv/KNAE5leyrD4IKbnV4PnbrVhjq861it/zRQW cFpWQszZyWRwNPWUUz7ejmm9lAwPbr8xWT4qMSA43VKQ7ZCeTQJ4TC8kjqtcbw41SjkjrcTG wF52zFO4bOWyovVAPncvV9eGA/vtnd3xEZXQiSt91kBSqK28yjxAqK/c3G6i7IX2rg6pzgqh hiH3/1qM2M/LSuqAv0Rwrt/k+pZXE+B4Ud42hwmMr0TfhNxG+X7YKvjKC+SjPjqp0CaztQ0H nsDLSLElVROxCd9m8CAUuHplgmR3seYCOrT4jriMFBtKNPtj2EE4DNV4s7k0Zy+6iRQ8G8ng QjsSqYJx8iAR8JRB7Gm2rQOMv8lSRdjva++GT0VLXtHULdlzg8VjDnFZ3lfz5PWEOeIMk7Rj trjv82EZtrhLuLjHRCaG50OOm0hwPSk1J64R8O3HjSLdertmw7eyAYOo4RuWJguYMg5DRnBk WkRwrSuCn7UG+qVWZeKEsFKFOkynOs3pVbcbq1pxbhk3TRWCGRU5JolI4ohy/7JV1TVbjiDI HP/aVnm6NC8of26P40Pg8EdAhajZnHHjA7FrJXsy3cyIGqvg9os4rNkUWmrCfLLsZDHD8FnU mDW4+i+XlNFUPUYMrIKi9joBhu18ssf5i5Q= In-Reply-To: <20241031052113.66155-1-sj@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam10 X-Stat-Signature: aqassddjtws3xeboj4grfjboowucxzhk X-Rspamd-Queue-Id: 87F5D1C0022 X-Rspam-User: X-HE-Tag: 1730470609-785528 X-HE-Meta: U2FsdGVkX19sATruU732PZ9emZDSjgP/2zl2A2ChUKmrYNx9XBRrbhX4Ue/sG8d/CCjHE9XPomiWUgoTn+/5Nf1VlEWKiHXesJCIfDGz89q4uH8tvXXJwWvDtuWiny7OERBzHgTb0xTAGDcTbIdsOIc7SZWccIMH+FG5JwUzD3IapbhfU7ptQkdjJCW5H36OQXC0TvRxFM9Res5lus/w+Oa2nd+T9bVE+LGNGG6hqpLGzmnUuPQPRP/nYGqSnDmnjUfEBvrnlhLyFjSKeV6jI4GcJe8sQaKCiZh3NMrXcdshjQYM15OShT12nMuZebSvJwaZRzAvWw9GEAyjFK2WImXOCOO+JnJYnTdBewNaegxIKx6dlotcQkAiYHS1SSTXCC7CWtqgUfaGTrP4L/desD1RM+aEmyoxKUh+A5J1oYT4HYrY1Mo/yYWaJvPL+gsEmSO3a/ft2ddMmH+WmtTsuvteCvNjxUYLtZ4Pfv6mnvScM56Ykua1BaYhnjD3NYoCkE037Jf3JVKdcekL9YZFhXIHzm4075/SV2iR8LpInyXr1WutHI8IE297A/hM49I7KS49sfNoXaBRQLKu8y+y0UjB4chX9iNv9skez8flzEASqacJJFB0kqq3k7TPtvfHgtiKiCd+Wzhmy3Bhy5vSbnWo1Q0+WvOYMJXcMkIRqHqpxVzPxeSW73Z7+c5SZ6I9aIYgx1Ib2Ot/U2Ecbe0XlGCZvcswie0nhXn36hnuij9PtGJKd28VEx/OmFa0ZPMAJ6KXqkXrOdPTlEOM6YxDVMKMq50jHtiTSarZS6oGCcjlEbxmI0AmyuHxPHJboiWqulOG+0QEbCeaQysH8235sr2PCVF4x3dl2LzFGHD3vyI4aUYeC+oaObvfz68BCP68oAPyWzPNe7/8z8qCEWKFcQrlMgARyOyUxFNRJOiqpRnC3Ml/OZe7je2tU7Flx220Lgop6KHho2YeurLay9d 8r5hfkWM MO9bITEMbtI75nfZzRebvRXc+huPVhXxkh4whlcP9oM50kzjXLsylFq15A8q4VyntfVBQHuEmbEjN4L719gYEJXhttRv+iomUbKy/7ERn8OMBO2T0IYgwUP6I0nxN/KBBMB989teMkdiewrxAC+Ae6PwFgcppKvljwdxASP4HJ52SA1RLRFzD0qAaq0wKVTyCcNbTfO0cvDMSHbNnjWk/OLB71CmdUNnrZwj7YBacqRIWxVFf4M+GlHw9YVHsLcYdSw1oBK1PTeIzsIBtE19/KlopztR6QcdQLb5+2ftss0hr0OcL0n9oZFrg1P5gYgKY+jnOwTFuEFU3M/tYQrf7igOBLt5HI7pOBVBHvCukVF1fPWDDKusfFVSyReRmlRvbxyjHstYfDKW3kb+mmzS2QJ73dFCv5Y3QIAEN2KucQcIP1MBjsMl0GMPgl4aCO2BXo+Z0LCwXpjIuzdQ3KXWnPHJqYFfh8d9K5wDlgTyyYElG58OV6iBPn6t++7KQwNJ6QNYG+DfAI4TTjLocuM+JfXNZL5wxxiEuJPL/5fUWkxqe8majL8S1geYI7R+WxtbxdLb9pli29UcRF3cR07JX5jWPHMVggsIE4Y5F X-Bogosity: Ham, tests=bogofilter, spamicity=0.000062, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi, On 10/30/24 22:21, SeongJae Park wrote: > Hi Guenter, > > On Wed, 30 Oct 2024 21:18:51 -0700 Guenter Roeck wrote: > >> On Thu, Sep 05, 2024 at 10:24:05AM -0700, SeongJae Park wrote: >>> damon_feed_loop_next_input() is fragile to overflows. Rewrite code to >>> avoid overflows. This is not yet well tested on 32bit archs. >>> >>> Reported-by: Guenter Roeck >>> Closes: https://lore.kernel.org/944f3d5b-9177-48e7-8ec9-7f1331a3fea3@roeck-us.net >>> Fixes: 9294a037c015 ("mm/damon/core: implement goal-oriented feedback-driven quota auto-tuning") >>> Signed-off-by: SeongJae Park >>> --- >>> As mentioned on the commit message, this is not yet sufficiently tested >>> on 32bit machines. That's why this is RFC. >> >> Is that patch going anywhere ? I have been testing it on a lot of 32-bit architectures, >> and I do not see any failures. > > Thank you for this nice reminder with the grateful test results, Guenter! > > I was recently cleaning up the code and commit message, and testing on my own > with test setup. I should confess that it took more than I expected in the > last RFC posting. Sorry for the delay, and thank you for your patience. > No worries; I just didn't want it to get lost. > I believe the patch is now in good form, but I was waiting just a couple of > more days before posting it, for a case that I find any mistake on it. So > unless I find something wrong on the patch by Tomorrow morning (Pacific Time), > I will post it after dropping the RFC tag. > > The current version of the patch to be posted is available at my patches > queue[1]. Please let me know if you find anything suspicious on it. > > Thank you again for your patience and nice reminder! > > [1] https://git.kernel.org/pub/scm/linux/kernel/git/sj/damon-hack.git/tree/patches/next/mm-damon-core-avoid-overflow-in-damon_feed_loop_next.patch?id=fb13d053bfdd5249bebdd1c253417f97cd41471e > I already got that version of the patch per e-mail yesterday. I re-tested it in my testbed last night, and it (still) works as expected. So, again, for the record: Tested-by: Guenter Roeck Thanks, Guenter