From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 734E5C001B0 for ; Wed, 19 Jul 2023 07:47:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 99CB6280037; Wed, 19 Jul 2023 03:47:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 94CFE8D004B; Wed, 19 Jul 2023 03:47:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 83C24280037; Wed, 19 Jul 2023 03:47:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 74DCC8D004B for ; Wed, 19 Jul 2023 03:47:05 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 3D203A01B3 for ; Wed, 19 Jul 2023 07:47:05 +0000 (UTC) X-FDA: 81027580410.21.54FE10D Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by imf30.hostedemail.com (Postfix) with ESMTP id 522228000C for ; Wed, 19 Jul 2023 07:47:00 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf30.hostedemail.com: domain of zhangpeng362@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=zhangpeng362@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689752822; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DYGeurhUdTGLLR7gLLyR/y/YQPM5mSr0fW3f9JzFJPM=; b=VXBw39Xts6B/jW3JlIG+u7XWz5bAVBjR0FVCVGtUgVJzDP+peYZmvEUp5vi6DAP0B4F57X PveyU1jdQzGwF/6IIi1GxB4SupcZB81mWLBCjFRs/rQacd1UCuw50Rc8td6JHzHcVxsNzm YbaIBOg8O+Z6dpmhuiNydwi0NHSQXb0= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf30.hostedemail.com: domain of zhangpeng362@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=zhangpeng362@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689752822; a=rsa-sha256; cv=none; b=P2X5IBGc4F3CtEX3DP5RUWkXUEAPkjyMUNYF4hir5x+5XWbB1bUX6SkhnmVLiaP6vg+zaW trHEGtxCUewNEI0qrNgaHbXfMckCcA/D9NyiXbL9kxJFVH4whH+vz7ySUztHBk28iLGrm0 +Tg1Vm9r1e5XSuqvCnEFzbdj46bZMyk= Received: from kwepemm600020.china.huawei.com (unknown [172.30.72.53]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4R5SWZ46lmzLnss; Wed, 19 Jul 2023 15:44:26 +0800 (CST) Received: from [10.174.179.160] (10.174.179.160) by kwepemm600020.china.huawei.com (7.193.23.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Wed, 19 Jul 2023 15:46:53 +0800 Message-ID: <47ec8e1c-d7e5-8420-0ceb-60a9e71b064f@huawei.com> Date: Wed, 19 Jul 2023 15:46:52 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 1/6] mm/page_io: use a folio in __end_swap_bio_read() To: Matthew Wilcox CC: , , , , , References: <20230717132602.2202147-1-zhangpeng362@huawei.com> <20230717132602.2202147-2-zhangpeng362@huawei.com> Content-Language: en-US From: "zhangpeng (AS)" In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.179.160] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To kwepemm600020.china.huawei.com (7.193.23.147) X-CFilter-Loop: Reflected X-Rspam-User: X-Stat-Signature: icouugw6g3bdcp31q5ze7z6kytmfbk8n X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 522228000C X-HE-Tag: 1689752820-69821 X-HE-Meta: U2FsdGVkX1+/u+gN8uzqOR4w6RzGhBhtPnoir/kDuAPCz+ZgdNpzstaf8QOa+7Mi8k1qaJs+Zg+wKAtmSjKZHvRhciCzaodfqt6Oh2JP6KUJLhDdl/Y2BLM9O4s0ZlInqT0lBbMlxAHBU1nNjmQrkOHp4OoKDiqdno+FahTl6MmTaM2lMW5EGyUgoOT/Wm1QjXtr7ivoOcGxhqsagAOIY2K2rXxe7hyDcUIpl8lMcR0/YdHUWRQ+UHFhdOnYKorM4PJz28thUHGJnu7f52BCvEjKr3PVr8p2Cssh97GBySdaayCo2DudKVJfjzdawIgL4unOJExX2Xw45ZQstYYrh6FJ7Ae9+E3kTEhCb2TWgZuFjxt2L2xzbW1VWItePWtDdIq1Tdec4MRIoTDB7P3JRNqTEj8UJI+hMuxU35TL3SN4+h5bnaOd3jItbadw/5sCNQ8mOslERQmPSN4lBpU0I9Y9dRij1puUJhbUzutdzIUMYq1M08IswV/5i1UOIUEdcIOFlOPcpeP2/A8Mzk8krqBPVTSN6NOxVf7YBdJqStJqZ/7RWHhbVtqd+FSo68cli9vKxLvswWalQBS9PDN1pnm+MPHrsLKzV4/yYbbcRk0e7BRrN3r9mMpHOIeVikgiZWdbEG1VNKujujO7fcyLwQCe1OIEwohf8y+RW5mNAPsaVqOUTtQ/W09OuuX6QlPnYbGUaa3N4v4TyUuLWPVTYflq5D5ZI2R5dkEF7Kb3RW+cZsPbioxmaAaxOmuJDwYJE8PaT5JmSa39KpI4yxutwfmdCzbudgzekl4pMm6NtCdDraxDBRjbaGE1ojebesjisC8UndQVSZIdkKPFdCFtW55kjwlXCVNMYr4dDDrGLExluCgB/v/DB/ncmky8btw2d0zhjYUz9ATp9/Tzoa9CRwJN/KPFdmpgxNlEmqeN7cLY3SvM6/b3JcBGuTq29im8PFZQ1fPa9y3Im3+gxAL 1Wb2XGwf HVkztiuTWlUDmi1aJeGXsqS0k/64TiGI5Vw0bc0qCb9HtpHB9INU1UqGl+FD7i2uNvM1N/Q/Hhx5FnAtf68sHkY8evzC4ecvWQDdQS99JXzlGc6jvh4BmlPgY46jlE4SUrfLFTWM+iMXcWw2lnebWOxhUQ6xDTdtzPtVAoFs33RMTJHH87TQMzSjbdQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/7/19 0:16, Matthew Wilcox wrote: > On Tue, Jul 18, 2023 at 08:56:16PM +0800, zhangpeng (AS) wrote: >>>> if (bio->bi_status) { >>>> - SetPageError(page); >>>> - ClearPageUptodate(page); >>>> + folio_set_error(folio); >>> I appreciate this is a 1:1 conversion, but maybe we could think about >>> this a bit. Is there anybody who checks the >>> PageError()/folio_test_error() for this page/folio? >> Maybe wait_dev_supers() checks the PageError() after write_dev_supers() >> in fs/btrfs/disk-io.c? > How does _this_ folio end up in btrfs's write_dev_supers()? This is a > swap read. The only folios which are swapped are anonymous and tmpfs. > btrfs takes care of doing its own I/O. wait_dev_supers() is looking > for the error set in btrfs_end_super_write() which is the completion > routine for write_dev_supers(). The pages involved there are attached > to a btrfs address_space, not shmem or anon. Thanks for your explanation! Then I think nobody checks the PageError()/folio_test_error() for the page in patch 1 and patch 2. I'll delete SetPageError() in a v2. -- Best Regards, Peng