From: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
To: "David Hildenbrand (Red Hat)" <david@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
"Liam R . Howlett" <Liam.Howlett@oracle.com>,
Vlastimil Babka <vbabka@suse.cz>, Mike Rapoport <rppt@kernel.org>,
Suren Baghdasaryan <surenb@google.com>,
Michal Hocko <mhocko@suse.com>, Jann Horn <jannh@google.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] mm: rename walk_page_range_mm()
Date: Mon, 10 Nov 2025 16:28:29 +0000 [thread overview]
Message-ID: <47e190ac-792b-41a0-be24-5bdd0c26e800@lucifer.local> (raw)
In-Reply-To: <f7a69885-7bf6-456b-81fe-3c6a5a29b470@kernel.org>
On Mon, Nov 10, 2025 at 04:48:51PM +0100, David Hildenbrand (Red Hat) wrote:
> On 09.11.25 12:16, Lorenzo Stoakes wrote:
> > Make it clear we're referencing an unsafe variant of this function
> > explicitly.
> >
> > This is laying the foundation for exposing more such functions and
> > maintaining a consistent naming scheme.
>
> IIUC, the "unsafe" variants only bypass the check_ops_valid() check,
> correct?
>
> Staring at the code, I wonder if we should then rename check_ops_valid() to
> something like "are_ops_safe()" [or something similar along the lines of
> safe vs. unsafe]
>
> Because now we will have valid vs. unsafe which is a bit confusing, at least
> for me.
That is a valid and safe point ;)
Ack will rename.
>
> --
> Cheers
>
> David
Cheers, Lorenzo
next prev parent reply other threads:[~2025-11-10 16:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-09 11:16 [PATCH 0/2] mm: perform guard region install/remove under VMA lock Lorenzo Stoakes
2025-11-09 11:16 ` [PATCH 1/2] mm: rename walk_page_range_mm() Lorenzo Stoakes
2025-11-10 15:48 ` David Hildenbrand (Red Hat)
2025-11-10 16:28 ` Lorenzo Stoakes [this message]
2025-11-09 11:16 ` [PATCH 2/2] mm/madvise: allow guard page install/remove under VMA lock Lorenzo Stoakes
2025-11-10 15:44 ` David Hildenbrand (Red Hat)
2025-11-10 16:29 ` Lorenzo Stoakes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47e190ac-792b-41a0-be24-5bdd0c26e800@lucifer.local \
--to=lorenzo.stoakes@oracle.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=david@kernel.org \
--cc=jannh@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=rppt@kernel.org \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox