From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28627E748FC for ; Mon, 2 Oct 2023 17:36:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8D7FA8D004C; Mon, 2 Oct 2023 13:36:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 888DB8D000E; Mon, 2 Oct 2023 13:36:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 750C08D004C; Mon, 2 Oct 2023 13:36:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 6305B8D000E for ; Mon, 2 Oct 2023 13:36:09 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 3E63BA0397 for ; Mon, 2 Oct 2023 17:36:09 +0000 (UTC) X-FDA: 81301224858.22.A5C13C1 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf14.hostedemail.com (Postfix) with ESMTP id 1BBD8100033 for ; Mon, 2 Oct 2023 17:36:06 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="Xc/jgPDT"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696268167; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AWvha6fRF1SNOXs+/+D3XvvHHwIpB0ZKCqYjNNw4DJ0=; b=JyynHKGs4C31MLPR8vtz64ZTIvFfRNFWRLHPGYQwklXs2TPgs07RGaGihw5Nm7Fhn3JHfc iyc8MMuKPrWRXWVYbJ1j4jyNCjuPPNBd7B9LW/COOa0ynOX6rIe1iWUf762zWu3EQiZrMv bnnYeozJl4frqxkKAB90ll3SvcYMtcw= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="Xc/jgPDT"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696268167; a=rsa-sha256; cv=none; b=Xiv0VYCSSiZROqVuT0todRomeIY8BVnoDedUZgdWda9fGmroi/t125YQS8ID8z+WLw1rKO TF3WK/eeH5a7XR6zmTPEdvB+ruhS9kMco6GAM0+pC4C+jEksYJ0PP2UKJqaEp54T6OEIqJ i6aQJO32mE39goNDm8eCsUVEI4yczsc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1696268166; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AWvha6fRF1SNOXs+/+D3XvvHHwIpB0ZKCqYjNNw4DJ0=; b=Xc/jgPDTBZdyGsQtGv7S5Ke/z1+DF920kyAKvSK+DMuRXUx4T0CX1qJQCJm7Nvl+JrHvJh UFgwgJ5O/6ObLlqSFuWK2DGA8vhe3R/wsmJgJFDiFuNpvRsDadCfzQT+VxQAHSiGKFQieX 6ewLxxA5Pta3f0rcfRXMBr29KdssZug= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-388-6yzPeGjYOfK3qCUH2urjzg-1; Mon, 02 Oct 2023 13:36:04 -0400 X-MC-Unique: 6yzPeGjYOfK3qCUH2urjzg-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-30932d15a30so35647f8f.1 for ; Mon, 02 Oct 2023 10:36:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696268163; x=1696872963; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :from:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=AWvha6fRF1SNOXs+/+D3XvvHHwIpB0ZKCqYjNNw4DJ0=; b=iYj3RJVDBWgVRBACUnm2H8v2BqZ7OXMbOxc7X6yzKPYh7oCPAwoH+mucIguQy/gdPu QBpf2BsipPBysIgvaKgIjYEpURxW9SFMaYq1iEiw53vs+tcbOhe7qTu9T4RqRHL/Ky5E 1z5WxytiSeFZZg4dWPeNIljkpHGMU0avcdpPRnTkEOmAxKfPnlShKDq/UflENncnnWnG YqlswcXnSI+GT6m3fJdmhker+3PTnsJAd1co9/Oxem6efNHwZDXrElobAdfv66NwOpI8 5lQ27m8b0sH6orS/PfimXyBKPkhe8qDVZfLbDi4XhvijVX08AQEChHsDFaZjO+3S0yNP SRPg== X-Gm-Message-State: AOJu0Yzj7NZuJ3X37tubsMzz4OLE/nUkGyUqM8hs1v8jFFvuVI43HfK7 jIDyApL0M5c1WibxdvBOURKsnIcd3uhCnLFzuv28U/IvcoQNalf1J2R6gvtjp64mvHL2Dm/SIW2 e6dA6dSRumJ0= X-Received: by 2002:adf:f051:0:b0:319:85e2:6972 with SMTP id t17-20020adff051000000b0031985e26972mr10691560wro.42.1696268163573; Mon, 02 Oct 2023 10:36:03 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGuvx/KeHzqrds9UsnjoUzmDcg51LBJ7y3jmgAeA81+WENxMHL6lgJz18K85ppvucakyeJY0g== X-Received: by 2002:adf:f051:0:b0:319:85e2:6972 with SMTP id t17-20020adff051000000b0031985e26972mr10691531wro.42.1696268163093; Mon, 02 Oct 2023 10:36:03 -0700 (PDT) Received: from ?IPV6:2003:cb:c735:f200:cb49:cb8f:88fc:9446? (p200300cbc735f200cb49cb8f88fc9446.dip0.t-ipconnect.de. [2003:cb:c735:f200:cb49:cb8f:88fc:9446]) by smtp.gmail.com with ESMTPSA id y7-20020adfd087000000b00317f70240afsm28206600wrh.27.2023.10.02.10.36.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Oct 2023 10:36:02 -0700 (PDT) Message-ID: <47daf31f-e242-43e3-289c-8015eb516c6d@redhat.com> Date: Mon, 2 Oct 2023 19:36:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v2 2/3] userfaultfd: UFFDIO_REMAP uABI From: David Hildenbrand To: Peter Xu Cc: Jann Horn , Suren Baghdasaryan , akpm@linux-foundation.org, viro@zeniv.linux.org.uk, brauner@kernel.org, shuah@kernel.org, aarcange@redhat.com, lokeshgidra@google.com, hughd@google.com, mhocko@suse.com, axelrasmussen@google.com, rppt@kernel.org, willy@infradead.org, Liam.Howlett@oracle.com, zhangpeng362@huawei.com, bgeffon@google.com, kaleshsingh@google.com, ngeoffray@google.com, jdduke@google.com, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kernel-team@android.com References: <20230923013148.1390521-1-surenb@google.com> <20230923013148.1390521-3-surenb@google.com> <03f95e90-82bd-6ee2-7c0d-d4dc5d3e15ee@redhat.com> <98b21e78-a90d-8b54-3659-e9b890be094f@redhat.com> <85e5390c-660c-ef9e-b415-00ee71bc5cbf@redhat.com> Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 1BBD8100033 X-Stat-Signature: 6qxmtq7h4ddinfbse948sr3z8tjkbsn5 X-Rspam-User: X-HE-Tag: 1696268166-121659 X-HE-Meta: U2FsdGVkX19BPhqL81bCkRAo7Swe4+P/qBKoyh/5rHcEK+zVF9NniFLZ36RTiIlMbz4xzg/3T4EHC9RVxJVUdAE6X4Q5oSxKzrYzS06UEhiC22E70E7AQPMtNNV7mn8KGKYicCZdZY+YuLNWmsat8Jz08q1xb9Lqgwn+TcQFLmO/MOJdh/vnnp0gWPHTnGI7e/Khp6RZHniql5f/SJTlQRbpwW1qQYjRx8AS+OAwXCjBQ1VXcen1KMsbEmUdSL0S5qW56FaqT8Rpq/2Q+yCHzQX0xS5IsolmJcSZ3T39ueeMG26yRqeqdQAKh+pRzJyzUSMZDxrn55GWmqD5aX4+Jn1GzkjMp+RVqjzGt+yIIIJs3/BNjBonF982I/4n81Z+Ki0dGA4mjC7fP+3lIJXg5akP5q+KCzxO8cJPKOZzZ8QDz1+yI1vRh8rgiDT5AGZHvX54pWOt8r869vRStVWe6XJ8YMV27GjrUzK3CcFGJFakDOBJapDcKBZvPKEiBRkpYddIUWZuIFsiguGdfyBDzzKlHaBbuonjgZi0hQjOLDVdkcYZUY4Stk2qbrISpoxjrAS1yCaWi+8jQY1dV8V2kQ3qcg/79mynjQKbfbC0X9+Xf8jrJ3ztzeaZ+aj9UUoMzbM3jBMN2824k+r2r0gd0KScRM2u6vhnAgiv5tIYtpSY7tclcVs49puvmcx0BrcjmfoECyE7KGh88Y8rUGE77vpaFvjNjUb696Z2ZXFEKdVrBWKUbKGTM2wYloO5jLCEb6cNSZnLYFefHAPs2cMJlzf3R+6fIr3zKNzz4kcUPrVFKKRWpM9fIizwguTQI2Ou5jH238Kvew93M8jjT0IfjnAOfnDntAkfJ3pSbNk9b63oyxOzXaf+3lHtHGZuP64nh1r6ZEEIpUU3HJdY4k8QASq6uA4hbhTDBlifTkDZ+f3RRBIKmyjeAcCjynl0MmEAheoikRgJWoMxcuZyxm7 l8nPv9d/ 0BOjUQYF+ihpwt52KBpJsXM7m/lNyPlUrDK49oRPLOkYpkoG5tJ3gdV2y0+80OUXWBzhQUwx9zzssH0jwlIO7dGq6iIR/+0WWwOua32hroRJJ/zFFsjO/1oeKnh2L6De73pAd9tYnxOEw/EAL3ZS6wfJcWka4H43eX3bfvhaeD0NJuc2V5qGnDtqLTYsT9orYJfsljPdk4zMxaDSbdbWpRA7Vsyp6rPYVAEhMEVk6J9c1N8IB1MywZ6dd4g5eQOtI9zon5JjYxfuHEzT7+pzZ1H1AIPWwiLFy/QjGvpZkIcTvIe5ibnep/QpimlvmPCJOuGUREu4NsYKPB6Fqiytf+Vv3P+9ysKnTRWpDXTGUw8Y1SXq+0s22U1HUMJCQgPWUsPpEI7kGedQ+i42QrpqOaZNyCUW4hBUBLnNkJFk5CC2l0d26x1x1CSN8Iw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 02.10.23 19:33, David Hildenbrand wrote: > On 02.10.23 17:21, Peter Xu wrote: >> On Mon, Oct 02, 2023 at 10:00:03AM +0200, David Hildenbrand wrote: >>> In case we cannot simply remap the page, the fallback sequence (from the >>> cover letter) would be triggered. >>> >>> 1) UFFDIO_COPY >>> 2) MADV_DONTNEED >>> >>> So we would just handle the operation internally without a fallback. >> >> Note that I think there will be a slight difference on whole remap >> atomicity, on what happens if the page is modified after UFFDIO_COPY but >> before DONTNEED. > > If the page is writable (implies PAE), we can always move it. If it is > R/O, it cannot change before we get a page fault and grab the PT lock > (well, and page lock). > > So I think something atomic can be implemented without too much issues. > >> >> UFFDIO_REMAP guarantees full atomicity when moving the page, IOW, threads >> can be updating the pages when ioctl(UFFDIO_REMAP), data won't get lost >> during movement, and it will generate a missing event after moved, with >> latest data showing up on dest. > > If the page has to be copied, grab a reference and unmap it, then copy > it and map it into the new process. Should be doable and handle all > kinds of situations just fine. > > Just throwing out ideas to get a less low-level interface. > > [if one really wants to get notified when one cannot move without a > copy, one could have a flag for such power users to control the behavior] > [of course, if someone would have a GUP-pin on such a page, the page exchange would be observable. Just have to documented the UFFDIO_MOVE semantics properly] -- Cheers, David / dhildenb