From: Kirill Tkhai <ktkhai@virtuozzo.com>
To: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, David Howells <dhowells@redhat.com>
Cc: vdavydov.dev@gmail.com, mhocko@suse.com, aryabinin@virtuozzo.com,
ying.huang@intel.com, penguin-kernel@I-love.SAKURA.ne.jp,
willy@infradead.org, shakeelb@google.com, jbacik@fb.com,
linux-mm@kvack.org
Subject: Re: [PATCH] mm: Move check for SHRINKER_NUMA_AWARE to do_shrink_slab()
Date: Fri, 3 Aug 2018 12:02:26 +0300 [thread overview]
Message-ID: <47c34fad-5d11-53b0-4386-61be890163c5@virtuozzo.com> (raw)
In-Reply-To: <20180802134723.ecdd540c7c9338f98ee1a2c6@linux-foundation.org>
On 02.08.2018 23:47, Andrew Morton wrote:
> On Thu, 02 Aug 2018 14:00:52 +0300 Kirill Tkhai <ktkhai@virtuozzo.com> wrote:
>
>> In case of shrink_slab_memcg() we do not zero nid, when shrinker
>> is not numa-aware. This is not a real problem, since currently
>> all memcg-aware shrinkers are numa-aware too (we have two:
>> super_block shrinker and workingset shrinker), but something may
>> change in the future.
>
> Fair enough.
>
>> (Andrew, this may be merged to mm-iterate-only-over-charged-shrinkers-during-memcg-shrink_slab)
>
> It got a bit messy so I got lazy and queued it as a separate patch.
>
> btw, I have a note that https://lkml.org/lkml/2018/7/7/32 was caused by
> this patch series. Is that the case and do you know if this was
> addressed?
It's not related to the patchset. Bisect leads to:
commit c6aeb9d4c351 (HEAD, refs/bisect/bad)
Author: David Howells <dhowells@redhat.com>
Date: Sun Jun 24 00:20:10 2018 +0100
kernfs, sysfs, cgroup, intel_rdt: Support fs_context
CC David.
David, please see reproducer at https://lkml.org/lkml/2018/7/7/32
Kirill
next prev parent reply other threads:[~2018-08-03 9:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-02 11:00 Kirill Tkhai
2018-08-02 16:47 ` Yang Shi
2018-08-02 16:54 ` Shakeel Butt
2018-08-02 17:26 ` Yang Shi
2018-08-03 7:11 ` Kirill Tkhai
2018-08-02 20:47 ` Andrew Morton
2018-08-03 9:02 ` Kirill Tkhai [this message]
2018-08-03 10:31 ` David Howells
2018-08-03 10:59 ` Kirill Tkhai
2018-08-03 11:04 ` Kirill Tkhai
2018-08-03 12:00 ` David Howells
2018-08-03 11:18 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47c34fad-5d11-53b0-4386-61be890163c5@virtuozzo.com \
--to=ktkhai@virtuozzo.com \
--cc=akpm@linux-foundation.org \
--cc=aryabinin@virtuozzo.com \
--cc=dhowells@redhat.com \
--cc=jbacik@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=shakeelb@google.com \
--cc=vdavydov.dev@gmail.com \
--cc=willy@infradead.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox