From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FF08C433FE for ; Wed, 9 Mar 2022 05:14:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A6A3A8D000B; Wed, 9 Mar 2022 00:14:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A190D8D0001; Wed, 9 Mar 2022 00:14:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 908748D000B; Wed, 9 Mar 2022 00:14:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.28]) by kanga.kvack.org (Postfix) with ESMTP id 7E6C68D0001 for ; Wed, 9 Mar 2022 00:14:07 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 3918121376 for ; Wed, 9 Mar 2022 05:14:07 +0000 (UTC) X-FDA: 79223681334.08.F7F1DBA Received: from loongson.cn (mail.loongson.cn [114.242.206.163]) by imf09.hostedemail.com (Postfix) with ESMTP id 7DCE414000D for ; Wed, 9 Mar 2022 05:14:05 +0000 (UTC) Received: from [10.20.42.25] (unknown [10.20.42.25]) by mail.loongson.cn (Coremail) with SMTP id AQAAf9BxsM6XNyhiB38FAA--.25846S3; Wed, 09 Mar 2022 13:13:59 +0800 (CST) Subject: Re: [PATCH] mm: reduce tlb flush range when changing vma protection To: Nadav Amit Cc: Andrew Morton , Linux-MM , linux-kernel@vger.kernel.org References: <20220309025721.3051365-1-maobibo@loongson.cn> <87861C77-F203-40A5-814D-A3541081064E@gmail.com> From: maobibo Message-ID: <47b0425d-811e-aeae-3d3d-6b7e730540de@loongson.cn> Date: Wed, 9 Mar 2022 13:13:59 +0800 User-Agent: Mozilla/5.0 (X11; Linux mips64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <87861C77-F203-40A5-814D-A3541081064E@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-CM-TRANSID:AQAAf9BxsM6XNyhiB38FAA--.25846S3 X-Coremail-Antispam: 1UD129KBjvdXoWrtr15tF45Jr4kWF4UCw45Jrb_yoWDJrXE9r 9Fka97Cw1DZrZ7ta1IqF4rtrs5Xw1UAa15Zw4jqr9Fv3s0yaySvan2gr9Fka98CFW8Crnx WwnFqwsavr1avjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbxxYjsxI4VWDJwAYFVCjjxCrM7AC8VAFwI0_Jr0_Gr1l1xkIjI8I 6I8E6xAIw20EY4v20xvaj40_Wr0E3s1l1IIY67AEw4v_Jr0_Jr4l8cAvFVAK0II2c7xJM2 8CjxkF64kEwVA0rcxSw2x7M28EF7xvwVC0I7IYx2IY67AKxVWUCVW8JwA2z4x0Y4vE2Ix0 cI8IcVCY1x0267AKxVW8JVWxJwA2z4x0Y4vEx4A2jsIE14v26F4UJVW0owA2z4x0Y4vEx4 A2jsIEc7CjxVAFwI0_GcCE3s1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xvF2IE w4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE14v26r1j6r4UMc vjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvEwIxGrwCYjI0SjxkI62AI1cAE67vIY487MxkI ecxEwVCm-wCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F4 0E14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_JF0_Jw1l IxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxV AFwI0_Jr0_Gr1lIxAIcVCF04k26cxKx2IYs7xG6rW3Jr0E3s1lIxAIcVC2z280aVAFwI0_ Jr0_Gr1lIxAIcVC2z280aVCY1x0267AKxVWUJVW8JbIYCTnIWIevJa73UjIFyTuYvjxUcV WlDUUUU X-CM-SenderInfo: xpdruxter6z05rqj20fqof0/ X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 7DCE414000D X-Stat-Signature: mugjdpysmzk19wthntj3kxyd1f7n7mdo Authentication-Results: imf09.hostedemail.com; dkim=none; spf=pass (imf09.hostedemail.com: domain of maobibo@loongson.cn designates 114.242.206.163 as permitted sender) smtp.mailfrom=maobibo@loongson.cn; dmarc=none X-Rspam-User: X-HE-Tag: 1646802845-458575 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: yeap, your patch is general and better than mine, it can solve the issue. please drop my patch. regards bibo, mao On 03/09/2022 12:14 PM, Nadav Amit wrote: > > >> On Mar 8, 2022, at 6:57 PM, Bibo Mao wrote: >> >> numa worker will periodically change vma prot with PROT_NONE, by >> default it will scan 256M vma memory size with pmd stepping size. >> If there are fewer pages changed with PROT_NONE, tlb flush is called >> with pmd size. This patch will calculate flush range for those >> pages with pte prot changed, it will reduce size for tlb flush. >> >> Signed-off-by: Bibo Mao > > Hi Bibo, > > I finally managed to make v3 of a patchiest, which I think does > something similar to what you are looking for (without introducing > yet another TLB batching mechanism). > > Have a look at [1] and let me know if that would satisfy you. > > > [1] https://lore.kernel.org/linux-mm/20220309041043.302261-4-namit@vmware.com/T/#u >