From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 758C3E7717F for ; Thu, 12 Dec 2024 19:43:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D63356B0093; Thu, 12 Dec 2024 14:43:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D12446B009D; Thu, 12 Dec 2024 14:43:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BB2316B009F; Thu, 12 Dec 2024 14:43:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 9943D6B0093 for ; Thu, 12 Dec 2024 14:43:01 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 0DE101602A0 for ; Thu, 12 Dec 2024 19:43:01 +0000 (UTC) X-FDA: 82887329154.25.7475031 Received: from mail-io1-f54.google.com (mail-io1-f54.google.com [209.85.166.54]) by imf23.hostedemail.com (Postfix) with ESMTP id C0F3E140018 for ; Thu, 12 Dec 2024 19:42:42 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b="G1/8Uabj"; spf=pass (imf23.hostedemail.com: domain of axboe@kernel.dk designates 209.85.166.54 as permitted sender) smtp.mailfrom=axboe@kernel.dk; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734032556; a=rsa-sha256; cv=none; b=1wWf6BTttw6QDmsCo4uPQHY1OU1yppuaWFEJUBd0rLTqQZVokg8sf1mDfH50hnt/iT61i9 IAA3SvoJEGn9F08nY09wAHxdIH/wgOTYk2qgccyWnHL1rOgxI3UY88vx7ewBW2exxYArdO xaP2CQS2Yc+oZQZUU0tsgC1Ee0iRke0= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b="G1/8Uabj"; spf=pass (imf23.hostedemail.com: domain of axboe@kernel.dk designates 209.85.166.54 as permitted sender) smtp.mailfrom=axboe@kernel.dk; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734032556; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZhDmuOv8D0FPGG5XFhKNfHx/yrYt1RrFNY2Fyj/oQ9Q=; b=Q73GNsO/y3ORhIAdMdf7w2CC44NFebvWQ0UY9IPRjCESVH6+n1RgU9YXKVbtipHFI1Q3ZD j09vP/DGtv1xRapzacqW7SSc/FgoQHPHZtpI6ImjjuueKKsvE3036vy708CnHvbL5A9RLY KjQqX+pk1J38kAxK9lQegGdgFW9H7IM= Received: by mail-io1-f54.google.com with SMTP id ca18e2360f4ac-844e10ef3cfso61871939f.2 for ; Thu, 12 Dec 2024 11:42:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1734032578; x=1734637378; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ZhDmuOv8D0FPGG5XFhKNfHx/yrYt1RrFNY2Fyj/oQ9Q=; b=G1/8Uabj+tqxN8fkJluFcRNlkwXGdF30vCb6ztheVfoqnLr49ychuP88inwlNjDRaA qH0L5et5x5cEZt5EfCH89lobtnNSDhxJh8rtfB9ygKxiD5SH/YF/wcO7JeP/M5zFDocc uYjSHXprWXPCnnbqN8k8V5M29a1WKyLl1yp5S2N0iZT7nysYcPAWjzbWMxuSs1lh8CCV dWzNPo7Ks3hnlDNqHzh8RKrRQUQrttsdVcVE2ib2kM8wZu9MPTd1URx5eo+/ZVXAAhft EpJxuddfto1hrh676dDTcgyvJE2U4hL7epOM1ru8cRL6WSGJqRwVAb9zaOd1NM3erXrC jlIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734032578; x=1734637378; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZhDmuOv8D0FPGG5XFhKNfHx/yrYt1RrFNY2Fyj/oQ9Q=; b=OqcZBca+ZZ4lNVzvwpyQRCIqi2pXfNQWri/iW6OoUHRuOxsY/L4bnLwDH9CyPoZ6wn qPpQIWSZsNuLb9vpSk2uekvFPhz2zwEmecftLZ0GcU7gGPiupA68aPW6oDzXnZwzOTCu qP6T+Q7FQfatjXIn0S06fiYQzyBd5bhwm0JEmTT7n1474gc1fT5+bLLlO6bzc1dlC0v2 FCzm1fGIr2QdIa6gRcm/DkCjEr+jhEU+wQ3lNphynFzIIDTkFEqBZigtHsMotRFBF8Pn gdB+ktc2SjXCPPukjUdlW76cWdXGH4bR4lU9IORQlz6BWto7lGxc5OrvW7JONjvwfO6Z pvbQ== X-Gm-Message-State: AOJu0YwBQOdb4hTPATZ3Km1WI7Ng3bQ8OKwawdV0TN7W7eM4LkCxPfjk icPUZ67uNuqgl2pqTWqqiKILxylAqlytCjj+CunUAyl4BFEyKmueyX2Ei8wi+XU= X-Gm-Gg: ASbGnctIPhEJd4DquN7sjxjyrPF/H/F/whGzftoG40LhnpoBgNhrPwrJl0Du5CbZzQW ItcV9k815YyG9gP6ev6XwtCTQAXqBTA+KXdiDcFjXZQKm4T8L2BCXH7pxIcKm9M6JqXbBYfmvkn Jj/9lvwS6rGbZdXVUL+eYQVrC6XPPkvL3bA7Hi4gG/dul+EF7l/NFPHZMmKMazXHkACrDFm2eP2 jkxWY3avXn6HnJjsbl/KeWDEvDb+9XhyUj7KemVgvO+MjX05CLO X-Google-Smtp-Source: AGHT+IHQ9OAQ1Nl/Tv0zs0jea2OTSq9Ds0NCEUjCITYW+rg/1DwzcINpTvE/QeiMM9NbTcw8U3uY5Q== X-Received: by 2002:a05:6602:27c6:b0:841:984b:47d2 with SMTP id ca18e2360f4ac-844e88eb5b8mr11787639f.14.1734032578245; Thu, 12 Dec 2024 11:42:58 -0800 (PST) Received: from [192.168.1.116] ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4e2ce6fd116sm1623110173.134.2024.12.12.11.42.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Dec 2024 11:42:57 -0800 (PST) Message-ID: <47a26818-8f15-4189-8d53-0fb11bdcb03e@kernel.dk> Date: Thu, 12 Dec 2024 12:42:56 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 07/12] fs: add RWF_UNCACHED iocb and FOP_UNCACHED file_operations flag To: Christoph Hellwig Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, hannes@cmpxchg.org, clm@meta.com, linux-kernel@vger.kernel.org, willy@infradead.org, kirill@shutemov.name, bfoster@redhat.com References: <20241203153232.92224-2-axboe@kernel.dk> <20241203153232.92224-9-axboe@kernel.dk> Content-Language: en-US From: Jens Axboe In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: C0F3E140018 X-Stat-Signature: o93pwizu6ed1f55tyk9kgyywkxmwd5ce X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1734032562-238522 X-HE-Meta: U2FsdGVkX19muJF0SFiDQUOA2HhbJSOhLgt+8OOP4lfTwgPRpxBtP3+vVGQoMpauHWixdkJUqFYDXVieMaSs+vKHf17uf0D1/j9B2ZlzXo7ZyGyMgk9o/2eguU+JDAcsNdmUsNjF3UQWaVKPnN4ddoqNJmPdnIILkC9HyA2xnvgCLFJHnYv++eCZ4Oo3YfU4QfCNLMHrcAotvzhiiZiC5b4y+/lM1IzKV8macVvPZUoVwonafoGiIuD4NeD5E6i1ERp9tNr0W0y9zSZQ6OIXMSBKkOfhposXfB4cpu+SmZsHJTb9njUUvyxrY3AGF/Kn+twCxoDkwRpCXY+h4uNly7HUI+N/bR1f8hKalT7NGgC4MULAd5zjof9HInAoNK1IIOyB1tqfahPKbfLUSEoRNfwb9Xlx/fU/VS0Y2zY44m/V3Vvn+OB58J8TllNW7V6QUlADEprxCzIDyFg5/+r6PSij26FJL8DUs6OMDDV1xT0xXF1PNu5Hzx7U6hMojbrTA/w45QX0z6mLkn+Y9uDBlr1kLhN2Lgbrr1wsLSKnOeM+C+oITZ/61ENMfqGTdXeqfiiP3IZofT/ioDwOmjuPE0PPYBLeEnMt4BTTOC2ODK9xzA3Fd9Tan9wReajLRxFiCFa/p7pPos1X2HVKP+4ZyfGF/nNzgi+KB+uXhtFNPexzFytHQtwZA9O4esG+X+Yo7yTsWY4JHtsP+OlAIWgQ7F6BrtxNXYRPTZ7RveG5DCkGbP18pPBnywzmhRZP82YrQ58PlI4bnTdNZvcrKtoLPHjkZSkWxtjxtD37hafW0tLSf0djtPkR5lN1Y1rZZ0OsWlJlOJ8eJj8Rcfb4vtelbELx4qtGXvuQUH6aWTJ1Ao+Uvi16FEgfX13YYeQ2J3bUjQDP0391B+rbiVrfDiCk7Ev8cOJ76tfob55PKwzgLoI9zLSarc8N14XxuNTDppBIIZq+gvjYDrbivYphhEQ VNSnrqNx 7aTmDuiTcLkdxyhaMtPKZFbCO/OcbMGSDowQmHUQSfv69R4EsATl+o9aKpE12NwcN/26AW1FSfyvwY7zNR+u0EoKd6o5YPde7cb8nkDx58nfmfeMPgzGHGTPFtzJbv6U/TJIk2sOV9L0YGov4OW5MdF7LGqUQswewUqk8m8jLyy8YyC5LsDXNajSk4jvejTSfvyHs2nezWM4BltF9hrhTRx6FLK8ljU0J/tv7h6M9rjCYxeOnAXh277lwDVKDiIADaTA0yJnHhCn5QDlKuKwvCQHXVVqQpL3u1b3VnxTxD+FP2JRieXrK6Vwh6vgrsvWHc9X66Ge/cLhYnoqIHjQELtRzaKaO7X+V1+4jcOi8lzu7c9XibgTEVaCm0pp4AwkQjME341QqdZku1a40f0e/BfdqCg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000589, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12/10/24 4:22 AM, Christoph Hellwig wrote: > On Tue, Dec 03, 2024 at 08:31:43AM -0700, Jens Axboe wrote: >> + if (flags & RWF_UNCACHED) { >> + /* file system must support it */ >> + if (!(ki->ki_filp->f_op->fop_flags & FOP_UNCACHED)) >> + return -EOPNOTSUPP; >> + /* DAX mappings not supported */ >> + if (IS_DAX(ki->ki_filp->f_mapping->host)) >> + return -EOPNOTSUPP; > > I'd argue that DAX is always uncached and could just ignore the flag. > Same for direct I/O. It's more of a safe guard in terms of the invalidation requiring extra work for DAX. -- Jens Axboe